Received: by 2002:a05:6358:c692:b0:131:369:b2a3 with SMTP id fe18csp5708076rwb; Tue, 1 Aug 2023 06:57:57 -0700 (PDT) X-Google-Smtp-Source: APBJJlH01aNvnoSml53vPj488p+4UEur/Tc4N42/kyK/O6bAGPD2RBRT6cymKmCjLMwe3lbQ1iX8 X-Received: by 2002:a17:906:32cd:b0:99b:22dd:f83d with SMTP id k13-20020a17090632cd00b0099b22ddf83dmr2579084ejk.55.1690898276772; Tue, 01 Aug 2023 06:57:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690898276; cv=none; d=google.com; s=arc-20160816; b=dVfcSFE51FDloLPjm3mmLeCBuv6xNZPgefSeGR7mgxdVd6+B4dnuOTY0z2U+A6D/hz BtNZYtnr14svNGpYgt3d3vwWiTd9cHFZ0g4Itu+kbOmdJJUCUVnhgvUD2L6WOJZT7cTb +J9ajYZYQfnK+iTymvV1wBuG/3arMWS9CtgiVZ+ggfnIrgmpVVuhgIEg/VjLVnTP0rxt 6mKttOGh6ZDFPz+/idHgyL/W3KifQJtvHEqCcxnGWi1R4GCPn9bFnI00O3PuYOVVjCar qOxgeiXt+aQdewDbSxfN1GJdo10Ixa4CdaP1B63tCyiuKtHfd2JtVLPhuoDbnDIPuJyy 3wSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=B3pJgstQ03Vg9nlPhSI380gWXGG5YWbwHMBFEXxPt0M=; fh=McJUvthEd5syo0QvYjOkb6T56L/ljKsFiePfhgrlCm4=; b=aubw1/P7ii8jqYq2IIGAm+XT9bMgolQVFldh2PtncNaNFUUmZ384+5aPtLW42Oml/a VNLR5VX9dbrk43OcQRWmAg5f+FhCPnX+oQMcK5OmX+PWusPl7bcqT++lnBRAujy7ZdE6 yJxUK1MZcHC+QDaLRvqXiUk8EVwH/7gqbzdFQqKLGClxGWOINXno95b1dov3hxC0OrNf H8kEAmLt6CRhAdQW4CPBsEdIZfXPws8y5V7c4NTUe1joGfnCxmzhgm3G5SSeb5tI3TJY X0utYXW2kSLYJPBThEkL5adSDL5+mVBM9i3ZbB23fJL8djhoZE/MfUAaDOlLGIstlWPu tuHA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@canonical.com header.s=20210705 header.b=iW0jeeEr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id lu44-20020a170906faec00b0098874379199si8694662ejb.163.2023.08.01.06.57.30; Tue, 01 Aug 2023 06:57:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@canonical.com header.s=20210705 header.b=iW0jeeEr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232060AbjHANC0 (ORCPT + 99 others); Tue, 1 Aug 2023 09:02:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55426 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229550AbjHANCY (ORCPT ); Tue, 1 Aug 2023 09:02:24 -0400 Received: from smtp-relay-canonical-1.canonical.com (smtp-relay-canonical-1.canonical.com [185.125.188.121]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D890D3; Tue, 1 Aug 2023 06:02:23 -0700 (PDT) Received: from quatroqueijos.cascardo.eti.br (201-43-195-14.dsl.telesp.net.br [201.43.195.14]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-1.canonical.com (Postfix) with ESMTPSA id 588853F7B7; Tue, 1 Aug 2023 13:02:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1690894940; bh=B3pJgstQ03Vg9nlPhSI380gWXGG5YWbwHMBFEXxPt0M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:In-Reply-To; b=iW0jeeErAIbkL4qdMiK5n+kc8PzMx5amc0Tss6fnYCg1+cZ1FPGOYJL9vB4upj9nb jMtSAb2bVkaHiqu/AnfXGSeLFDgJs4NaQvqWjsf8x6gYxh+AM0E+EpbY3EJ3dbuwg3 +ckFSdv6lzWtGqT1ltNv+7Os9tRP84iSH2vMLg/yRTQwtp6zEYyzWysNt+a1jrGGQ+ 0ncxcwhfgZLDkFYyKr7A2jAAPNv2PtCzGrDA9kalFlHGr1B1Z+9Z8jdEgyTdgDWWkA lAbtBkNIrAgSlM27wV1Q3ZOF2hPGC2Ir1MD9Gt/u5wkk/Rqt8tTp/LPd9EWWngIgvj Za6ub5QpSHvJg== Date: Tue, 1 Aug 2023 10:02:16 -0300 From: Thadeu Lima de Souza Cascardo To: Greg Kroah-Hartman Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Jiri Slaby Subject: Re: [PATCH] tty: n_gsm: require CAP_NET_ADMIN to attach N_GSM0710 ldisc Message-ID: References: <20230731185942.279611-1-cascardo@canonical.com> <2023080111-lucid-stiffness-ccfa@gregkh> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2023080111-lucid-stiffness-ccfa@gregkh> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 01, 2023 at 06:53:30AM +0200, Greg Kroah-Hartman wrote: > On Mon, Jul 31, 2023 at 03:59:42PM -0300, Thadeu Lima de Souza Cascardo wrote: > > Any unprivileged user can attach N_GSM0710 ldisc, but it requires > > CAP_NET_ADMIN to create a GSM network anyway. > > > > Require initial namespace CAP_NET_ADMIN to do that. > > > > Signed-off-by: Thadeu Lima de Souza Cascardo > > What commit id does this fix? Or has this always been a problem? > > thanks, > > greg k-h This has always been like this. It is not really fixing a specific commit, but introducing further restriction on access. Cascardo.