Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 1 Aug 2023 16:14:18 +0300
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Roger Quadros <rogerq@kernel.org>
Cc:     davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, s-vadapalli@ti.com, srk@ti.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] net: ethernet: ti: am65-cpsw-qos: Add Frame
 Preemption MAC Merge support
Message-ID: <20230801131418.bhcjtflj3iu77mmc@skbuf>
References: <20230725072338.20789-1-rogerq@kernel.org>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20230725072338.20789-1-rogerq@kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SkFYeEwzK3VyLzhRdXNBRGFaRExmcDBVcHF1NEx6dlA1R3o2Zy9TZUtNTGtQ?=
 =?utf-8?B?MUJ6dHNHcWdvVldxR3JTa3ZjMWhlSkg5QlYwOTQ4VXhlY0NhUG5FVHpCZHdY?=
 =?utf-8?B?NFh2cHh0Q2dicjMveGNGT2xoMDNmbmxnbkxtcmsyQzlCaFQ3dUpSblJ6TnNO?=
 =?utf-8?B?bExkZzN4OEc1UnNkZ2xRM3pnUG5aYmdEUGh0ekZnK3BXVU51RTFzZHE0MHZ3?=
 =?utf-8?B?bStTZWJidm1COXQ1Z1VwRHh2NHVOZ3ZaZWo5NDJIWEtUMWRqL2hseDFwNkxl?=
 =?utf-8?B?WWdERGNaeHB0UU5xUjZvZGl0clQxWDJFb1NtZmlMaVhaVmJhWXYrekM3K2NS?=
 =?utf-8?B?ZUoyMkpTYlBHZnhPaVoyUTNSTDNNeWlIelMyQmsxemE5MndzQmFSNTdhclQz?=
 =?utf-8?B?cnBReG9JeGNlNnlBTUR4NUsyeUpqa1hIenU0R0hlMUlGOVo1TVdsZDNGdFky?=
 =?utf-8?B?TnJHdzhOUXhsODFoQmpTSGk0VVB6MGZDT2lMSy8xZWFQMHVGOXUxbHVhdXQz?=
 =?utf-8?B?Q2V2Z2tsNTFiYUpob0ZZRDVTaHNpYTIwUUY5VVpnWmwwOHpPNlQ1TVZsU3pl?=
 =?utf-8?B?S2Q0WWx3MmcvRVRhVDBwNWtTTFNOM3cxTUYrcWZrQnZJOXYzNnNBYVJzRjl6?=
 =?utf-8?B?V3BHTlo4ZDhKWkl1TUtQNjRiOGlIQXBuTlYyeTkwWnF2QjRzZnkxSFpGcWM5?=
 =?utf-8?B?Y1gyb3pMaEtwYkpQZkRPZFVpMXAzc3VTbFFEVm5oNWd6SGprR085aC81UWw4?=
 =?utf-8?B?dGZOWmJSeVB6a0YzaVlTZ1djVGs5bm5MK0JZZklTWTdUc2lUMWxHVHlQT3VK?=
 =?utf-8?B?VjkrcWNrZ2MwVDlTWmM0L3VVWjdsZ3E2Y0NhQ3BKWCtYTmRtUTlpcjBEWXFL?=
 =?utf-8?B?SnJXUXphUmorOStXY2tMSFJwaWk1aTMrWkhHT1BldDQ4MU1OWG9GT3pFV1NZ?=
 =?utf-8?B?N2tKSnVtU2F1dHFTYU01cWZVZjFBRjBPTzRlTHlIRUpYaklPSGhvSS9FaHlS?=
 =?utf-8?B?ZE1SU0NOeVZUcmt1UnprNzhTaXhZSExOVUFLQmNmVWVkZFV2VFo4T2JHdkRD?=
 =?utf-8?B?cGNuTmxmSjVzTHUxdXh0V1gwY0V1M1lWamZ6Vi9IemdscG9jZmVRM2llZWZ1?=
 =?utf-8?B?dHBiQjEwdHhuOTR6cmNrbkZGb1FETGhpcm80WWQzWS95RzlDWkJTRkQxWWNP?=
 =?utf-8?B?YnV1NE50Y29XMEpOaDZWWkxFR0g5UStGVmhPSGVYbWxMYXFXdUtoTXhOdldp?=
 =?utf-8?B?dlhZZjJvV2VzY0pqazA4cDVITVhFUFUxZ0NxaW4xNnNXa3FENWI3ejhaU0Fs?=
 =?utf-8?B?SFlwUmJ6L3hoWElITGdxSTY1M3A5UmRHeFJGSGVLTzQ3bUhtWUdMRm40VHZY?=
 =?utf-8?B?ZDVBaEs0YWZ2aEVNNFVwR3Y0REl5MUs5d1d6eHRDV3ZPejRKZzhhYjhRMWhj?=
 =?utf-8?B?UEExRWNLVDdQWUw5SmI5U0lleVl4TTRqUmxQTzhrcnhZeEJ0b0lPVXE4MUlu?=
 =?utf-8?B?Q083WTJvU2tvRGY2RGxIZjJySS9wNE1Lc0xQeUF3aldIQkhmV2J5cU05cFhI?=
 =?utf-8?B?ckhlcnBwZ3ZhU2JXZlBvWVlOZWttanFJTTYwM2J3Tjl4TUcrZGhPR01GQWpy?=
 =?utf-8?B?ZDF2THFhTEN2ZmJERFVCUDlKS1hZVUttN0JIK3BITU10d1pxVzVDR2I3aTc0?=
 =?utf-8?B?Q1UzdTVhc3E5VmRRb2JFSndWRVNJc3lTbW9rZC9tb2FCNlRlMGlhYkF4ZVBl?=
 =?utf-8?B?MjA5L3ZnVzVJSk5NNGEzTCszY3RtVXNlS0p3N0hZdDUvcEc2cTVPMy9uL3dp?=
 =?utf-8?B?MHNjVFdIV3pZay81SElaUVN3d2pyZWZXdTAxbktWRVJ4Ny9yWTE0cEZUcXRl?=
 =?utf-8?B?VUV6UUVEVmphQ0FXQ2ZER21XRllxL1FkWnNEQjlnOVlIOUNzcUJ6MVhGMWNG?=
 =?utf-8?B?eUZ3SktpcUhnYWFXb0p2dlB1aHpFc1Jqd2NCcDYyWGwvQ3RYak5xNGgzRXVv?=
 =?utf-8?B?S0xTN3JDeGhxTnZoNzE3WUVyRzNJeHAwQkZBc2RSSXU0aFp5cmgzS3hCUXVR?=
 =?utf-8?B?U1NsYlF1VHNXbFZnbnZLQzZDTmVjKzV3bHRlNVl6OEFYWCtrWTh2TzNuTHIv?=
 =?utf-8?B?YllwY2pabFc5amg5dHI2S1JnTkU5ei96b3RDSDZ3NGNZNUM0MFdDUmg3Q21n?=
 =?utf-8?B?T3c9PQ==?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8dc9b466-3727-4360-a697-08db9291382c
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6452.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2023 13:14:21.4890
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wev4Jn3jma/iBuFn6Bt7IjlsUjLWlkNqSiONANs+Cp3CwMl9OoLLlT3GnWeRVh8NjdStBFusYDbrZ4hhUz8r/A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8712
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jul 25, 2023 at 10:23:38AM +0300, Roger Quadros wrote:
> Add driver support for viewing / changing the MAC Merge sublayer
> parameters and seeing the verification state machine's current state
> via ethtool.
> 
> As hardware does not support interrupt notification for verification
> events we resort to polling on link up. On link up we try a couple of
> times for verification success and if unsuccessful then give up.
> 
> The Frame Preemption feature is described in the Technical Reference
> Manual [1] in section:
> 	12.3.1.4.6.7 Intersperced Express Traffic (IET – P802.3br/D2.0)
> 
> Due to Silicon Errata i2208 [2] we set limit min IET fragment size to 124.
> 
> [1] AM62x TRM - https://www.ti.com/lit/ug/spruiv7a/spruiv7a.pdf
> [2] AM62x Silicon Errata - https://www.ti.com/lit/er/sprz487c/sprz487c.pdf
> 
> Signed-off-by: Roger Quadros <rogerq@kernel.org>
> ---

Also:

../drivers/net/ethernet/ti/am65-cpsw-qos.c:173:6: warning: no previous prototype for function 'am65_cpsw_iet_change_preemptible_tcs' [-Wmissing-prototypes]
void am65_cpsw_iet_change_preemptible_tcs(struct am65_cpsw_port *port, u8 preemptible_tcs)
     ^
../drivers/net/ethernet/ti/am65-cpsw-qos.c:173:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void am65_cpsw_iet_change_preemptible_tcs(struct am65_cpsw_port *port, u8 preemptible_tcs)
^
static
../drivers/net/ethernet/ti/am65-cpsw-qos.c:179:6: warning: no previous prototype for function 'am65_cpsw_iet_link_state_update' [-Wmissing-prototypes]
void am65_cpsw_iet_link_state_update(struct net_device *ndev)
     ^
../drivers/net/ethernet/ti/am65-cpsw-qos.c:179:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void am65_cpsw_iet_link_state_update(struct net_device *ndev)
^
static
../drivers/net/ethernet/ti/am65-cpsw-qos.c:699:33: error: redefinition of 'taprio'
        struct tc_taprio_qopt_offload *taprio = type_data;
                                       ^
../drivers/net/ethernet/ti/am65-cpsw-qos.c:697:33: note: previous definition is here
        struct tc_taprio_qopt_offload *taprio = type_data;
                                       ^
2 warnings and 1 error generated.
make[7]: *** [../scripts/Makefile.build:243: drivers/net/ethernet/ti/am65-cpsw-qos.o] Error 1
make[7]: *** Waiting for unfinished jobs....