Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8c591002-308e-bdba-de5f-c96113230451@quicinc.com>
Date:   Tue, 1 Aug 2023 18:37:49 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.1
Subject: Re: [PATCH] net: export dev_change_name function
Content-Language: en-US
To:     Andrew Lunn <andrew@lunn.ch>
CC:     "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Simon Horman <simon.horman@corigine.com>,
        "Kuniyuki Iwashima" <kuniyu@amazon.com>,
        Hangbin Liu <liuhangbin@gmail.com>,
        Jiri Pirko <jiri@resnulli.us>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Andy Ren <andy.ren@getcruise.com>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>,
        Venkata Rao Kakani <quic_vkakani@quicinc.com>,
        Vagdhan Kumar <quic_vagdhank@quicinc.com>
References: <20230801112101.15564-1-quic_ajainp@quicinc.com>
 <447ba1fe-b20b-4ed0-97bc-4137b2ccfb37@lunn.ch>
From:   Anvesh Jain P <quic_ajainp@quicinc.com>
In-Reply-To: <447ba1fe-b20b-4ed0-97bc-4137b2ccfb37@lunn.ch>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 8/1/2023 6:01 PM, Andrew Lunn wrote:
> On Tue, Aug 01, 2023 at 04:51:01PM +0530, Anvesh Jain P wrote:
>> export dev_change_name function to be used by other modules.
>>
>> Signed-off-by: Vagdhan Kumar <quic_vagdhank@quicinc.com>
>> Signed-off-by: Anvesh Jain P <quic_ajainp@quicinc.com>
> 
> It would be normal to include a user of the API when exposing an API.
> 
> What module needs to change the name of a device? At the moment, only
> user space can do this via netlink or an IOCTL.
> 
>       Andrew
CONFIG_RENAME_DEVICES is the module which needs "dev_change_name" API. 
Our requirement is to change the network device name from kernel space.