Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230725220056.25560-1-jorge.lopez2@hp.com> <20230725220056.25560-3-jorge.lopez2@hp.com>
 <77867e93-7785-457c-9e37-4b41503bb509@moroto.mountain> <CAOOmCE_uRxqjTYueZkStbXeU5GKRUnvFOSGNhiBbtWDfkvxveg@mail.gmail.com>
 <2978ca9d-fbab-45b1-8d90-321fb9453965@kadam.mountain> <CAOOmCE_p_QgV0QJZKtYZD+t7Y9MzNOQ9sEkfSM88VoHDUCwdCw@mail.gmail.com>
 <0f8c1b87-e211-4ca7-bf92-8fde5bb77cd2@kadam.mountain>
In-Reply-To: <0f8c1b87-e211-4ca7-bf92-8fde5bb77cd2@kadam.mountain>
From:   Jorge Lopez <jorgealtxwork@gmail.com>
Date:   Tue, 1 Aug 2023 08:24:15 -0500
Message-ID: <CAOOmCE-z6S6LEvDq-nJPtK8c1FOapo+bH2cwTuGsA2JyMfx38g@mail.gmail.com>
Subject: Re: [PATCH 2/5] hp-bioscfg: Fix memory leaks in ordered_list_elements_from_package
To:     Dan Carpenter <dan.carpenter@linaro.org>
Cc:     hdegoede@redhat.com, platform-driver-x86@vger.kernel.org,
        linux-kernel@vger.kernel.org, thomas@t-8ch.de,
        ilpo.jarvinen@linux.intel.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

I submitted a new set of patches as directed by Hans in which the
variable name 'int_value' was kept.
Thank you for replying back to me.

Regards,

Jorge Lopez

On Tue, Aug 1, 2023 at 12:54=E2=80=AFAM Dan Carpenter <dan.carpenter@linaro=
.org> wrote:
>
> On Mon, Jul 31, 2023 at 11:35:35AM -0500, Jorge Lopez wrote:
> > On Mon, Jul 31, 2023 at 11:16=E2=80=AFAM Dan Carpenter <dan.carpenter@l=
inaro.org> wrote:
> > >
> > > On Mon, Jul 31, 2023 at 11:03:42AM -0500, Jorge Lopez wrote:
> > > > On Thu, Jul 27, 2023 at 1:21=E2=80=AFAM Dan Carpenter <dan.carpente=
r@linaro.org> wrote:
> > > > >    134          int value_len =3D 0;
> > > > >    135          int ret;
> > > > >    136          u32 size;
> > > > >    137          u32 int_value =3D 0;
> > > > >
> > > > > It confused me that it's called int_value when it's not an int.  =
Just
> > > > > call it "u32 value =3D 0;".
> > > >
> > > > The variable is named int_value when it is not an int because it
> > > > stores the value reported by ACPI_TYPE_INTEGER package.
> > > > The variable will be renamed to  type_int_value;
> > >
> > > Eep!  That's even worse!  Just leave it as-is then.
> >
> > Oops!  just send a new patch using type_int_value.  Should I change it =
back?
>
> In order of preference for me, it's "value", "int_value", and
> "type_int_value".  But it doesn't really matter.  I feel there were a
> couple bugs like the size vs value_len and re-using the iterator.  You
> have addressed the real problems so lets not worry about variable names.
> Whatever you pick is fine.
>
> regards,
> dan carpenter
>