Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 1 Aug 2023 13:34:21 +0100
From:   Matthew Wilcox <willy@infradead.org>
To:     Christoph Hellwig <hch@infradead.org>
Cc:     "Wysocki, Rafael J" <rafael.j.wysocki@intel.com>,
        Christian Brauner <christian@brauner.io>,
        Andrey Grodzovsky <andrey.grodzovsky@amd.com>,
        linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        Alex Deucher <alexander.deucher@amd.com>,
        Hawking Zhang <Hawking.Zhang@amd.com>,
        Harry Pan <harry.pan@intel.com>, linux-pm@vger.kernel.org
Subject: Re: ksys_sync_helper
Message-ID: <ZMj7zTwPw/qi/bNw@casper.infradead.org>
References: <ZMdgxYPPRYFipu1e@infradead.org>
 <e1aef4d4-b6fb-46ca-f11b-08b3e5eea27d@intel.com>
 <ZMjnZhbKbNMmcUPN@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZMjnZhbKbNMmcUPN@infradead.org>
Precedence: bulk

On Tue, Aug 01, 2023 at 04:07:18AM -0700, Christoph Hellwig wrote:
> On Mon, Jul 31, 2023 at 08:27:17PM +0200, Wysocki, Rafael J wrote:
> > 
> > OK, I'll remember about this.
> > 
> > 
> > > With this
> > > and commit d5ea093eebf022e now we end up with a random driver (amdgpu)
> > > syncing all file systems for absolutely no good reason.
> > 
> > Sorry about that.
> > 
> > The problematic commit should still revert more or less cleanly, so please
> > do that if that's what you need.
> 
> We'd still need to remove abuse in amdgpu first, though.

This would effectively revert d5ea093eebf0


diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index dc0e5227119b..af04fece37d5 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -75,7 +75,6 @@
 #include "amdgpu_fru_eeprom.h"
 #include "amdgpu_reset.h"
 
-#include <linux/suspend.h>
 #include <drm/task_barrier.h>
 #include <linux/pm_runtime.h>
 
@@ -5225,17 +5224,6 @@ int amdgpu_device_gpu_recover(struct amdgpu_device *adev,
 	 */
 	need_emergency_restart = amdgpu_ras_need_emergency_restart(adev);
 
-	/*
-	 * Flush RAM to disk so that after reboot
-	 * the user can read log and see why the system rebooted.
-	 */
-	if (need_emergency_restart && amdgpu_ras_get_context(adev)->reboot) {
-		DRM_WARN("Emergency reboot.");
-
-		ksys_sync_helper();
-		emergency_restart();
-	}
-
 	dev_info(adev->dev, "GPU %s begin!\n",
 		need_emergency_restart ? "jobs stop":"reset");