Received: by 2002:a05:6358:c692:b0:131:369:b2a3 with SMTP id fe18csp5830313rwb; Tue, 1 Aug 2023 08:27:15 -0700 (PDT) X-Google-Smtp-Source: APBJJlEs6bPZ8kVRCRuMknmlMaT+3VjbX8i0qdczp3orjndmSwXf4JNDnxf7UMDJiiuFzDYTpyTF X-Received: by 2002:a17:90b:388:b0:263:d1f4:77b7 with SMTP id ga8-20020a17090b038800b00263d1f477b7mr12035431pjb.6.1690903634754; Tue, 01 Aug 2023 08:27:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690903634; cv=none; d=google.com; s=arc-20160816; b=0NMnI6BFOzc/u9qto8kk9DfiyZTvTWrGO2O3T+a94AY0XDlWOHzdWf613ibfWweCEo g9WVenwJXZmY9H6uKn4yb7VaCyh+dX1pWwjyg01/hgdtzxvV+I/N7xtzHdFpjTJQBe3b YB54JQm3rrBh6FtvRA6URz+UGGbSsVly5ePFP5U4CJCDVuSnuCkKlSDTbmXfIjGRRia0 xcuWpkzv8TyNO7p0qXn8Wc4NBcT2gSxqpWamt2kHYWsSQ599UEedwL7zrpmWnuSj9Dxc mrB2EkOaAvMjqgEYcuz97cQBEZVxXTc6RDhmj1KjxkykFZw9H85vjifLhpwq0j4cILoy bxxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=nsO+Zl7CUnASQXP0pNGTsohTGDW6byIjsx/QqCHb86M=; fh=6vpet2pvX7QBjhsdjutNm2pIY1WvX90qBvnSSCrHuK4=; b=EbzKdNJYgZNieemCLP0HFVlmj2M2e7zil8sCBC/bRizn/EXaYB87vsB0oxLoIubyYu W1dTS7DBDM/KeOpy6xskIkk7CgAdNwJLfwUNosX+0qjepoAXtpvbLNeWL0nHwjvp+TLB rpcOPYN52HxIq/JSRbY7+AAUNW9RamrrQWStzlE4grdnlGgmcRZyVMAHXcDIMN4+4mjU /oExnqIL2KiPaduJVtRiID+9x6gBfVclITTlM7hccAewZTcRgKPZ6ibMBh3ZXf7dhIEX 00e2y/RlB7zjwbuWn7YqFu4vymj4ywIC/nt7c9bQ2WlppT0hbiFYyctP4TLxxemxVNli guTw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20221208 header.b=5gjWQUE+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s21-20020a170903201500b001bb9533b968si5468380pla.408.2023.08.01.08.26.53; Tue, 01 Aug 2023 08:27:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20221208 header.b=5gjWQUE+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232619AbjHANbL (ORCPT + 99 others); Tue, 1 Aug 2023 09:31:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41604 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232622AbjHANbJ (ORCPT ); Tue, 1 Aug 2023 09:31:09 -0400 Received: from mail-qt1-x82f.google.com (mail-qt1-x82f.google.com [IPv6:2607:f8b0:4864:20::82f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 76D4C19A4 for ; Tue, 1 Aug 2023 06:31:02 -0700 (PDT) Received: by mail-qt1-x82f.google.com with SMTP id d75a77b69052e-407db3e9669so257511cf.1 for ; Tue, 01 Aug 2023 06:31:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1690896661; x=1691501461; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=nsO+Zl7CUnASQXP0pNGTsohTGDW6byIjsx/QqCHb86M=; b=5gjWQUE+sGzZJUk8GTBNFCY2Ukgx6UJk/M8SSHTXcRt2509TjEJ/WjPI5RKsHCVNAW 2LTuYOywqRolGqGCuu54wlTDlrslWqzjzb7KGVcAKKZ7ywpgaaZTliSPzNSsTHl+ats7 RJnG6m7Z+lnsV6GjWrrXLjbtjvzFZxLTDU81zurkRAvr8eH6/dIYOQgJKkgpnSy/dOtR 5+OHad0k3vx830SWafnBRC7ggC0olu4NBZnUn9VnLw+HCOQ2+x81tIvz8Srgba/ZFmfY TB0kPhcvZd3hhF5KxmSe+4EmBftUaFowGjRHIx0D58zrLg/zIpoS6Fl0h2oGe0ZGSeaQ bZ1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690896661; x=1691501461; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nsO+Zl7CUnASQXP0pNGTsohTGDW6byIjsx/QqCHb86M=; b=Q5vfoDYg4vprYSlLjpXG3vbCg2vS2YA189VcbUGfx0P5CjVTGyPW8GTBCako4x7OBU ejgXi4LVO6WG50+wX7VyNxl78kxelFCjCt2i1ERWbNz9kFOz4kwFamyxsC1jUDfV1bcn wbaq5nEgMcke3ZVLFAlvL9LwqEqhtlCbEi9GyIHRciIxOkx3Tpzo22OXKeS1UwQAlVJX MX+Cjn2AevW4wh8fcp2SmbJ8HveYzMo8AMrR7eY6PqRS8NYmEAgdcOCB+AOZp0CJoSFJ 7q6vXD42dHe8SlGxfsuAf8inuU5tzp06JSRK3FBBPdlrFJzYLLb/iJp9EPWcpDTeW53B XDTg== X-Gm-Message-State: ABy/qLZd15cY2MYG0ah+EC18V8yTWAUASPN25X8aHQd+txErRlu7whOR atXELVXCFrtQ284MFoXXuPk+63F/7dgHuGbeydI82A0X6ZcZevlf3/Q= X-Received: by 2002:ac8:7e8e:0:b0:403:b1e5:bcae with SMTP id w14-20020ac87e8e000000b00403b1e5bcaemr812745qtj.10.1690896661367; Tue, 01 Aug 2023 06:31:01 -0700 (PDT) MIME-Version: 1.0 References: <20230731230736.109216-1-trdgn@amazon.com> <64c905205b2f4_1b41af2947@willemb.c.googlers.com.notmuch> In-Reply-To: <64c905205b2f4_1b41af2947@willemb.c.googlers.com.notmuch> From: Eric Dumazet Date: Tue, 1 Aug 2023 15:30:50 +0200 Message-ID: Subject: Re: [PATCH v2] tun: avoid high-order page allocation for packet header To: Willem de Bruijn Cc: Tahsin Erdogan , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Herbert Xu , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-17.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,ENV_AND_HDR_SPF_MATCH, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, USER_IN_DEF_DKIM_WL,USER_IN_DEF_SPF_WL autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 1, 2023 at 3:14=E2=80=AFPM Willem de Bruijn wrote: > >> This exactly same allocation logic also exists in packet_alloc_skb and > tap_alloc_skb. If changing one of them, perhaps should address convert > all at the same time, to keep behavior consistent. Sure, I can take care of them as well.