Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230731203141.30044-1-jorge.lopez2@hp.com> <c891e1cb-3fb6-448a-850c-e94c48d32c66@kadam.mountain>
In-Reply-To: <c891e1cb-3fb6-448a-850c-e94c48d32c66@kadam.mountain>
From:   Jorge Lopez <jorgealtxwork@gmail.com>
Date:   Tue, 1 Aug 2023 09:52:05 -0500
Message-ID: <CAOOmCE8xLxE9fSZNhPeYumRyzg9S-C9++8LH5jDq5vVwgFMdCQ@mail.gmail.com>
Subject: Re: [PATCH 0/8] hp-bioscfg: Overall fixes and code cleanup
To:     Dan Carpenter <dan.carpenter@linaro.org>
Cc:     hdegoede@redhat.com, platform-driver-x86@vger.kernel.org,
        linux-kernel@vger.kernel.org, thomas@t-8ch.de,
        ilpo.jarvinen@linux.intel.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

I will submit a new patch replacing 'value_len' for 'size' in line 267
as indicated.
'value_len' is utilized earlier in the code so we cannot remove it
completely from the function.


On Tue, Aug 1, 2023 at 8:35=E2=80=AFAM Dan Carpenter <dan.carpenter@linaro.=
org> wrote:
>
> These are fine.  We still need to do something like this.  Also we could
> just get rid of value_len completely.  Nothing uses it.
>
> diff --git a/drivers/platform/x86/hp/hp-bioscfg/order-list-attributes.c b=
/drivers/platform/x86/hp/hp-bioscfg/order-list-attributes.c
> index cffc1c9ba3e77..6ba0e49e787ec 100644
> --- a/drivers/platform/x86/hp/hp-bioscfg/order-list-attributes.c
> +++ b/drivers/platform/x86/hp/hp-bioscfg/order-list-attributes.c
> @@ -264,7 +264,7 @@ static int hp_populate_ordered_list_elements_from_pac=
kage(union acpi_object *ord
>                          * Ordered list data is stored in hex and comma s=
eparated format
>                          * Convert the data and split it to show each ele=
ment
>                          */
> -                       ret =3D hp_convert_hexstr_to_str(str_value, value=
_len, &tmpstr, &tmp_len);
> +                       ret =3D hp_convert_hexstr_to_str(str_value, size,=
 &tmpstr, &tmp_len);
>                         if (ret)
>                                 goto exit_list;
>