Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 1 Aug 2023 16:07:15 +0200
From:   Andrew Lunn <andrew@lunn.ch>
To:     Anvesh Jain P <quic_ajainp@quicinc.com>
Cc:     "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Simon Horman <simon.horman@corigine.com>,
        Kuniyuki Iwashima <kuniyu@amazon.com>,
        Hangbin Liu <liuhangbin@gmail.com>,
        Jiri Pirko <jiri@resnulli.us>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Andy Ren <andy.ren@getcruise.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Venkata Rao Kakani <quic_vkakani@quicinc.com>,
        Vagdhan Kumar <quic_vagdhank@quicinc.com>
Subject: Re: [PATCH] net: export dev_change_name function
Message-ID: <d88e4980-66e5-4ff2-a868-7f7450181925@lunn.ch>
References: <20230801112101.15564-1-quic_ajainp@quicinc.com>
 <447ba1fe-b20b-4ed0-97bc-4137b2ccfb37@lunn.ch>
 <8c591002-308e-bdba-de5f-c96113230451@quicinc.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <8c591002-308e-bdba-de5f-c96113230451@quicinc.com>
Precedence: bulk

> CONFIG_RENAME_DEVICES is the module which needs "dev_change_name" API. Our
> requirement is to change the network device name from kernel space.

Can you give a link to this module. It is very unusual for the kernel
to change the device name. Before accepting this patch, we probably
want a better understanding of the big picture. Which is why we
normally to use the user of an API.

   Andrew