Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 1 Aug 2023 16:35:15 +0100
From:   Conor Dooley <conor@kernel.org>
To:     Mihai Sain <mihai.sain@microchip.com>
Cc:     robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        conor+dt@kernel.org, nicolas.ferre@microchip.com,
        alexandre.belloni@bootlin.com, claudiu.beznea@microchip.com,
        andre.przywara@arm.com, andrei.simion@microchip.com,
        jerry.ray@microchip.com, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        cristian.birsan@microchip.com
Subject: Re: [PATCH 1/2] dt-bindings: ARM: at91: Document Microchip SAMA5D29
 Curiosity
Message-ID: <20230801-unbalance-baguette-cd0d4e7e0107@spud>
References: <20230801111151.6546-1-mihai.sain@microchip.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="di4kJkj0aDyLBh4/"
Content-Disposition: inline
In-Reply-To: <20230801111151.6546-1-mihai.sain@microchip.com>
Precedence: bulk


--di4kJkj0aDyLBh4/
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hey,

On Tue, Aug 01, 2023 at 02:11:50PM +0300, Mihai Sain wrote:
> From: Andrei Simion <andrei.simion@microchip.com>
>=20
> Document device tree binding of SAMA5D29 Curiosity, from Microchip.
>=20
> Reviewed-by: Mihai Sain <mihai.sain@microchip.com>
> Signed-off-by: Andrei Simion <andrei.simion@microchip.com>

Your SoB is missing from here.

> ---
>  Documentation/devicetree/bindings/arm/atmel-at91.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)
>=20
> diff --git a/Documentation/devicetree/bindings/arm/atmel-at91.yaml b/Docu=
mentation/devicetree/bindings/arm/atmel-at91.yaml
> index dfb8fd089197..89d75fbb1de4 100644
> --- a/Documentation/devicetree/bindings/arm/atmel-at91.yaml
> +++ b/Documentation/devicetree/bindings/arm/atmel-at91.yaml
> @@ -79,6 +79,13 @@ properties:
>            - const: atmel,sama5d2
>            - const: atmel,sama5
> =20
> +      - description: Microchip SAMA5D29 Curiosity
> +        items:
> +          - const: microchip,sama5d29-curiosity
> +          - const: atmel,sama5d29
> +          - const: atmel,sama5d2
> +          - const: atmel,sama5

What is the benefit of adding the two familial compatibles? Is there
software that actually uses these?

Thanks,
Conor.

> +
>        - items:
>            - const: atmel,sama5d27
>            - const: atmel,sama5d2
> --=20
> 2.41.0
>=20

--di4kJkj0aDyLBh4/
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZMkmMwAKCRB4tDGHoIJi
0gCxAPwLg4OkKMAdyQsxsIrHt/o8duTRmkAL09SwVKGyqc/NvQD+IgKaOpPQrPg6
3wQ2YL6yd7uHCMTwNJR1qOstN+Fgug8=
=kiwg
-----END PGP SIGNATURE-----

--di4kJkj0aDyLBh4/--