Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 1 Aug 2023 17:42:57 +0200 (GMT+02:00)
From:   =?UTF-8?Q?Thomas_Wei=C3=9Fschuh_?= <thomas@t-8ch.de>
To:     Yuan Tan <tanyuan@tinylab.org>
Cc:     w@1wt.eu, falcon@tinylab.org, linux-kernel@vger.kernel.org,
        linux-kselftest@vger.kernel.org
Message-ID: <d8591760-8a00-4837-bc4b-21418ac7a5d6@t-8ch.de>
In-Reply-To: <cover.1690903601.git.tanyuan@tinylab.org>
References: <cover.1690903601.git.tanyuan@tinylab.org>
Subject: Re: [PATCH v3 0/2] tools/nolibc: add pipe(), pipe2() and their
 testcase
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk


Aug 1, 2023 17:40:01 Yuan Tan <tanyuan@tinylab.org>:

> Hi Willy and Thomas,
>
> In v3, I have fixed all the problems you mentioned.
>
> Welcome any other suggestion.
>
> ---
> Changes in v3:
> - Fix the missing return
> - Fix __NR_pipe to __NR_pipe2
> - Fix the missing static
> - Test case works in one process
> - Link to v2:
> =C2=A0 https://lore.kernel.org/all/cover.1690733545.git.tanyuan@tinylab.o=
rg
>
> Changes in v2:
> - Use sys_pipe2 to implement the pipe()
> - Use memcmp() instead of strcmp()
> - Link to v1:
> =C2=A0 https://lore.kernel.org/all/cover.1690307717.git.tanyuan@tinylab.o=
rg
>
> ---
> Yuan Tan (2):
> =C2=A0 tools/nolibc: add pipe() and pipe2() support
> =C2=A0 selftests/nolibc: add testcase for pipe
>
> tools/include/nolibc/sys.h=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 24 ++++++=
++++++++++++++
> tools/testing/selftests/nolibc/nolibc-test.c | 22 ++++++++++++++++++
> 2 files changed, 46 insertions(+)

For the full series:

Reviewed-by: Thomas Wei=C3=9Fschuh <linux@weissschuh.net>

Thanks!