Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1a4e6652-2e24-955c-5332-da84cced68e4@amd.com>
Date:   Tue, 1 Aug 2023 11:30:07 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH v3 05/14] virt: sev-guest: Add vmpck_id to snp_guest_dev
 struct
Content-Language: en-US
To:     Nikunj A Dadhania <nikunj@amd.com>, linux-kernel@vger.kernel.org,
        x86@kernel.org
Cc:     bp@alien8.de, dionnaglaze@google.com, pgonda@google.com,
        seanjc@google.com, pbonzini@redhat.com
References: <20230722111909.15166-1-nikunj@amd.com>
 <20230722111909.15166-6-nikunj@amd.com>
From:   Tom Lendacky <thomas.lendacky@amd.com>
In-Reply-To: <20230722111909.15166-6-nikunj@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RTZnMndQd2FETnFXZXZWMURUM25OTXM0SzV4S0t2NzVYSFdYY053d3pnSUkz?=
 =?utf-8?B?YU9hbVZHbG5yaUc4VFFSS1N6NHRXd1RycmpJZDRFbUJRNng4NDZtZzU5TG1z?=
 =?utf-8?B?WDFPcDVVZ0xZbWdQcjc1aWhpV2IzVURPdVZPSkhoajBLMC9iU0F0SVJrTkNy?=
 =?utf-8?B?aSs1VXJGNnNNdFM2WEZNUDMyajQ5QjBCT09rT3JIZzg3MGJBUGRjS1lJVEo1?=
 =?utf-8?B?SnQvLzM4N1orVkllUmdYMmJmUWVINHE3Vkd3aXgxWDA4RmhwM2p5Uyt6VTVt?=
 =?utf-8?B?TDlJZkNGZG03ckdWa1FCN3BtM2NvUFF5cXFuMzlzYW1kd2NiNVBDT3BXY2cz?=
 =?utf-8?B?eTN5elpvMk9IT2dkTkFpUVhycXBrVkRqNlNwdWVIWDBDWVEvWmZZSTgyQWpI?=
 =?utf-8?B?UUVpRzNic2RlbjRSQkk5ZGx1cCtYQzVsVEZKeUZKQU5hZTUybGRRcW5DNjl2?=
 =?utf-8?B?dlR1TDZFMjJlbmhGTGpPTjJiWmQzWTY1YlZGZC9JOTFtREdaWVlNSnU4VFND?=
 =?utf-8?B?UUZGWGZzMWV4akNCYWFUdGtoYitwQkVmSlFUOTVwNi9WS21JU25QcFdrenFW?=
 =?utf-8?B?Z1B4WTZPcmVXdHpLRkdWbjE5NUVYU2FMcFVQbFVodkh1dUVFbnI1bW5zUDJK?=
 =?utf-8?B?cGI1Ym9aZ0x2QU9aRi9XNXdIUXpQQ3NNYTd4NnZGY3lDak9LeGVVZ1BtbCty?=
 =?utf-8?B?bE14eERSaGs4TC9vWUg5dDd5dmR0cmF6ZmNSYmNNNi9BcCtyTGtCOVI1dDA5?=
 =?utf-8?B?OHZwd0JNaTZuSVVxV0ZjMFJQK0c0SWlybmNjdCtBVXBTd2lpZU5teDVJTG1n?=
 =?utf-8?B?N3BaRStzbWFyMGxZNzE4Mk93blV4WjVjV0ZXb09oUTZVcTZZUHFMdjlya3Zw?=
 =?utf-8?B?emY4ZjVCb0hZUjZzRjhRWVlzOXlUN0FGZXdaYlBxellPbVZQZFdqRkpZek8w?=
 =?utf-8?B?QWxna1BRUlFrNHQrbGNyamZ1SUU5K2JFWXJzbWY3aTljKzQraDFkVEEyUDY2?=
 =?utf-8?B?ZzlKRFZnMnV0cmI4Rm1VbUNjMUJCTC96UFdyMHBEV3BUNnJCNmFZckZWc0w3?=
 =?utf-8?B?Z1RaZ1dlUnVZUEFyQUlrQTh5Qit2eFVkajhXZ21SWURrU2xQclY5aFpSOFRi?=
 =?utf-8?B?bCtoRE5wSkNjQkZiRFY3VnZBTkxHOVRJOTZDT0pZcUF6blZ4a0kvVzhtZkZS?=
 =?utf-8?B?dmRDa0ZUaGdsS3VkSENBeFhmSlIwb0E3YW0zNjljY2pQcDM3Rjg3Mmh0a1Bs?=
 =?utf-8?B?Z2RmQ1REdXo2ald3N29XbDBSdktxVjRMaERpVGpCZ01TOVVFVDhrWnAvbXcw?=
 =?utf-8?B?RGloY3JxZnN1djFEK0NMbjhrK1lYU2djb05UVkVHSVFkK0xaM1JjUnFJem9M?=
 =?utf-8?B?czEwdGZ6NURNZnFwOWtPZ0NrWldhQWJGWDJUQmF1ZGlDdDFaQ2NzdEEzNFRk?=
 =?utf-8?B?eXNrUk82dWJjNTc2Qm9ZbjkwTTV3cjBGNlQwS1NKV2Zmb2hWbGlmMGFIYnlP?=
 =?utf-8?B?VEkrSWRDc3VZMDlxaVdQS0NsSzdLSUtUSXFuL2hNWVFTc3MzREVKQzB1bk02?=
 =?utf-8?B?NFVDaENPYlBISzQ5ZzdQR0x6VTN0a0g3bk9VUjVOcWxzNU5ZRDZBZlN2OGNl?=
 =?utf-8?B?SHNRNXdYT20vNUVEajBYOTlEK1hHcmgycUtmMnhVUm16eXkyelphRWRiV1Zu?=
 =?utf-8?B?eFY3M2dVS0hzUXpQU3NyZllTYTV1cHFIQWsrSGwzT2I4c1AwMjNtcmhmT0Rj?=
 =?utf-8?B?TkJIcmNWME9mY0NFVkhLYVlac01IVW92NmZhQzV2ZjFBYUFsUU9rZVFkZVdV?=
 =?utf-8?B?UmMzNGx2VDJEeGFuelFjUXR4ODJqNUZSUEpYc2JyVnZka1ZCeGw3V2NPN0VF?=
 =?utf-8?B?MmI3NWd3Unl3ek1QaXo2T2gxSy8vTG9HaGFrNURuemRVLytXbU1qelczRENY?=
 =?utf-8?B?Si9ZS0c1ekt5TkFPcDQxSUR5U21QakhkSFppc2dWV2NyVGFOd3VkSVJhQ1pR?=
 =?utf-8?B?bHVlZUhOT1dTeXR2V29YV2pFUUZRSm4wck5vZS9saUk4L2xYL09BaHcwTFJS?=
 =?utf-8?B?Z3lvV0lrbVJIUzBTTTNlUS96WjFhbmdrZFFSVE5Vc3UxSXpIV0tubU5nZVVp?=
 =?utf-8?Q?Q5bvWE/KHEjYt1vQtObMxW1Lm?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 67cd28c7-9f75-4563-bbf9-08db92ac9265
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5229.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2023 16:30:09.3244
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: elqDveJdyYvyJo4Qyokh5Fq184CQ3R5QXBZpAjhPzr1S/tMTL5Jj9PtyPbE1vQseCHsUAU1jHGVOWF0/nMzRSw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6012
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 7/22/23 06:19, Nikunj A Dadhania wrote:
> Drop vmpck and os_area_msg_seqno pointers so that secret page layout
> does not need to be exposed to the sev-guest driver after the rework.
> Instead, add helper APIs to access vmpck and os_area_msg_seqno when
> needed.
> 
> Signed-off-by: Nikunj A Dadhania <nikunj@amd.com>
> ---
>   drivers/virt/coco/sev-guest/sev-guest.c | 84 +++++++++++++------------
>   1 file changed, 43 insertions(+), 41 deletions(-)
> 
> diff --git a/drivers/virt/coco/sev-guest/sev-guest.c b/drivers/virt/coco/sev-guest/sev-guest.c
> index d4241048b397..8ad43e007d3b 100644
> --- a/drivers/virt/coco/sev-guest/sev-guest.c
> +++ b/drivers/virt/coco/sev-guest/sev-guest.c
> @@ -50,8 +50,7 @@ struct snp_guest_dev {
>   
>   	struct snp_secrets_page_layout *layout;
>   	struct snp_req_data input;
> -	u32 *os_area_msg_seqno;
> -	u8 *vmpck;
> +	unsigned int vmpck_id;
>   };
>   
>   static u32 vmpck_id;
> @@ -67,12 +66,23 @@ static inline unsigned int get_ctx_authsize(struct snp_guest_dev *snp_dev)
>   	return 0;
>   }
>   
> -static bool is_vmpck_empty(struct snp_guest_dev *snp_dev)
> +static inline u8 *snp_get_vmpck(struct snp_guest_dev *snp_dev)
> +{
> +	return snp_dev->layout->vmpck0 + snp_dev->vmpck_id * VMPCK_KEY_LEN;
> +}
> +
> +static inline u32 *snp_get_os_area_msg_seqno(struct snp_guest_dev *snp_dev)
> +{
> +	return &snp_dev->layout->os_area.msg_seqno_0 + snp_dev->vmpck_id;
> +}
> +
> +static bool snp_is_vmpck_empty(struct snp_guest_dev *snp_dev)

I noticed this name change from is_vmpck_empty() to snp_is_vmpck_empty(). 
Is that in prep for moving, too? Is so, maybe call that out in the commit 
message.

>   {
>   	char zero_key[VMPCK_KEY_LEN] = {0};
> +	u8 *key = snp_get_vmpck(snp_dev);
>   
> -	if (snp_dev->vmpck)
> -		return !memcmp(snp_dev->vmpck, zero_key, VMPCK_KEY_LEN);
> +	if (key)
> +		return !memcmp(key, zero_key, VMPCK_KEY_LEN);

I believe key can't be NULL, so this check isn't required.

Thanks,
Tom

>   
>   	return true;
>   }