Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <tencent_5E8D53EDF5D61E189A478942372A8C44CA06@qq.com>
From:   Zhang Shurong <zhang_shurong@foxmail.com>
To:     Mark Brown <broonie@kernel.org>
Cc:     oder_chiou@realtek.com, lgirdwood@gmail.com, perex@perex.cz,
        tiwai@suse.com, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: rt5665: add missed regulator_bulk_disable
Date:   Tue, 01 Aug 2023 23:46:36 +0800
In-Reply-To: <ZL1DUWAeBbArQL1f@finisterre.sirena.org.uk>
References: <tencent_AA66A80A12D4372BB57E5B7A60471EB00A08@qq.com>
 <ZL1DUWAeBbArQL1f@finisterre.sirena.org.uk>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

=E5=9C=A8 2023=E5=B9=B47=E6=9C=8823=E6=97=A5=E6=98=9F=E6=9C=9F=E6=97=A5 CST=
 =E4=B8=8B=E5=8D=8811:12:17=EF=BC=8CMark Brown =E5=86=99=E9=81=93=EF=BC=9A
> On Sun, Jul 23, 2023 at 03:07:31PM +0800, Zhang Shurong wrote:
> > +	ret =3D devm_add_action_or_reset(&i2c->dev,=20
rt5665_i2c_disable_regulators,
> > +			rt5665);
> > +	if (ret)
> > +		return ret;
> > +
> >=20
> >  	ret =3D regulator_bulk_enable(ARRAY_SIZE(rt5665->supplies),
> >  =09
> >  				    rt5665->supplies);
> >  =09
> >  	if (ret !=3D 0) {
>=20
> This will attempt to disable the regulators if the initial enable fails
> which is a bug.
You are right. I will move this to rt5663_i2c_remove() in next version.