Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230731203141.30044-1-jorge.lopez2@hp.com> <c891e1cb-3fb6-448a-850c-e94c48d32c66@kadam.mountain>
 <CAOOmCE8xLxE9fSZNhPeYumRyzg9S-C9++8LH5jDq5vVwgFMdCQ@mail.gmail.com> <6c6143bd-5352-4edc-a44c-143c27fbf1cf@kadam.mountain>
In-Reply-To: <6c6143bd-5352-4edc-a44c-143c27fbf1cf@kadam.mountain>
From:   Jorge Lopez <jorgealtxwork@gmail.com>
Date:   Tue, 1 Aug 2023 10:10:05 -0500
Message-ID: <CAOOmCE85enO=C+i8SUAroJpMCi7cGYvJ5TOCgsVbL2b-6pPpNw@mail.gmail.com>
Subject: Re: [PATCH 0/8] hp-bioscfg: Overall fixes and code cleanup
To:     Dan Carpenter <dan.carpenter@linaro.org>
Cc:     hdegoede@redhat.com, platform-driver-x86@vger.kernel.org,
        linux-kernel@vger.kernel.org, thomas@t-8ch.de,
        ilpo.jarvinen@linux.intel.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Ok. Thanks for the clarification.  I will remove 'value_len' and
replace all its references with 'size'.

On Tue, Aug 1, 2023 at 10:04=E2=80=AFAM Dan Carpenter <dan.carpenter@linaro=
.org> wrote:
>
> On Tue, Aug 01, 2023 at 09:52:05AM -0500, Jorge Lopez wrote:
> > I will submit a new patch replacing 'value_len' for 'size' in line 267
> > as indicated.
> > 'value_len' is utilized earlier in the code so we cannot remove it
> > completely from the function.
> >
>
> After replacing size then it looks like this.
>
> $ grep value_len drivers/platform/x86/hp/hp-bioscfg/order-list-attributes=
.c
>         int value_len =3D 0;
>                                                                &str_value=
, &value_len);
>                                                                &str_value=
, &value_len);
>
> It's a write only variable.
>
> regards,
> dan carpenter
>