Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a0d5ec0a-e5d9-5938-fa6b-1d60b2aac019@linux.intel.com>
Date:   Tue, 1 Aug 2023 13:48:45 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH v1 0/4] Intel metric fixes and event updates
Content-Language: en-US
To:     Ian Rogers <irogers@google.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Ravi Bangoria <ravi.bangoria@amd.com>,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
        Andi Kleen <ak@linux.intel.com>,
        Weilin Wang <weilin.wang@intel.com>
References: <20230801053634.1142634-1-irogers@google.com>
From:   "Liang, Kan" <kan.liang@linux.intel.com>
In-Reply-To: <20230801053634.1142634-1-irogers@google.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2023-08-01 1:36 a.m., Ian Rogers wrote:
> The metric tma_info_pipeline_retire contains uops_retired.slots with
> perf metric events. Patch 1 fixes this event sorting so that
> uops_retired.slots isn't made a group leader as that needs to be
> topdown.slots.
> 
> Patch 2 and 3 update the meteorlake and sapphirerapids events.
> 
> Patch 4 addresses an issue with event grouping discussed in:
> https://lore.kernel.org/lkml/20230719001836.198363-3-irogers@google.com/
> by adding and altering metric constraints. The constraints avoid
> groups for metrics where the kernel PMU fails to not open the group
> (the trigger for the weak group being removed).
> 
> Ian Rogers (4):
>   perf parse-events x86: Avoid sorting uops_retired.slots
>   perf vendor events intel: Update meteorlake to 1.04
>   perf vendor events intel: Update sapphirerapids to 1.15
>   perf vendor events intel: Update Icelake+ metric constraints
>

Thanks Ian.

Reviewed-by: Kan Liang <kan.liang@linux.intel.com>

Thanks,
Kan

>  tools/perf/arch/x86/util/evlist.c             |   7 +-
>  tools/perf/arch/x86/util/evsel.c              |   7 +-
>  .../arch/x86/alderlake/adl-metrics.json       |  11 +-
>  .../arch/x86/alderlaken/adln-metrics.json     |   2 +
>  .../arch/x86/icelake/icl-metrics.json         |  10 +-
>  .../arch/x86/icelakex/icx-metrics.json        |  10 +-
>  tools/perf/pmu-events/arch/x86/mapfile.csv    |   4 +-
>  .../pmu-events/arch/x86/meteorlake/cache.json | 165 ++++++++++++++++++
>  .../arch/x86/meteorlake/floating-point.json   |   8 +
>  .../arch/x86/meteorlake/frontend.json         |  56 ++++++
>  .../arch/x86/meteorlake/memory.json           |  80 +++++++++
>  .../pmu-events/arch/x86/meteorlake/other.json |  16 ++
>  .../arch/x86/meteorlake/pipeline.json         | 159 +++++++++++++++++
>  .../arch/x86/rocketlake/rkl-metrics.json      |  10 +-
>  .../arch/x86/sapphirerapids/other.json        |  18 ++
>  .../arch/x86/sapphirerapids/spr-metrics.json  |   9 +-
>  .../arch/x86/tigerlake/tgl-metrics.json       |  10 +-
>  17 files changed, 549 insertions(+), 33 deletions(-)
>