Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 1 Aug 2023 19:01:07 +0100
From:   Jonathan Cameron <jic23@kernel.org>
To:     Marcelo Schmitt <marcelo.schmitt1@gmail.com>
Cc:     nuno.sa@analog.com, lars@metafoo.de, Michael.Hennerich@analog.com,
        lgirdwood@gmail.com, broonie@kernel.org, linux-iio@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: dac: ad3552r: Correct device IDs
Message-ID: <20230801190107.2ebc3e61@jic23-huawei>
In-Reply-To: <38b71b347f9c75e926dec55d7ecfa078aedd70c6.1690804520.git.marcelo.schmitt1@gmail.com>
References: <38b71b347f9c75e926dec55d7ecfa078aedd70c6.1690804520.git.marcelo.schmitt1@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon, 31 Jul 2023 08:59:35 -0300
Marcelo Schmitt <marcelo.schmitt1@gmail.com> wrote:

> Device IDs for AD3542R and AD3552R were swapped.
> Change device ID values so they are correct for each DAC chip.
> 
Hi Marcelo,

Agreed with the patch and that it matches the datasheets.. However
needs more info in the description so that people know how urgent the fix is.

Missing.
- Fixes tag so we know what trees need the fix (as they include the ID in
  the fixes tag.
- Description of the user visible effects of this bug.

With those added I'll be happy to queue this up. Note I've just sent
a pull request for fixes, so not in a hurry for this - otherwise
I 'might' have figured out the details and added them whilst applying.

Thanks

Jonathan
> Signed-off-by: Marcelo Schmitt <marcelo.schmitt1@gmail.com>
> ---
>  drivers/iio/dac/ad3552r.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/dac/ad3552r.c b/drivers/iio/dac/ad3552r.c
> index d5ea1a1be122..a492e8f2fc0f 100644
> --- a/drivers/iio/dac/ad3552r.c
> +++ b/drivers/iio/dac/ad3552r.c
> @@ -140,8 +140,8 @@ enum ad3552r_ch_vref_select {
>  };
>  
>  enum ad3542r_id {
> -	AD3542R_ID = 0x4008,
> -	AD3552R_ID = 0x4009,
> +	AD3542R_ID = 0x4009,
> +	AD3552R_ID = 0x4008,
>  };
>  
>  enum ad3552r_ch_output_range {