Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a056ff8f-1dab-72b4-133f-a6578c7216ad@amd.com>
Date:   Tue, 1 Aug 2023 10:32:28 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH v3 01/14] virt: sev-guest: Use AES GCM crypto library
Content-Language: en-US
To:     Nikunj A Dadhania <nikunj@amd.com>, linux-kernel@vger.kernel.org,
        x86@kernel.org
Cc:     bp@alien8.de, dionnaglaze@google.com, pgonda@google.com,
        seanjc@google.com, pbonzini@redhat.com
References: <20230722111909.15166-1-nikunj@amd.com>
 <20230722111909.15166-2-nikunj@amd.com>
From:   Tom Lendacky <thomas.lendacky@amd.com>
In-Reply-To: <20230722111909.15166-2-nikunj@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dFFKQ0ZNdjlrZmV4bkl1d2dDQm1wc3pGVXpTazVROWVCVkdVSXA1Tk1QRmdx?=
 =?utf-8?B?RU1wVitsYzFqTVVXa1BTZnN2TVczeVFrZEgwelVlUTJUU25nOFdPbW5sRklK?=
 =?utf-8?B?YzhsbldSdHRJaWhudnJFbWdaditiMmFsSVFmOFNPeG5JOTN6WmZoYW9xdHov?=
 =?utf-8?B?OG9wUXdBSFBFTjk2S0FDMzlSVU1pNjhVSXRDcGtMY1hEdjZ1bnoyV3NpVW9Z?=
 =?utf-8?B?K25SZFVLeFNMTDRZMHRTb002SkxHbFA2UTBCa05FQnMvVzJxak1uQVFiM011?=
 =?utf-8?B?VmlKd2MwMXF1dE1JSUMrdUQydnRtU0FkMW9KSUhTVjVBUEFDbU1Zc25GNnRZ?=
 =?utf-8?B?RER1QVZTU3cyNDJtaVNzMm9rc3RqdmJtYllDb01VbEFhUDZEQ01zbjlOWU1N?=
 =?utf-8?B?M3lSZlRySFNBcDRNQWd0Q1VwNy9xMTJBVGx3WG1zVndVelVCakR4OWMrSEZt?=
 =?utf-8?B?SlVhVjNPL1FUNUJTNnBTTEF1TDVwUnJGM1g3eVdWbU1WUk9RTGN5T1VuWUtD?=
 =?utf-8?B?bHZLQmpZeDVPMnlZcFN4U0VRelNNYWU3ZSs1UmEwcjNjUUc2YzBYSjFrOGJM?=
 =?utf-8?B?ckNxYXRQaDR3OEMrRkplNVh4aXdkSVR1aElHcFpISEpIdE41d2I0UmNDVnN2?=
 =?utf-8?B?VGRLWjdTYlBLR0RoVGticnI1Q0h4MUpncEhYZUY2cUtlNXIzWEluYVVKa1Bk?=
 =?utf-8?B?bzNtS2NnY1lQQkkrU2xMcFpsN1F3WkNOS1VtazNjcXFQQmdRczVtQWN3OTcz?=
 =?utf-8?B?ZlRDNnc5WW1WSC94N05oNk1lMHNjN3Uxdnppd3NYazQ0Z2YrNGZ0R0V6UWdN?=
 =?utf-8?B?N1psL3NVd2hCZTJETHRuOFVIM1RLWS90UFFjQlVpemVaN28wQzNxSW1iV010?=
 =?utf-8?B?ZHNBTDIrR1NLY0kzV0EzYVRKQWM0R04wV3NCS21PZWdtMlBXdmlubmo3U3hE?=
 =?utf-8?B?S244bnRjZGlzTnV2WFJEeW82NHNLTVFOTXhQOEJhT2lKRGNBUlZpVDZPWC9T?=
 =?utf-8?B?V2RSTDdEQ3k0aTFscGtFc0RaM2JOQTNjcVJLakJDZWpKNkFiWkZtaHZLbGQz?=
 =?utf-8?B?bk9KZzRwN3hIeVF3SFJoYzVGZHNEME5VQldXaStkQlFRdzlDeEsyTDJoTzg2?=
 =?utf-8?B?d211b1o1K2FhajV3U2RZTGs5SjJpV1J4SXdxVUNGbElrWHczbE9wR1VwY2FT?=
 =?utf-8?B?cXgwWnErR3BPdXYybHI0bG1YdXZrMjUvd1NzWmNhWmZybGljM1AzUXFwMGVi?=
 =?utf-8?B?dlVTOE1FaE40ZzRYbUlLcUFGS1pjeGhKdVBuQVV0bzYydUdvSWsvUUgrbmh4?=
 =?utf-8?B?dDlKZEFCQkk1Y2pLZHpIUzhoYWVhcFYwWVcrUVpXaHhNN2RKZkdINEFqeXBU?=
 =?utf-8?B?eW1VdTNEajdhSkdKQUdTZXN1QmRSWkZpQXJodi9NNFQ2VlYxUysyeUFvQVox?=
 =?utf-8?B?MHRuSWpEM3UyZm4wNHlXRElpdGgrbmFkaGphb0RxWUtMb0U1N0VnUXg5UEhQ?=
 =?utf-8?B?emZNRGc0SDhhNEk2eWRaNlpXWVdaeDBWM1RvR3RDendweGRZaS8xZjQxRUdl?=
 =?utf-8?B?WnNqclVTMkRxZTBhaWtBWWczajI3QVJDaWhZZ3J2QlRBS2dGeXdicHFBendt?=
 =?utf-8?B?L2ZOTGZkTndaem1HMGtBbzJ6NDhIdVhqTk44NG1raDg1azlIK2ZWTG9TR3Uy?=
 =?utf-8?B?NndUbG1jTEhXVUZTR3diY29oaTExNnBxcCtGUVVQMXJqOXFkRVRjblRUeGJi?=
 =?utf-8?B?bkhvWXFwSUVPd1BEYnpKTFI2TUhDUGlWQUJEQlltSnY1WUpzT0NjeFdlazBM?=
 =?utf-8?B?MFFsQXQ1bzdnSE5LQkxYMXpkOGFHQlJtV0ZvZHE4YkVWWXJkbkN5MDRkcjNC?=
 =?utf-8?B?cnZ3NEF0ZDRIYXl2OVcyUDFPYzIrRDB3OUVoY1A4bCtEMElZZEZBOVFtSmtt?=
 =?utf-8?B?U3hBZXhGTjdBUkdBRS8wM09CRDhvWXZTbkx6UG0wQ1NRQXNORkxNaEl3MFVp?=
 =?utf-8?B?d0MxRUtMRU1VSCtvRk9IcWx3ajdRMEJQY3o5a0Q2elVmczdvOTJsME9XZUZD?=
 =?utf-8?B?KzBjRjFaUnptSlU3cnBZbXVOTFdlSWg2RTZVRjB4V0NJaDkycDlOSW11Uk04?=
 =?utf-8?Q?mb8vxLboIK/H31OkQaZIKzixN?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 89e4c028-1965-41cc-5ab7-08db92a484e4
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5229.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2023 15:32:30.7284
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5gonAQJ3Z9yrJNvDhmQG5Q1bmw+iaPA1Smx3zrekUdm+GiZHoB5sCNbzkgG/lAPb/05lqhQGNCWx00NKpudcLg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7491
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 7/22/23 06:18, Nikunj A Dadhania wrote:
> The sev-guest driver encryption code uses Crypto API for SNP guest
> messaging to interact with AMD Security processor. For enabling SecureTSC,
> SEV-SNP guests need to send a TSC_INFO request guest message before the
> smpboot phase starts. Details from the TSC_INFO response will be used to
> program the VMSA before the secondary CPUs are brought up. The Crypto API
> is not available this early in the boot phase.
> 
> In preparation of moving the encryption code out of sev-guest driver to
> support SecureTSC and make reviewing the diff easier, start using AES GCM
> library implementation instead of Crypto API.
> 
> Link: https://lore.kernel.org/all/20221103192259.2229-1-ardb@kernel.org
> CC: Ard Biesheuvel <ardb@kernel.org>
> Signed-off-by: Nikunj A Dadhania <nikunj@amd.com>

Reviewed-by: Tom Lendacky <thomas.lendacky@amd.com>

> ---
>   drivers/virt/coco/sev-guest/Kconfig     |   3 +-
>   drivers/virt/coco/sev-guest/sev-guest.c | 172 +++++++-----------------
>   drivers/virt/coco/sev-guest/sev-guest.h |   3 +
>   3 files changed, 53 insertions(+), 125 deletions(-)
>