Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 2 Aug 2023 00:01:07 +0530
From:   Vinod Koul <vkoul@kernel.org>
To:     sunran001@208suo.com
Cc:     dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dmaengine: idxd: No need to clear memory after a
 dma_alloc_coherent() call
Message-ID: <ZMlPazK9/kXjRftJ@matsya>
References: <20230721073440.5402-1-xujianghui@cdjrlc.com>
 <0bd20a5f09b3419e1d4d8c2b6786e886@208suo.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <0bd20a5f09b3419e1d4d8c2b6786e886@208suo.com>
Precedence: bulk

On 21-07-23, 07:35, sunran001@208suo.com wrote:
> dma_alloc_coherent() already clear the allocated memory, there is no need
> to explicitly call memset().

Please fix the sender name and resend. it should match s-o-b name

> 
> Signed-off-by: Ran Sun <sunran001@208suo.com>
> ---
>  drivers/dma/idxd/device.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/dma/idxd/device.c b/drivers/dma/idxd/device.c
> index 7c74bc60f582..72330876d40a 100644
> --- a/drivers/dma/idxd/device.c
> +++ b/drivers/dma/idxd/device.c
> @@ -792,7 +792,6 @@ static int idxd_device_evl_setup(struct idxd_device
> *idxd)
>  	evl->log_size = size;
>  	evl->bmap = bmap;
> 
> -	memset(&evlcfg, 0, sizeof(evlcfg));
>  	evlcfg.bits[0] = dma_addr & GENMASK(63, 12);
>  	evlcfg.size = evl->size;

-- 
~Vinod