Date: Tue, 30 Oct 2007 08:22:40 -0700
From: Randy Dunlap <rdunlap@xenotime.net>
To: Christoph Hellwig <hch@infradead.org>
Cc: Erez Zadok <ezk@cs.sunysb.edu>, viro@ftp.linux.org.uk,
       akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
       linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 2/4] VFS: swap do_ioctl and vfs_ioctl names
Message-Id: <20071030082240.1ad71e6c.rdunlap@xenotime.net>
In-Reply-To: <20071030095653.GC22413@infradead.org>
References: <11936184581182-git-send-email-ezk@cs.sunysb.edu>
	<11936184592699-git-send-email-ezk@cs.sunysb.edu>
	<20071030095653.GC22413@infradead.org>
Organization: YPO4
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 918
Lines: 28

On Tue, 30 Oct 2007 09:56:53 +0000 Christoph Hellwig wrote:

> On Sun, Oct 28, 2007 at 08:40:56PM -0400, Erez Zadok wrote:
> > +/**
> > + * vfs_ioctl - call filesystem specific ioctl methods
> > + *
> > + * @filp: [in]     open file to invoke ioctl method on
> > + * @cmd:  [in]     ioctl command to execute
> > + * @arg:  [in/out] command-specific argument for ioctl
> 
> I've never seen these in/out annotations and doubt they're valid in
> kerneldoc.  Randy?

They are just treated as part of the parameter explanation text.
I don't see any problem with them.

> > + * Invokes filesystem specific ->unlock_ioctl, if one exists; otherwise
> 
> unlocked_ioctl


---
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/