Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230725102532.3989-1-aboutphysycs@gmail.com>
In-Reply-To: <20230725102532.3989-1-aboutphysycs@gmail.com>
From:   Bartosz Golaszewski <brgl@bgdev.pl>
Date:   Tue, 1 Aug 2023 21:17:13 +0200
Message-ID: <CAMRc=MfvsRyAKnTUYZ-Xjq3mj_8XZHnLB9==AaxGpna7_jc2Sg@mail.gmail.com>
Subject: Re: [PATCH v2] gpio: lp3943: remove unneeded platform_set_drvdata() call
To:     Andrei Coardos <aboutphysycs@gmail.com>
Cc:     linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
        andy@kernel.org, linus.walleij@linaro.org,
        Alexandru Ardelean <alex@shruggie.ro>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Jul 25, 2023 at 12:25=E2=80=AFPM Andrei Coardos <aboutphysycs@gmail=
.com> wrote:
>
> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call, to access the private data of the driver.
> Also, the private data is defined in this driver, so there is no risk of
> it being accessed outside of this driver file.
>
> Reviewed-by: Alexandru Ardelean <alex@shruggie.ro>
> Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
> ---
>
> Changelog V1->V2:
> * https://lore.kernel.org/linux-gpio/CAHp75VdU1c1vUoRpbekPXoLg2DDcbSThwUm=
kdHRT2FaZ9kagRA@mail.gmail.com/T/#t
> * https://lore.kernel.org/linux-gpio/ZLpdOYxo2U+uO%2FH3@smile.fi.intel.co=
m/T/#t
> * fixed subject line: adjusted colons where needed
>
>  drivers/gpio/gpio-lp3943.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-lp3943.c b/drivers/gpio/gpio-lp3943.c
> index 79edd5db49d2..8e58242f5123 100644
> --- a/drivers/gpio/gpio-lp3943.c
> +++ b/drivers/gpio/gpio-lp3943.c
> @@ -199,8 +199,6 @@ static int lp3943_gpio_probe(struct platform_device *=
pdev)
>         lp3943_gpio->chip =3D lp3943_gpio_chip;
>         lp3943_gpio->chip.parent =3D &pdev->dev;
>
> -       platform_set_drvdata(pdev, lp3943_gpio);
> -
>         return devm_gpiochip_add_data(&pdev->dev, &lp3943_gpio->chip,
>                                       lp3943_gpio);
>  }
> --
> 2.34.1
>

Applied, thanks!

Bartosz