Received: by 2002:a05:6358:700f:b0:131:369:b2a3 with SMTP id 15csp50301rwo; Tue, 1 Aug 2023 12:43:14 -0700 (PDT) X-Google-Smtp-Source: APBJJlH6LiT9CO1FtuAjIZXGeMvArZx07endcEIXD8MB0Tg5S4J37brSE+qiIwvNhMZ3o9HmdOWc X-Received: by 2002:a17:902:ef8e:b0:1bb:d048:3173 with SMTP id iz14-20020a170902ef8e00b001bbd0483173mr12667688plb.61.1690918994417; Tue, 01 Aug 2023 12:43:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690918994; cv=none; d=google.com; s=arc-20160816; b=B0YWayPjRTx/IgUUd9Jlw4Xaa24u4TATMyN2JzC3mW3k5LPbMtxtkd4kz9GgpVYobC 7kHkAFmDf0eqoqY2UQAK9UunvZeoCsd/o01yTlX3ty9aB92jqBs4GNya6UnbfctKe+oT YqewZe0A8IjVTQ1p18M6VvEhMHrtBdKJcQ9XQYFundkUTmT3IPexkwQSjCKbFNmDouNW B/LhxB0F9GrHNDV33asr08KSejXXtLmDwv/tEbzzLJjz+PsB67gXm/gAidVm+rJgv6JQ d9hJGHT7/C+WEWT49/55JDSTxSurcvnlXWIekMgJsizW833EZcOOUr7OhTgOesgaOXsE ZbXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:dkim-signature:dkim-signature; bh=I+mHZr6IXrsMOhJHIE2jKj1GMx2+HOC57bVUND7MpNQ=; fh=FpZjwgNTqBy92kG2pYnAkzhVJ/KhPhJfwPAbgk/M8AQ=; b=M30ltRSQWAW39Dk9RDIGSOmvsbPCw2lUQqLebcioENr87UvF1cztxnajfuDshicEA9 aJp6ZVTNihs8UrPYM1ikuX5WBl8OBoXfzev2PRYdsGdJFPOIOGeenWno8lGa+JJDzLib QKPD3NSbBqlW6vHlnkv/S0ynGJYo0Py7kgUFNIAzQnaRnODm27IxxUdbnCvi+5TKKH3T tft5Td4F2tIQvUNW/G2XsJjWKgzJobyXGOQaY9GnpaPnhf2YZZWCND6UvKNhd3fGNklr V/Bs+qfhbHovaPGLFisEzXmXDgyMyaAV2VC7HLWLMWaVDYhuo9WVi42CUkKhGRupPQ9h 43Ag== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=lyQmbfqJ; dkim=neutral (no key) header.i=@suse.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h22-20020a170902ac9600b001bbcb3d9265si9410637plr.68.2023.08.01.12.42.51; Tue, 01 Aug 2023 12:43:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=lyQmbfqJ; dkim=neutral (no key) header.i=@suse.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229666AbjHARsm (ORCPT + 99 others); Tue, 1 Aug 2023 13:48:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47344 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230314AbjHARsh (ORCPT ); Tue, 1 Aug 2023 13:48:37 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C531E61; Tue, 1 Aug 2023 10:48:35 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 1EED621D12; Tue, 1 Aug 2023 17:48:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1690912114; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=I+mHZr6IXrsMOhJHIE2jKj1GMx2+HOC57bVUND7MpNQ=; b=lyQmbfqJg4zfPW4UncUMfNDQ4kBt/sh+eii6FB6Opr2T84QFEtfqV1Gaj4ETgwTNuDC1lv QxcxozIcx8wNedNGU/NsOZaeDUyBtYeL9ZGJunANYm2LEZdG/6cU8cUKJ6+altpseAUGOX A5cE755M/w41TzTlT7nZgEyyW0kdI5I= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1690912114; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=I+mHZr6IXrsMOhJHIE2jKj1GMx2+HOC57bVUND7MpNQ=; b=FGxmXe1lS/hyxwQ6FAA53dEfGKsk3PWlkc0NDmrr7r8g+hBIOoQTQKCFA4ECehp9fU6mxq VEmTPmRg+6m75ZDA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D28EF139BD; Tue, 1 Aug 2023 17:48:33 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id iLdNMnFFyWTdSAAAMHmgww (envelope-from ); Tue, 01 Aug 2023 17:48:33 +0000 Message-ID: <770a1cbd-f943-3f9a-5a0a-8bb2a8fd88ba@suse.de> Date: Tue, 1 Aug 2023 19:48:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 3/6] block: open code __generic_file_write_iter for blkdev writes To: Christoph Hellwig , Jens Axboe Cc: "Darrick J. Wong" , Andrew Morton , Matthew Wilcox , Christian Brauner , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230801172201.1923299-1-hch@lst.de> <20230801172201.1923299-4-hch@lst.de> Content-Language: en-US From: Hannes Reinecke In-Reply-To: <20230801172201.1923299-4-hch@lst.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/1/23 19:21, Christoph Hellwig wrote: > Open code __generic_file_write_iter to remove the indirect call into > ->direct_IO and to prepare using the iomap based write code. > > Signed-off-by: Christoph Hellwig > --- > block/fops.c | 45 +++++++++++++++++++++++++++++++++++++++++++-- > 1 file changed, 43 insertions(+), 2 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes