Received: by 2002:a05:6358:700f:b0:131:369:b2a3 with SMTP id 15csp62525rwo; Tue, 1 Aug 2023 12:59:23 -0700 (PDT) X-Google-Smtp-Source: APBJJlGttQIuNFxq4OBHttUe7XZJ/89HBDlvDNATHNFy4wbYKSbxwRxY7EIsQMEHLYfLYmyUIf4n X-Received: by 2002:a17:906:30d7:b0:994:55ce:1630 with SMTP id b23-20020a17090630d700b0099455ce1630mr2933325ejb.42.1690919963023; Tue, 01 Aug 2023 12:59:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690919963; cv=none; d=google.com; s=arc-20160816; b=sMB8xt3UG7aTtp86AIkVrcdac9U07mYiRYMGZQuQfJnvGfBmc9RUUfxhv2oPTfTXtk 50FtHS26FIDM8lD93VPhqdb43DkWyNGSKAoA2GjEYiXopftxZ0xipkStk4I+Sic/5/dj J0VpzjeY6bLnkEapTy/nX2v6heRt2LKBIvH3N1LtT7FYrxlzyJhTz2wzxlco9I2vkPux oW+1iXNLmikPIchdvQrdIS2g11irfCdI2LbqeEDS4XXUfI/Ke5wChb1U+EakQWSw1lsz DD7OALdQF1vVYq5mbaEfNgMWew3qCbNzP0N+OWD34O4FLD0/NlTCT2UB1zdaiir7AtnG 2QLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=do+vv2SrQ8KRO6Pge7Qkg6qAs131a+73xcrl5XkgL8w=; fh=7Bvq5+IH5cunjOF4CAsc6pfxnVmF/ZkNNKdy30Wxknc=; b=gbQ7l3UjXs6Yn9qnCQl7vkJ2xqnQ3ApvuzIS/8DfVrQ1BUHoE0VyJMvwTC/hKz0w7E wUxlgKxXVY2AOALbWfhCCFBl12Jq1BzIfUyHGTwb2XyW1xzi4/rnTgCYn4L17PXJDnv5 bQSp03sI2J8gKTH5gstc6BHt4hG/fKm7QtQaYoE0tOy9vLtybKyexrgtfhvULeELiTek BxP5gq24pIMX24elynfFKUdi3+j19Wpmix9QVzUZHo76CI+8jb1iK2vb2f/UqWMys6Jt Yw4LiFmwcX0Z133erjiEN794WPEfvXcoahhKcQRsh+X3Dh53kB8IPc8QhA+bWd0/2RhX r33Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t25-20020a1709066bd900b00991dfb5dfbdsi9152953ejs.203.2023.08.01.12.58.36; Tue, 01 Aug 2023 12:59:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230198AbjHATKx (ORCPT + 99 others); Tue, 1 Aug 2023 15:10:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45096 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229698AbjHATKs (ORCPT ); Tue, 1 Aug 2023 15:10:48 -0400 Received: from mgamail.intel.com (unknown [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 273E71BF5; Tue, 1 Aug 2023 12:10:47 -0700 (PDT) X-IronPort-AV: E=McAfee;i="6600,9927,10789"; a="349697461" X-IronPort-AV: E=Sophos;i="6.01,248,1684825200"; d="scan'208";a="349697461" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Aug 2023 12:10:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10789"; a="705892471" X-IronPort-AV: E=Sophos;i="6.01,248,1684825200"; d="scan'208";a="705892471" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga006.jf.intel.com with ESMTP; 01 Aug 2023 12:10:43 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qQulV-00G0N6-1J; Tue, 01 Aug 2023 22:10:41 +0300 Date: Tue, 1 Aug 2023 22:10:41 +0300 From: Andy Shevchenko To: Andrei Coardos Cc: linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-gpio@vger.kernel.org, paul.walmsley@sifive.com, palmer@dabbelt.com, brgl@bgdev.pl, linus.walleij@linaro.org, Alexandru Ardelean Subject: Re: [PATCH] gpio: sifive: remove unneeded call to platform_set_drvdata() Message-ID: References: <20230801074430.5179-1-aboutphysycs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230801074430.5179-1-aboutphysycs@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_SOFTFAIL,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 01, 2023 at 10:44:30AM +0300, Andrei Coardos wrote: > This function call was found to be unnecessary as there is no equivalent > platform_get_drvdata() call to access the private data of the driver. Also, > the private data is defined in this driver, so there is no risk of it being > accessed outside of this driver file. Reviewed-by: Andy Shevchenko -- With Best Regards, Andy Shevchenko