Received: by 2002:a05:6358:700f:b0:131:369:b2a3 with SMTP id 15csp64912rwo; Tue, 1 Aug 2023 13:01:30 -0700 (PDT) X-Google-Smtp-Source: APBJJlGg+rRAR80OrFDotXxsO1DnkL/k+12/EfeMXtOp9k0iK1AexzibUO8UfrKwzdFx9Z0uIlgU X-Received: by 2002:a17:906:2009:b0:99b:e04d:3079 with SMTP id 9-20020a170906200900b0099be04d3079mr2999035ejo.19.1690920090570; Tue, 01 Aug 2023 13:01:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690920090; cv=none; d=google.com; s=arc-20160816; b=v79GUhpFLrWkIotrslTFgQmFL7TVFyD5Js94GV7j/HxqiUD+zDEnf//02HSka/RLUc UZb4IQwPvpasWEsBF+PofJzJ7nWBZXydlkgHe1S2yS3YzjHYNXDnr0rOB7VV/IrjRE2U 1K+SOg2GrE1ZqI0c4VGZjNHKcae8NBJtvjSmwxQ+HMbIsrDTRWH9Zw9936LoorEyPpBY 8sBxip5//dkuSxdT+UYltCITKmcU8Dzh6kfB0pf1z1wLN0vAL7V2aVpvTO7I8vj3gw4E cBQdEEKsXOYAqORIFPUskuLuiboSov1C3t1IYmGlgfh/b/oB8+ZxfvLwDbm4J2gPGQtQ Go4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=VFhnzeMQ2vWcy19vqttXL53GsgJl0D+VzwmGe7CZo0c=; fh=4ZLxk9WgAV0qAml8rnjq/bF/33nczUcN7lbsDuTErnk=; b=iWb3PrL7sjdiYAYx6iQqLcJm/iAoV6ARtB8tz+sYqIbMRdut7pHnHyhbQll2WF7pZc 7iemXQv65YD//J8YOKiMPpf+pQzfnpDi7edjb8dSW1lGdifrPvQ9AGoVsPbIQYW5KsEw Twjmv6rRHaEngY07xIAfV92ULDaXe4V4UeJZYfzIGdDk76Xcn7o/D9maSI+EdynLT+FC UGX1hYipzmMq7T9JSV5GZTDkoS9hG3SQh2tJNBCJmJ6NHE6hDlRO9cMl6P9536hfCNBB vB+YxcHeRw2blvFkRQgM+51QxZVR+ozk2sD+nlXB+QkqPH4AcgmhI7jlRKKO8Vhb2oeX HJHQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y6-20020a1709064b0600b009938d70d887si8893170eju.382.2023.08.01.13.01.01; Tue, 01 Aug 2023 13:01:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232225AbjHATJc (ORCPT + 99 others); Tue, 1 Aug 2023 15:09:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43914 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232159AbjHATJ2 (ORCPT ); Tue, 1 Aug 2023 15:09:28 -0400 Received: from mgamail.intel.com (unknown [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6B3F41FCB; Tue, 1 Aug 2023 12:09:27 -0700 (PDT) X-IronPort-AV: E=McAfee;i="6600,9927,10789"; a="348995332" X-IronPort-AV: E=Sophos;i="6.01,248,1684825200"; d="scan'208";a="348995332" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Aug 2023 12:09:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10789"; a="794306797" X-IronPort-AV: E=Sophos;i="6.01,248,1684825200"; d="scan'208";a="794306797" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga008.fm.intel.com with ESMTP; 01 Aug 2023 12:09:25 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qQukF-00FxYw-26; Tue, 01 Aug 2023 22:09:23 +0300 Date: Tue, 1 Aug 2023 22:09:23 +0300 From: Andy Shevchenko To: Andrei Coardos Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, brgl@bgdev.pl, linus.walleij@linaro.org, Alexandru Ardelean Subject: Re: [PATCH] gpio: syscon: remove unneeded call to platform_set_drvdata() Message-ID: References: <20230801073044.4249-1-aboutphysycs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230801073044.4249-1-aboutphysycs@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_SOFTFAIL,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 01, 2023 at 10:30:44AM +0300, Andrei Coardos wrote: > This function call was found to be unnecessary as there is no equivalent > platform_get_drvdata() call to access the private data of the driver. Also, > the private data is defined in this driver, so there is no risk of it being > accessed outside of this driver file. Reviewed-by: Andy Shevchenko -- With Best Regards, Andy Shevchenko