Received: by 2002:a05:6358:700f:b0:131:369:b2a3 with SMTP id 15csp80026rwo; Tue, 1 Aug 2023 13:15:54 -0700 (PDT) X-Google-Smtp-Source: APBJJlHm8ImtujxRwsoX4l8ruaM0Xqv+GGogl3A92fHPEiama5L9mfT+pIn6dKvaGUswDOb7YjqB X-Received: by 2002:a17:902:ce8f:b0:1bb:c87d:756d with SMTP id f15-20020a170902ce8f00b001bbc87d756dmr14539523plg.42.1690920953778; Tue, 01 Aug 2023 13:15:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690920953; cv=none; d=google.com; s=arc-20160816; b=TMI6TIWCYT+xbDn4OIYB2v+ehjJKx72oelyV0euGrkmbyy4l2HRAoKJ+5laT9/xyWW wsm7ij0itmcQ3OvSDfVDuYoPdTJCLb2EJKvP2r7lwmHdAtyHWWemacPO4odSrLoWvole v4JHdWA/UVMig5z5vX86NnvSnsb9n2ZGCab3HgRgvQDN/j7ij2j6UYIjOiFatskp+N3k Skw3RDurMXk77n6hWzHZ76vcdsmHv6ceoWjRQPLfgfZK8O3BhzVzc5gwZ0hf1r8ypjlF ybX5wA5BRiKOjy5Og+10SEmln68DEiyhtp3lA104gpHaxpntDqGeS2T6OYDcJj9Lpy8B 7UAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=FNVpKYL1wuA0HtQ6aF2j6R88TkYjglgyL1NESGsIDRo=; fh=4ZLxk9WgAV0qAml8rnjq/bF/33nczUcN7lbsDuTErnk=; b=IPdlejG8qe6Z7p3+syOUiEfgp4e3cPRQNDZ/c31qNJ0fJxlfFbnsnRbaZBhTIEVcB8 9eb1yJ2cLWOY4IGKIouhXYi7/0spxNzZYCiFdVMuv6+yLSPM/PQMLpsjvgAfp2+lob4a mWDxMWTV1WApw7uK/EIqTBicwaJGd5Dc2TPvwpIs/bhGfepOYWUcVDfc6uJfFM3/7Bcw SnvcvmbsVKCIo1cL8Fw55WfNryJ3W/D4U/pLcYueKqbciyfAS0G2t6Y1sfIZFOx2PaaP sMyEkTaDbuS2daIm4uC1iWB4c1ql8QoEHS7rDb3Nfe/3FxgrgbjUYSLmhMRE/4MynOpl +ZFQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e8-20020a170902744800b001b89f653005si9592483plt.394.2023.08.01.13.15.39; Tue, 01 Aug 2023 13:15:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229703AbjHATEN (ORCPT + 99 others); Tue, 1 Aug 2023 15:04:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40930 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229495AbjHATEM (ORCPT ); Tue, 1 Aug 2023 15:04:12 -0400 Received: from mgamail.intel.com (unknown [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F6DBDF; Tue, 1 Aug 2023 12:04:11 -0700 (PDT) X-IronPort-AV: E=McAfee;i="6600,9927,10789"; a="349694880" X-IronPort-AV: E=Sophos;i="6.01,248,1684825200"; d="scan'208";a="349694880" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Aug 2023 12:03:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10789"; a="798782990" X-IronPort-AV: E=Sophos;i="6.01,248,1684825200"; d="scan'208";a="798782990" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga004.fm.intel.com with ESMTP; 01 Aug 2023 12:03:42 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qQuej-00FlHP-1K; Tue, 01 Aug 2023 22:03:41 +0300 Date: Tue, 1 Aug 2023 22:03:41 +0300 From: Andy Shevchenko To: Andrei Coardos Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, brgl@bgdev.pl, linus.walleij@linaro.org, Alexandru Ardelean Subject: Re: [PATCH] gpio: sch: remove unneeded call to platform_set_drvdata() Message-ID: References: <20230801072800.4130-1-aboutphysycs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230801072800.4130-1-aboutphysycs@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_SOFTFAIL,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 01, 2023 at 10:28:00AM +0300, Andrei Coardos wrote: > This function call was found to be unnecessary as there is no equivalent > platform_get_drvdata() call to access the private data of the driver. Also, > the private data is defined in this driver, so there is no risk of it being > accessed outside of this driver file. Reviewed-by: Andy Shevchenko -- With Best Regards, Andy Shevchenko