Received: by 2002:a05:6358:700f:b0:131:369:b2a3 with SMTP id 15csp82538rwo; Tue, 1 Aug 2023 13:18:34 -0700 (PDT) X-Google-Smtp-Source: APBJJlE55Nzkj+zjAiwfjI3ho2Sq9epHFWHyB6RSMHRHb/4YhIIidiVwrhpV/YmXWqg2HSjBiAcm X-Received: by 2002:a17:90a:318c:b0:267:f1d7:ed68 with SMTP id j12-20020a17090a318c00b00267f1d7ed68mr16517984pjb.14.1690921114545; Tue, 01 Aug 2023 13:18:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690921114; cv=none; d=google.com; s=arc-20160816; b=hZBpNu38XleKqMbOn0MDQ5J/+pC1Wim0hipJssENnYJ58+1ybZ2RFQ4Fx2mB6qjHrM 3fejZVzCRAA64pdoQrGvNxQLR+1PqMk5+MjtvuvCy0R6u3sfIJaLmPGrJuJHTGL0uzLA ta7txcIFr0w2JYxcj58yP0nNdAyPUDZca88DMoeylOuFcMrLNSfESZWiKSi5NvJCo4NW dZy9vP3WxwSYJP3ayTDR7sbgO7L3KCgqeDMFzQz/e07Jxz2nyeUannN+bkjByMDQ744C rl2GEoWsaHTkvmTlM7I26UxjYYxwg1/u3HgTQKRw+QBJSB0ne0gSAkeI7sVtxRjCfXF4 ZsUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=m7921Bp9tgwN/+nTYN+txc8YiaGzwtk05icpcbsFqGY=; fh=4ZLxk9WgAV0qAml8rnjq/bF/33nczUcN7lbsDuTErnk=; b=chNp5lijDjFf0RBOWbKekp6lVKZDkAk1+fic4tEZta1V1yf6ovo9j8iokjDH9WgBeR /Qy1ehLzHSaBfzIdhBAFb9i1XDLJfpAQrFEN+fkWrrEZAug/9pBL+gwOvO2DldNlNsti ZCB9GvyiZLGD5YYY95XCdG0EO7gDZCl5lpC+4L/OaCBhfgzImpufQkC7aMfbaYbJMbzF YSzpEwem55X6mEVB1f61zsJ9k4ReKEPcwzgwwt7R97ReDv1sLNDzd7b2743BnW9r3coI n6k9Bp1wEBnOh9rdSi/Z0f38Fvb9w3iSihHImh41d/poXOggMJAfBQmOf+ct7TEojFgF kivA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y1-20020a17090a134100b00267fe4a44b7si2473308pjf.176.2023.08.01.13.18.21; Tue, 01 Aug 2023 13:18:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232277AbjHATKT (ORCPT + 99 others); Tue, 1 Aug 2023 15:10:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44688 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232214AbjHATKK (ORCPT ); Tue, 1 Aug 2023 15:10:10 -0400 Received: from mgamail.intel.com (unknown [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 90B1A1FDA; Tue, 1 Aug 2023 12:10:09 -0700 (PDT) X-IronPort-AV: E=McAfee;i="6600,9927,10789"; a="348995420" X-IronPort-AV: E=Sophos;i="6.01,248,1684825200"; d="scan'208";a="348995420" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Aug 2023 12:10:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10789"; a="794307219" X-IronPort-AV: E=Sophos;i="6.01,248,1684825200"; d="scan'208";a="794307219" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga008.fm.intel.com with ESMTP; 01 Aug 2023 12:10:07 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qQukw-00Fz6P-0W; Tue, 01 Aug 2023 22:10:06 +0300 Date: Tue, 1 Aug 2023 22:10:05 +0300 From: Andy Shevchenko To: Andrei Coardos Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, brgl@bgdev.pl, linus.walleij@linaro.org, Alexandru Ardelean Subject: Re: [PATCH] gpio: timberdale: remove unneeded call to platform_set_drvdata() Message-ID: References: <20230801073211.4274-1-aboutphysycs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230801073211.4274-1-aboutphysycs@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_SOFTFAIL,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 01, 2023 at 10:32:11AM +0300, Andrei Coardos wrote: > This function call was found to be unnecessary as there is no equivalent > platform_get_drvdata() call to access the private data of the driver. Also, > the private data is defined in this driver, so there is no risk of it being > accessed outside of this driver file. Reviewed-by: Andy Shevchenko -- With Best Regards, Andy Shevchenko