Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 1 Aug 2023 21:55:03 +0200
From:   Nicolas Schier <nicolas@fjasle.eu>
To:     Masahiro Yamada <masahiroy@kernel.org>
Cc:     linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
        Ben Hutchings <ben@decadent.org.uk>,
        Nathan Chancellor <nathan@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>
Subject: Re: [PATCH v2 1/2] kbuild: deb-pkg: use Debian compliant shebang for
 debian/rules
Message-ID: <ZMljFyrNaH2HFXSU@fjasle.eu>
References: <20230801121926.1677205-1-masahiroy@kernel.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="XvHK78VNyfppXqPR"
Content-Disposition: inline
In-Reply-To: <20230801121926.1677205-1-masahiroy@kernel.org>
UI-OutboundReport: notjunk:1;M01:P0:MjUxifUBGQg=;5VnuFQp460+h0x1S3V38cEZhRBT
 /QtwPKLkGQN7+ZBQT6y536yQv/244+qCTxCOrlxboDgmdGTJvR+sqouj0W0oucpsVpgkgM4qz
 BCv4Gpl29FWOk8/YfqP/CRKRy6MnjL/J85U+uPVLfJFOfVrirLnjfwRy8rsg17nowq4S5AI0M
 f3zxEBvRe7AZwNwsMELFDZ0NecamMC8/mArgD4aIlM5UawU7WTyVutHzpOtjTmRI7tq+0bYCW
 inRTzbk3qTUuB0wNxf3uRWuO0C2Oe2BgYzzqcdEetA+WTZSURKW0WECRM2PzhDd/ejHXlVt2o
 DbtJvB7eDy59cG1vYIOG1iNtCyM1FbnYFpCKhU3MNP9znGmrz378a7Zv3dtKxS+XPBoHCpASV
 /9Buzt7/LMRjpcE4BoE6/BpSnhBZ15eb/gQb7o65GHKsuLGSH07yVr1zCcsDsHCn8WMUWSCim
 l7/rVDFVNwHxIdHUkeNOJ02MtU+8wl/pgVp75ut+y2RNjBJU7p+0jpvl4QgzfvBMUzVbaJnFB
 JmKss/uni9MWvX6U6urxWlMDwivMgwEfa7WI+P/ocGUBCIaXwCtnSpA8+IyaJpFBE/IYfcICl
 mv6O77zW+D2gnL+Z+HiaDin4oPiDKINnOoZc8dAGbSePKbNjJmqziRCiC+ZKJyFvI9GwC6k/s
 BRd/mvt5lHdAVq88NMLzH4D/ZFpPk98du6O/66UZ1dajbXz+ToCawBrJfk2zcbiPfrKhLM922
 O12q8fen86hTRdLeCR08UE4xrvxyOxfaTMWAuZW3wRhno2kKR/LeYorF9b7fSCtp/rF6VqQzD
 TxImFebMh9JhhE5wY47NbuoCEfTouZI5bWKTOJ/zDURfQ0IXC44ocGqb5gB/sj2hPeRgZYAKZ
 r7HHhwDy8DeIG6w==
Precedence: bulk


--XvHK78VNyfppXqPR
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Aug 01, 2023 at 09:19:25PM +0900 Masahiro Yamada wrote:
> Debian Policy "4.9. Main building script: debian/rules" requires
> "debian/rules must start with the line #!/usr/bin/make -f". [1]
>=20
> Currently, Kbuild does not follow this policy.
>=20
> When Kbuild generates debian/rules, "#!$(command -v $MAKE) -f" is
> expanded by shell. The resuling string may not be "#!/usr/bin/make -f".
>=20
> There was a reason to opt out the Debian policy.
>=20
> If you run '/path/to/my/custom/make deb-pkg', debian/rules must also be
> invoked by the same Make program. If #!/usr/bin/make were hard-coded in
> debian/rules, the sub-make would be executed by a possibly different
> Make version.
>=20
> This is problematic due to the MAKEFLAGS incompatibility, especially the
> job server flag. Old Make versions used --jobserver-fds to propagate job
> server file descriptors, but Make >=3D 4.2 uses --jobserver-auth. The flag
> disagreement between the parent/child Makes would result in a process
> fork explosion.
>=20
> However, having a non-standard path in the shebang causes another issue;
> the generated source package is not portable as such a path does not
> exist in other build environments.
>=20
> This commit solves those conflicting demands.
>=20
> Hard-code '#!/usr/bin/make -f' in debian/rules to create a portable and
> Debian-compliant source package.
>=20
> Pass '--rules-file=3D$(MAKE) -f debian/rules' when dpkg-buildpackage is
> invoked from Makefile so that debian/rules is executed by the same Make
> program as used to start Kbuild.
>=20
> [1] https://www.debian.org/doc/debian-policy/ch-source.html#main-building=
-script-debian-rules
>=20
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---

Reviewed-by: Nicolas Schier <nicolas@fjasle.eu>


--XvHK78VNyfppXqPR
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEh0E3p4c3JKeBvsLGB1IKcBYmEmkFAmTJYxYACgkQB1IKcBYm
Emnw6BAAx1BI66MtzwMSqvDYKDHqiNP6RVUbqqE+8dgAUjINHp1uKM6jjyDjjxAc
NpDGFDxHBNsnh6kZkRDuulayMKwRjCboRk4w0FGDJKk9xKrWFMPdL3eqLg3Csjiv
KsbgVWUeH8bDc/vlNPO+w2vyay8pEUiaE35/FyW+GibjaH4P7kZ7zziuYQZly49x
Wcot1PcJuOfYk6veaiRDYYrAmlMdVC458Xl/HT/NxaNZnPxFR35DwH7mqQiX9mVR
0cEawnWckHPbusXIpQbJFB2Mdf8iJgYng6qzAmj9Yn/nCn55HmnKuHfx6dbO+mFF
fHvqKDqHmo6wzsLq5owXjs7dCY40K25w9ojfgAtlx+p1TZgDWvq3nVut/J/evfPu
9dkH0KQnjDli5pZ6aw08yKYOEvfdaSO/m1+SrC3LHrIsV6hnTqu+KQNlHChzvnhu
5rho1Gc0+F4zj3q7WFqUiYFio9t/17Im1btr7a2HMLcnfnVnUzzo5N1keA7hX3e7
JuESHGQsAk+zRKi3SUSZlb2ZewPZEELLBwMDKbC7fT3uSCeQro16Wq6xeQd/9bqs
5yY0DTa34Ccrg/VtohldjLBZ2k/0sfR7qRI3JBAGzPsOkvxtj1hgMsAzSn2p84DW
/H0lgCCdDR/xGTny8k5RRz54t31Qr6UYE3AFOZ8sjN3xUydIcd8=
=61wu
-----END PGP SIGNATURE-----

--XvHK78VNyfppXqPR--