Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 1 Aug 2023 11:45:05 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     Dan Williams <dan.j.williams@intel.com>,
        Ira Weiny <ira.weiny@intel.com>,
        Davidlohr Bueso <dave@stgolabs.net>,
        Jonathan Cameron <jonathan.cameron@huawei.com>,
        Dave Jiang <dave.jiang@intel.com>,
        "Alison Schofield" <alison.schofield@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>
CC:     Jonathan Cameron <Jonathan.Cameron@huawei.com>,
        <linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Ira Weiny <ira.weiny@intel.com>
Subject: RE: [PATCH] cxl/mbox: Fix debug message print
Message-ID: <64c952b14b4e8_26168294af@iweiny-mobl.notmuch>
References: <20230731-cxl-fix-clear-event-debug-print-v1-1-42c068f500d1@intel.com>
 <64c831da6af64_52483294fb@dwillia2-xfh.jf.intel.com.notmuch>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <64c831da6af64_52483294fb@dwillia2-xfh.jf.intel.com.notmuch>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?OknOI5+YTFw5/ZVogdIysLgpS+oGCswFWH+l6hLduOzBVVW0xN7CGIhSfhA3?=
 =?us-ascii?Q?1Rj94zubd3XpgRnrYHeEGe1gT/bzu6mf7enXFv29rbsDr24E/NCKLk1Uzw/Y?=
 =?us-ascii?Q?84u2e64Ljw4ACPxpH7u/MAN5IRZHQUnt4aaklw4Iqtcik6PkSkCxm2Xo7XMU?=
 =?us-ascii?Q?jTj6Oh76iasmmhgJVNouBnGErNxKmCTRQOqWoxcZHzemDY+SrDMCUmHZ1+x8?=
 =?us-ascii?Q?DcZxfLuYHI9XPrh58DChHd9J9cMYLiSyHBWqfrpE1QiegDyiMldXhRg2VwsU?=
 =?us-ascii?Q?bzFHUZXAMNajopIWrVJu3ih31v8/ROVL8qXREtcDznCab4tizuTMnJBUjZY5?=
 =?us-ascii?Q?P9ySqbofwK4p2YD7Fly4OAcrgfm44suHe4fa8Df5ZLQZ8i9uHtX6KFKoAJu3?=
 =?us-ascii?Q?JZELRk2f4zcjjY3I/8SzQmWaVJlbQPrWD3Kuneo/iLa1PE0uXJ9/L9cUplwb?=
 =?us-ascii?Q?5ybh3pPGrK2l00YQ4BXMnkGfxCc6sMGEuojj7shx1Jt3ASipCcuSvtCOrJvp?=
 =?us-ascii?Q?e29zz4nZAYz4dOklyPXPFCmTtsRGZ8LRRoTmOWo7pLfKd14/fSweT0jH60fD?=
 =?us-ascii?Q?uxRJIfKdK2YP6V3+NK/6KfDiNrc8s3owjvtxKpG+4KwzgzX7wkFFUkKJcu+C?=
 =?us-ascii?Q?Czj+cEQM+VH295TKZvWf+dlKkLem68iPMIvLUkJaQnrdVqTkiy9ZNdFOFp/u?=
 =?us-ascii?Q?LO9unAi4CES5BZw1NQZ+iM80H3+YBcK5ExB25mRb7OU6amVqTo90hP6zchQ4?=
 =?us-ascii?Q?x7PwFM4eIAdmihFIBhTqHrMO+oe8RytKcYawd/kYfvN+detBP5RsyIhTFrE1?=
 =?us-ascii?Q?coLQiuURAcjydU1Fz/rMB1axK4g7BQpiIRSTXmKnRAfPpNj6lXrASL3O06ls?=
 =?us-ascii?Q?aP0fGohjbcitxphez18kWlZhw6gNHh+1VtYwi851PgOUX5RBwARhHmwDd77o?=
 =?us-ascii?Q?kQrV9I3/OR5GyNoKNGi1v4WGEcD3fbjKLK6vv9NX4nd8GvrTCK+0/65ID8hN?=
 =?us-ascii?Q?aS1E+Qo79hBjDQ/kVOBULVSm/LCUw9gaCruZpTuSMtLDbnNCPcxANIjLnTBr?=
 =?us-ascii?Q?ULUOvqxsgRt0B5SNblxB8lk7ooK1ORI7VumeZPnUWGmx3ISMVbRA6/C+8oks?=
 =?us-ascii?Q?hamQyES1M0Pv7a0SvPAnuHjjy+wM7Y+jmVrDW2TPnG2ybT6qweAHwqTbeSpD?=
 =?us-ascii?Q?BiIalInJYhCPzpZAZOy/VWgDmGo7L0PCEnuhdoVZP9gI3ucmJSQgU28pxE3M?=
 =?us-ascii?Q?KSNpeAaYl9FrWHZDtudhDAZJh1gGMs+CyjSREpd5U50x7Tx2OSN15wG62A3q?=
 =?us-ascii?Q?0VO5aoWPaiT46g7hli6AawL7nii5HzwU55nBZV0Ew30MQjC8LA3/kvLTyJpG?=
 =?us-ascii?Q?z18B6/SnopqKaWEfbFMf1Dh+AyhBf6JW44BE3Pk3w0j9QbQjeihIgKviWUxM?=
 =?us-ascii?Q?E6mW1Lc1NRnDaqONz11mw2fuYHFSMtxFOh+d0N5hNM6RHZVKmP6XjItnZcnU?=
 =?us-ascii?Q?GvCAyVpMmByCXSC9tvXVdB1V6Jy70wc8/AJ/dTvbOOnIGoyJatkC3uUdeUn5?=
 =?us-ascii?Q?VWGzwWUQket/tMbcRqvAABm9M2hkElKc4/g9LvPW?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a5d1ccb5-a749-4475-f12f-08db92bf6e6f
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2023 18:45:09.4897
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: z493UtZfKREs41u4RcTgO9GtaxVziEAYuEs8biKHf30/J8ZrM7PgkDhWjpzXtqJNkvLo4UmTl51H6lfi1XucVQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB6994
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Dan Williams wrote:
> Ira Weiny wrote:
> > The handle value used to report an event being cleared by dev_dbg() is
> > incorrect due to a post increment of the payload handle index.
> > 
> > Delay the increment of the index until after the print.  Also add the
> > debugging for event processing which was useful in finding this bug.
> > 
> > To: Davidlohr Bueso <dave@stgolabs.net>
> > To: Jonathan Cameron <jonathan.cameron@huawei.com>
> > To: Dave Jiang <dave.jiang@intel.com>
> > To: Alison Schofield <alison.schofield@intel.com>
> > To: Vishal Verma <vishal.l.verma@intel.com>
> > To: Dan Williams <dan.j.williams@intel.com>
> 
> Is this some new process recommendation to use "To:", I would only
> expect Cc: for maintainers.

It is just what b4 does because all those folks are listed as maintainers.

> 
> > Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> 
> Jonathan gets listed twice because?

That is odd.  I did not notice that.

> 
> > Cc: linux-cxl@vger.kernel.org
> > Cc: linux-kernel@vger.kernel.org
> 
> I assume this is because b4 takes its address from the patch itself?
> 
> It just feels a bit too noisy.

Yea b4 generated the list and I just copied it here.  Vishal is correct
that this is automatically put in the tracking cover letter commit b4 uses
but I copied it here because it was not a series.  I'll skip this in the
future.

> 
> > Signed-off-by: Ira Weiny <ira.weiny@intel.com>
> > ---
> > NOTE: This does fix a bug in the patch referenced below.  However, I
> > don't think that warrants back porting because this is only a debug
> > print.
> 
> I don't think that's a reason not to flag for backport. Smaller things
> than this have been backported, and if it saves someone getting confused
> in the field its worth it.

Ok.

> 
> > 
> > Fixes: 6ebe28f9ec72 ("cxl/mem: Read, trace, and clear events on driver load")
> > ---
> >  drivers/cxl/core/mbox.c | 9 +++++++--
> >  1 file changed, 7 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c
> > index d6d067fbee97..f052d5f174ee 100644
> > --- a/drivers/cxl/core/mbox.c
> > +++ b/drivers/cxl/core/mbox.c
> > @@ -882,9 +882,10 @@ static int cxl_clear_event_record(struct cxl_memdev_state *mds,
> >  	 */
> >  	i = 0;
> >  	for (cnt = 0; cnt < total; cnt++) {
> > -		payload->handles[i++] = get_pl->records[cnt].hdr.handle;
> > +		payload->handles[i] = get_pl->records[cnt].hdr.handle;
> >  		dev_dbg(mds->cxlds.dev, "Event log '%d': Clearing %u\n", log,
> >  			le16_to_cpu(payload->handles[i]));
> > +		i++;
> >  
> >  		if (i == max_handles) {
> >  			payload->nr_recs = i;
> > @@ -946,9 +947,13 @@ static void cxl_mem_get_records_log(struct cxl_memdev_state *mds,
> >  		if (!nr_rec)
> >  			break;
> >  
> > -		for (i = 0; i < nr_rec; i++)
> > +		for (i = 0; i < nr_rec; i++) {
> > +			dev_dbg(dev, "Event log %d: processing handle %u\n",
> > +				type,
> > +				le16_to_cpu(payload->records[i].hdr.handle));
> >  			cxl_event_trace_record(cxlmd, type,
> >  					       &payload->records[i]);
> 
> This looks unrelated to the fix.

It helped me to debug the issue.  Since you want this marked as a fix for
backport I will split this out.  Potentially just squash it into some
other patch or make it stand alone.

Ira