Received: by 2002:a05:6358:700f:b0:131:369:b2a3 with SMTP id 15csp128809rwo; Tue, 1 Aug 2023 14:11:46 -0700 (PDT) X-Google-Smtp-Source: APBJJlHG8BYjhaO9Z9qEOqIV2mvyKTEOmU/IzkHW9JcMDNbLV6dkkpGwR/tLKmpO5ZlHNy7NRFkI X-Received: by 2002:a17:907:1dee:b0:99b:c1b7:d806 with SMTP id og46-20020a1709071dee00b0099bc1b7d806mr3396336ejc.0.1690924305721; Tue, 01 Aug 2023 14:11:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690924305; cv=none; d=google.com; s=arc-20160816; b=cvWNLmaLfzkD+IskD3BNWAqkse+B9pWd8IA2IQ7lBic0i8Yd/tZblUB6q4FaAh93rt W6bPiaJgNRBpJJbtatkrk+XwxfDTBHM4xbvq17RpM6ECwPpcGPZzmooCBhiftlAsgw4I cMpxAXy2xLvJoP8YsJv2RsrRsLMGt+zdOAnOuxJhPVBXjKQKlK5y0za+GhamHOYJru3R D9xOidu5AcXVq7mPUk1qI1yZwCQ+YrOG9WkH2MaDSxcRB24I+h6HvSQdFRu5mekhZdLI +e5HkRgaDYGf/i2qs6au2enq1zMOasaEio3FIwiQ/xz0TMgH/IpyKQ/EKc4lUN/0mlQ3 uzBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=0TW+XNVjSZPiQBPc2PK1jEIAkLQfuf9fyErg2IhQhaM=; fh=PPvD16/9phF3SJbq2XdEktT/YhlqUSpjb5s4TwmwDDg=; b=OA4Xx+yoqm9iyc7+tny7gdUhQHKuexMBXJMHg9JUzVpuVsAmKIs+PGlhd7hcp+OMJ3 qZCf17Sq38f9h74f54cagK8Xf9AoXgbaecrdxq9sBNoKZj9ldIZozSDHTyYOeewKk9YW quhwg7Xe0ctLBLmkorY5nJsU+flSRuKaA04b5sfTrS72wnEJqqD9nzG+uImJxlBsmcJ7 9iEoUhr9Rtif3l3143wHPbfeWaIEgQPWu4ARVdn8sVriCyUnFHQFzHzD58ewx48sIMzl iQOU8HvbVQoBlvb1i6TOvbfVcnSu/Hdc3PbpR5Ifxfin719Bxri7mVEZ/HsKkFd20Dgi FezQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=q0P0AhH2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r17-20020a170906c29100b009930253bc63si8247127ejz.1024.2023.08.01.14.10.51; Tue, 01 Aug 2023 14:11:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=q0P0AhH2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230113AbjHAULu (ORCPT + 99 others); Tue, 1 Aug 2023 16:11:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43296 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229535AbjHAULt (ORCPT ); Tue, 1 Aug 2023 16:11:49 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2629BE71 for ; Tue, 1 Aug 2023 13:11:49 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B3EEA616CC for ; Tue, 1 Aug 2023 20:11:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B9528C433C7; Tue, 1 Aug 2023 20:11:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690920708; bh=0gCBbS6tj9vwj7Q7yqVIWg0y6AxgBA6QkVD5cPt2Tag=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=q0P0AhH2PjRdCup+bz0QUvVga1KT6jxrbjnHmehAHcEAecETIY8mkdLDiLh4attCI f9MB6WbvBXVtrN9yNnSjVcRxvXzJ8qX5nn9JliUSjkWTd4qwP5OAIHJLgZvVJqs5b1 6T0MXKzIV3sluCzHzpvLg1phbBgIEoU64tCRBH85OSqn/GRtZFYltvXqb0nptLgs1Y 0gsg6150EML3ukOwdel8kE768dD3xNyan8C/5trWJhXWeE1X8ZXo5AsjqPFPvtMHtT mm51mQGwvuw/HsXP709M4K1j9RZM/bZEzYLqcLSJAYE71vveQeejwaSAKJ2GYPvhf9 cY422eqtPAdEg== Date: Tue, 1 Aug 2023 13:11:46 -0700 From: Jakub Kicinski To: Eric Dumazet Cc: Yue Haibing , davem@davemloft.net, dsahern@kernel.org, pabeni@redhat.com, yoshfuji@linux-ipv6.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, simon.horman@corigine.com Subject: Re: [PATCH v3] ip6mr: Fix skb_under_panic in ip6mr_cache_report() Message-ID: <20230801131146.51a9aaf3@kernel.org> In-Reply-To: References: <20230801064318.34408-1-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 1 Aug 2023 09:51:29 +0200 Eric Dumazet wrote: > > - skb_push(skb, -skb_network_offset(pkt)); > > + __skb_pull(skb, skb_network_offset(pkt)); > > > > skb_push(skb, sizeof(*msg)); > > skb_reset_transport_header(skb); > > Presumably this code has never been tested :/ Could have been tested on 32bit, I wonder if there is more such bugs :S