Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a947a270-dad6-5486-2e11-feb288aa9210@intel.com>
Date:   Tue, 1 Aug 2023 14:10:20 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH v3 03/12] x86/alternatives: Disable LASS when patching
 kernel alternatives
Content-Language: en-US
To:     "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>,
        "Lutomirski, Andy" <luto@kernel.org>,
        "alexander.shishkin@linux.intel.com" 
        <alexander.shishkin@linux.intel.com>,
        "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
        "x86@kernel.org" <x86@kernel.org>,
        "Shankar, Ravi V" <ravi.v.shankar@intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Luck, Tony" <tony.luck@intel.com>
References: <20230609183632.48706-1-alexander.shishkin@linux.intel.com>
 <20230609183632.48706-4-alexander.shishkin@linux.intel.com>
 <40ac9a487c723eff9eb069a5795760b1caf02f18.camel@intel.com>
From:   Sohil Mehta <sohil.mehta@intel.com>
In-Reply-To: <40ac9a487c723eff9eb069a5795760b1caf02f18.camel@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VzFQWGdYZTdUSnN5bU1HZDhISjdTOUJwQ2RFTUVFS3FXTFJCVXZkOEwvSXAv?=
 =?utf-8?B?TXF4V2lBQ081c2pKQUpieXl3SWJobVRZOHV3MW1iWjJBTkhXWk1DQXlTbVJw?=
 =?utf-8?B?eVQ2djRqOUpkSm9QTEdLNjdSVGVKQzd1TFVDeElPUlVDOWZlYzN4N2tHSHVr?=
 =?utf-8?B?VlQ0OWNhZTB6eXR3YmYvanVzM3FhZXNKTjk4aEJrVjdPelNCMmF6dmgvS3Nk?=
 =?utf-8?B?SFVsZSs3UUx5dHRWNjFYTXNlUXcxUXFjZHlJc3ZGT0ovQ25jNjRvVXpXbEJQ?=
 =?utf-8?B?bVlqdWdGSmpxcGhsMWVvbk1jeWdNd09BNm9uS1JBOVBrWFhvRkNuSzVFVFlF?=
 =?utf-8?B?SG1aaUJNZVZyN2lNRm9jNkhzSHA0MGRLTGZPeS92L0lGSlNiQTl0RUx6YWI2?=
 =?utf-8?B?MjNHaG50eFRZbkwvYXQ5ZnlmMEQ3b1czTG9KdWRyU2gxL3dsZUV1clVRL1ZX?=
 =?utf-8?B?VEoxeDVYejh3SUVUakpyb1drQVlSKzZyYS9Bc1lacWtxOUN5ZU5uRFAwcHZ4?=
 =?utf-8?B?VVpWcHBVQWFMekgrR0dVNTA1OGhJUDRlME9HcFhNdUpwRG8yTDd0R2Q0UEcx?=
 =?utf-8?B?OVVJZ0lwWFdGdHlMYjE3UUJKK2p0UE82d3NNOXpiaUcvNHFPUjcxeUNmQVVn?=
 =?utf-8?B?djZjR0tCRDdWV1l1SlJnT1hFN2lpWjFyZEpIYURKeUlOLzdsZHJPSVFMT29Y?=
 =?utf-8?B?cG9Xamw3WjhWcEhmQ0tYZTdreU16b1ZFa0ZTMDVWSzhlOGdLY3p1RE80U2xW?=
 =?utf-8?B?a0ptZC9hdTlrRVVDb2hxMGNYNUZOdnFESTJkd2srOW55OEs2V09WZE1BY2dR?=
 =?utf-8?B?MjNETnFwalV3VDlKK0Q1T252Vkg0QmdIdE9FdUF3Tm5VTGNTVkZYczl3Y1Qv?=
 =?utf-8?B?OU0weDRWbVdnaWNtU1hjUVlNVTZ2b0xNQnB0aDlIcW1EeHpPWDVDUmg4TVBy?=
 =?utf-8?B?SlB2N1JaRG9nR00yNW1ZcHRiVFVoZFl6Y3h4OTZRTHlobDcxaGtodE12WDdL?=
 =?utf-8?B?UkpPKzVEM0FUcGRweGZWQjl2UC9OS2tBRUhSV20yTy9Cd0E3NzJSQkJkd2Zh?=
 =?utf-8?B?RHppYkRmTytTWHZTNU9OVjB2aGdGbXFUQWQrMnQ1Qm9FN2NnL0d5MTlvYTJm?=
 =?utf-8?B?Y2E3aWREVmhhNHNmR1htVC9Dc0RnOXYvd1dNTHB4WXo5Z01MWkV0emlYL2c2?=
 =?utf-8?B?L3J3YVExVmN3dzAxY1NaL0FyWHVQdExpS2FuUzRBTzlXT1ZCMnQ4d0V0Q2Yx?=
 =?utf-8?B?ZDdCUWJNeHppNGNtb29ZU05jeWZUUkRpRjJOb2xPd3NlSzYrYW9SRkFpK2dJ?=
 =?utf-8?B?em9WZlVTaHBZU1R3VXUzUFl4NnROaWg1eUhuakpGNGY3bGgzOUNEdEhra2Fi?=
 =?utf-8?B?UE5qdUdBaEVVYWREazRWUTVWbTV6L0FyOE1KQnFPOXF3UThVUlNCVVNCWmRs?=
 =?utf-8?B?TDlwM2ZlTEJraHZNc25zUWZRaGhVYTJqcUlLNW5hTzhVWFhuejNvazNNTmt1?=
 =?utf-8?B?WmUzRFNFaHdIRmFaMXB4S053Tlp6cFU2MksycnV6RzI4WmMwZlA0RE9mcm9k?=
 =?utf-8?B?ekoxMnE0SVNvaU5pTnM1UlQ5ckl6QkZURmJsK0EyRWNTcWxOenpIWS85d051?=
 =?utf-8?B?aXB0MDJaRno3WWJvMHFzc0tycUl5NnNQOE5hMEN6MjlQclh2UllpTFQyQWpF?=
 =?utf-8?B?SWNJc1BVaFRoUUZZSWtZSTNnYU9tMlptTW1kNFdqdWlNMGRMM3BKZ0x5aVBj?=
 =?utf-8?B?M0xBaXNIN0ZWMW04a3RaUUIzYlU1NzNGUUxCaWl2emMvaUx2SzFHQnZmRnRP?=
 =?utf-8?B?QmxYMGFLRHBPdnpJMWpxQnZrV1pqdUVOSnd0ZkJlY25yVXR0T2ZrNUJkZjFN?=
 =?utf-8?B?d3FCNmwyNzVkUkJQNE94TEFreC9WY3VCcXVybjJ2alJrYWhDNlEyYUJicFV6?=
 =?utf-8?B?Y096amRSVGs2TTdqdVdzSUZudDlYSFpleTRQQUtkMnQraVVHRWdEYU84cXdH?=
 =?utf-8?B?S0ZyMlcyOFo5R0dlMHk3c0FVWGUrczBXWnZueUVXRzloYUd2bjNmQUZVWG9J?=
 =?utf-8?B?cTV6VE9zZk56cllFaWlZZEQzTHFOVnd1ZmUyamxwSHAxYVdGTW9vQ2l1UWxu?=
 =?utf-8?Q?VJS75FJ8JleevL4agYHvOdopy?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a2859a27-1894-4a58-20c7-08db92d3b76b
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3320.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2023 21:10:21.7431
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: j3s2U2ZU55WtPUqE674tY7if/zz7Iiuga6l+9YwjfjRCPoLnEj74E6OmU0BeieiJXdaJDWFMlbF3q7UYTIC8IQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4685
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Why not do stac/clac in a single place inside __text_poke()?

It would mostly look something like this:
> diff --git a/arch/x86/kernel/alternative.c b/arch/x86/kernel/alternative.c
> index 0fbf8a631306..02ef08e2575d 100644
> --- a/arch/x86/kernel/alternative.c
> +++ b/arch/x86/kernel/alternative.c
> @@ -1781,7 +1781,9 @@ static void *__text_poke(text_poke_f func, void *addr, const void *src, size_t l
>         prev = use_temporary_mm(poking_mm);
> 
>         kasan_disable_current();
> +       stac();
>         func((u8 *)poking_addr + offset_in_page(addr), src, len);
> +       clac();
>         kasan_enable_current();
> 
>         /*

Since, __text_poke() uses a dynamic function to call into
text_poke_memcpy() and text_poke_memset(), objtool would still complain.

> arch/x86/kernel/alternative.o: warning: objtool: __text_poke+0x259: call to {dynamic}() with UACCESS enabled

We could change __text_poke() to not use the dynamic func but it might
be a bit heavy handed to save a couple of lines of stac/clac calls. The
current trade-off seems reasonable to me.

Did you have something different in mind?

Sohil