Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <cf65724c-a351-8369-156d-ddf6fa47f97f@intel.com>
Date:   Tue, 1 Aug 2023 13:41:18 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Betterbird/102.13.0
Subject: Re: [PATCH v2 2/2] cxl/mbox: Add handle to event processing debug
To:     Ira Weiny <ira.weiny@intel.com>,
        Davidlohr Bueso <dave@stgolabs.net>,
        Jonathan Cameron <jonathan.cameron@huawei.com>,
        Alison Schofield <alison.schofield@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        "Dan Williams" <dan.j.williams@intel.com>
CC:     <linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20230731-cxl-fix-clear-event-debug-print-v2-0-9bdd08d386e9@intel.com>
 <20230731-cxl-fix-clear-event-debug-print-v2-2-9bdd08d386e9@intel.com>
Content-Language: en-US
From:   Dave Jiang <dave.jiang@intel.com>
In-Reply-To: <20230731-cxl-fix-clear-event-debug-print-v2-2-9bdd08d386e9@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?elNXV3QxNnBDOVJwdU9YSjF4M0JwT0NobUpVdjd3R3NldENzenhiZ29icjlu?=
 =?utf-8?B?bDZuNnJLOUUxeHlHZnJIT0xrWWswRmdpd3JpVXd0dEI5cEJ0NUNvV3NldW9Q?=
 =?utf-8?B?Wnh0QjJ4OHQxY1dCT1JZQUtrREpVc0svMWpDRE5UeXl3TVNwTWRvbDk5bUdN?=
 =?utf-8?B?SkhEU1NHcFp0UDQ5UDliVmtCNUc1T3E0czR2cGFrek1xMW1QSE1uNVlGMjhI?=
 =?utf-8?B?emJuZ1JBV0dTS2N1SHJRTnpNdnJ1VnIwdEIydG1mdHpRVU9RUDN3amVINjdR?=
 =?utf-8?B?a0ZKUE8rb0lCUzJNa0xUbTBDakpOT09mY0Jqd0hxVjhkUGk2YnQ0UWp2L3RW?=
 =?utf-8?B?N0c1S3MxdWt3U1BqODJKTGp6MXFEbjBqVDY1ZkNvdE8zSDZadnlOVUY2UUNL?=
 =?utf-8?B?S0dYUDVLN2pJaEVKN3BhdmVwYmlSdU5Pc0dtYXlSSkVxUFJBK2RWTlV1QWZ0?=
 =?utf-8?B?STVzQVNwKzhSMGhNZzJsNnZoSi9SL2Yra2VVQm1EUVFBay9yWXRmbkxkNVI0?=
 =?utf-8?B?TlUrSjl6YWwxeTZ5eGtqT3MwKzNCNUdKWDZETUoyMVFrSzdwczRmUVpYU1pZ?=
 =?utf-8?B?RklxNURTbnplMmFVaXNZTlg4WEErTjJMeUtlMm9jOWZ4QlY4K2xOWERlc3Jv?=
 =?utf-8?B?N2JjZ29aUGFTUk9BMU4xMkZoSy9vYW55eHEvd2JGNjVLWmxKVG5mMkR0RWlJ?=
 =?utf-8?B?UHkvSmdkVGJUWUNjbjhhaHJaVEpTSHBKN0xVYWhPSWI2VmdYS0pGVUh4cnM5?=
 =?utf-8?B?c2JsdFVaOWRJa3dORmR3NlJSd3UxZHd1ZjR6QytOV2x2UVlqWGJ0UDRjcW5l?=
 =?utf-8?B?ZEpYd3p6Q3hsUXAxNnpVMlordlQ3T3Bhb1JQeWUrNE5OT21EZ3RGWHlCWnpx?=
 =?utf-8?B?N2R1ZWZqcU5DeHRjN242OG5OYWcyb2RNT09JY043SkRMeHhDUG9NdUxQT0lq?=
 =?utf-8?B?b29GS3NXaWYwdktaWGFsZzZ1OVRtVzkyaS9hVkFJYStOTW9sZVlrb1VHSldk?=
 =?utf-8?B?YkZGUU1sY3pQcldscGwwZ3FkSU1XNFZ1Y0hJY3RhRjNKbHhNMXAzOVdJRUts?=
 =?utf-8?B?b29xa01OeFliMXVBZUZybmlTenlHMWJWOUtNaHcxU2pzN1BIb3lyTVhzQXBV?=
 =?utf-8?B?KysrcHcyMDRjWjNlUW9INjZ5TkFrUlRDRVJWUzFQUTFOZnFFUC95MjZOcTZh?=
 =?utf-8?B?ckZRY3NpZTJSdFlNeTRxaWhqY3A3dTNuT2hRcjMwbUpvZGlMUnNiTGJCRkg4?=
 =?utf-8?B?NFlvclJqUzFCNGlkSVBtY0RpMkxja3BqRGJrR1BVd2JoeDcxQ0xDVEx5Qlkz?=
 =?utf-8?B?WWZEam13cUN4YTZsTERlR3JBM2N0YlFQbFU4ZXdxRnhVME9NNlQweVFUT1d5?=
 =?utf-8?B?eW04N1Rycno3MC9QcCtJVTFKS1dIN1YyS255Wm5YK2hVTWs4ZkMrY2kxM3g0?=
 =?utf-8?B?MmxXQkpVV2VRSTRBaklOOFd6YUtnNlU5cjE1eVV6clh0c1IzaXhIUERxTHY2?=
 =?utf-8?B?MEY0UFlkNXBmVUljRTcxcmxXdUFOK2E4T2RDVkZjY1BxT3p5UEgwbjBBWEp3?=
 =?utf-8?B?WlRWZmZsclVXWUFQNlJCcjhxa1NEZFFFS05RenhDa2l0a3lMeHlpZ1Y2ME5j?=
 =?utf-8?B?dU5iWVA2RXgwdHNzNEFoY0tmVEQyb3lTUitGSnlJVitjQys3c2ZER0I5ZHBW?=
 =?utf-8?B?ZDhIVklidnU5S3dUNEZ5aFQwdlNhYWdiUVRsN1FwWVJ2WlY3K0VxWWRZbjd3?=
 =?utf-8?B?a0RxTFplZ0V3TTBLZDhnaktPbElnZC9qRUJpcWJ2c0p2UEMwUUx6SVNDZ1Zl?=
 =?utf-8?B?dkx0WjNncFZWb09jRjlOekZrZ3dacWJ5SUlzNWRuU0dLaTF6eFd4d0tsNC9W?=
 =?utf-8?B?ZDNjWkFETkxwYldpRXlOcktqQzBneGtCUWw4YStlOTN6ZVQvNkFhdWJoZHJ6?=
 =?utf-8?B?SS9sRkJPY3hjRTZqYXU2dCtRVWtsMldCSWFidGlCZjNKUGs1bjhxMkd1d1ZH?=
 =?utf-8?B?VGVuMDdlZ0lRanpVZFBkbW1rUnhES05ucXlwZUVLRFlISERFSTBzZGk2WkhP?=
 =?utf-8?B?M0xsZ1U0UG9lREkvVSttUEZiNUo3NWFIZ285Yk01QWVCa3ZqTUdDQnlDclNt?=
 =?utf-8?Q?8DwRotNX5ZBkbK8nMLBvFCkNq?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 054c9021-5744-436d-5ccd-08db92cfaa91
X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5984.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2023 20:41:22.2164
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WNV4gqGet+e40Y1Zdthpank7PVtMheGDMdv8blPzskwVMmxRKWQl/xtvOYzNFnLJOjnEVJLPsq8I+8Oj5aT99Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB8596
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 8/1/23 13:13, Ira Weiny wrote:
> Knowing which handle is being processed helped in debugging new event
> code.  Add a dev_dbg() message with this information.
> 
> Signed-off-by: Ira Weiny <ira.weiny@intel.com>

Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
>   drivers/cxl/core/mbox.c | 6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c
> index a1c490f66bbf..f052d5f174ee 100644
> --- a/drivers/cxl/core/mbox.c
> +++ b/drivers/cxl/core/mbox.c
> @@ -947,9 +947,13 @@ static void cxl_mem_get_records_log(struct cxl_memdev_state *mds,
>   		if (!nr_rec)
>   			break;
>   
> -		for (i = 0; i < nr_rec; i++)
> +		for (i = 0; i < nr_rec; i++) {
> +			dev_dbg(dev, "Event log %d: processing handle %u\n",
> +				type,
> +				le16_to_cpu(payload->records[i].hdr.handle));
>   			cxl_event_trace_record(cxlmd, type,
>   					       &payload->records[i]);
> +		}
>   
>   		if (payload->flags & CXL_GET_EVENT_FLAG_OVERFLOW)
>   			trace_cxl_overflow(cxlmd, type, payload);
>