Received: by 2002:a05:6358:700f:b0:131:369:b2a3 with SMTP id 15csp195031rwo; Tue, 1 Aug 2023 15:26:51 -0700 (PDT) X-Google-Smtp-Source: APBJJlEgDgM3cxupH2xuCkkyYyRIqICojU/pd2I7CoGcqQVUAidsx1oAaeMDIdzAmhzUensV/fgG X-Received: by 2002:a2e:8ec3:0:b0:2b9:6d6e:df5c with SMTP id e3-20020a2e8ec3000000b002b96d6edf5cmr3373367ljl.5.1690928811691; Tue, 01 Aug 2023 15:26:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690928811; cv=none; d=google.com; s=arc-20160816; b=g6emTvW/b7QBHO1aU27iKweDLs2UtQZGuk8j9xYktRD+KEreaQBdNFnrql+2WCh2b1 E0KccpfdQfoeaBFZGNZqk81ZtPrl6Q4+RR522Ul59Wzu4IIqmo6EesJIrjioErhlSnPg eABfJn3hHxWlnAqpfCoWSA41eqhviZpBZk1WCLfIF2bbsq17VHCwSW5ezTvbcbC69dIK nb+X7t0htPgMswJpAvLYKxUKfUzl0TyRDROPiNxjRGedGQFdgEA9fQrome0UeegqDPz+ YF3KlNgDsiE31neX0IocP4mXAtwxqsh4pZzxwOrHj1bEsVGbigNVkP78c17oqLmF8vwq iRhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=UrFYhc4YGdvu3l+xB/Va3bEJy9YiRD0WXfQNUw0J5Zs=; fh=qAAtp87cDrlHjYXEkdQF4UdWmLwfoPE9p5UrnzEtgMc=; b=f9O24yoUkdNX6C05bTPNSNs+3idicHIytc67ghS7eAIe/jdD+0JIdQHddecXjIu723 RQqEmV9wLEF+IVxwm0p4V7EODgoKcx23mxnIRqeoFUcCj/KCQLXExp/p/Pq+HLk9yAKp 5xkMJJoMClQCL+d0sK+MNI5wvMVJ7+d6+Ukb7k9mPyd4t5bnbfMY2t0CPM9B97bQAmzt cKZbh2lFhddAXoGiX0acQx4+Q0+3o2rCc0S5NQW7YmsvyYb+by3C1EhDr7cSIjjVPMky CuEZT/hclNGA3GfQTc6fkAHqcl2eYLOaxemsUdVZ0acYdZhQ3ugBR/4xmFAdfwG1F5Ms iO+w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=mSJmmFwT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id lw15-20020a170906bccf00b0099bc8469e26si9111947ejb.923.2023.08.01.15.26.27; Tue, 01 Aug 2023 15:26:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=mSJmmFwT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229652AbjHAV5f (ORCPT + 99 others); Tue, 1 Aug 2023 17:57:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60050 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232344AbjHAV52 (ORCPT ); Tue, 1 Aug 2023 17:57:28 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A2CA1212C for ; Tue, 1 Aug 2023 14:57:25 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3F2206173E for ; Tue, 1 Aug 2023 21:57:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 21991C433C8; Tue, 1 Aug 2023 21:57:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690927044; bh=1zkqubEp693ty9VDXEnLFMNBXktoPzOqeY6em4mcsBM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=mSJmmFwTIK1f3qjDv2+Be05QntUSJk3XdeJZV0zBsLuNLIECiDpRKr7K5o1y7Xa1M dBWUQAa7dpGZ461KXdxHBBMyfRq20Hzwl8koKlYxZnazkorzpDP5RGhXOlHNkaMki7 yujhhJupHhv38SRstlQ0L7adI0sp6DPnvWPk2hqlScYcW276A/wOv2F6DfW8EAYUBH fIkp6xDwBFCZ9u1deCxGl5txyHchxyuTQUaCgnPRVoxG3jaWGqwij/51NMIYjVK2GG o7CfvTKVSbR3nHzEGADMzx9H2QIN9CLFgmcVNEI/OvLfJo8IUr04MSFWrBr8Ijh8a/ 8m/NSlh8Lw3ww== Date: Tue, 1 Aug 2023 14:57:23 -0700 From: Jakub Kicinski To: Wei Fang Cc: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, shenwei.wang@nxp.com, xiaoning.wang@nxp.com, ast@kernel.org, daniel@iogearbox.net, hawk@kernel.org, john.fastabend@gmail.com, netdev@vger.kernel.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH V3 net-next] net: fec: add XDP_TX feature support Message-ID: <20230801145723.7ddc2dba@kernel.org> In-Reply-To: <20230731060025.3117343-1-wei.fang@nxp.com> References: <20230731060025.3117343-1-wei.fang@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 31 Jul 2023 14:00:25 +0800 Wei Fang wrote: > case XDP_TX: > + err = fec_enet_xdp_tx_xmit(fep->netdev, xdp); > + if (err) { > + ret = FEC_ENET_XDP_CONSUMED; > + page = virt_to_head_page(xdp->data); > + page_pool_put_page(rxq->page_pool, page, sync, true); The error path should call trace_xdp_exception(). -- pw-bot: cr