Received: by 2002:a05:6358:700f:b0:131:369:b2a3 with SMTP id 15csp195580rwo; Tue, 1 Aug 2023 15:27:25 -0700 (PDT) X-Google-Smtp-Source: APBJJlHLSPI0JbkN7XeQAUlC/IGsbCMSPgJUA2vGzroLNHnLhOlbN8koAxHiE7FT3nh/Rjv4h4KI X-Received: by 2002:aa7:df06:0:b0:522:2711:871 with SMTP id c6-20020aa7df06000000b0052227110871mr3606348edy.1.1690928845627; Tue, 01 Aug 2023 15:27:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690928845; cv=none; d=google.com; s=arc-20160816; b=kMOYd1V0WOS30S5o05qfWCM/5zIUzXixXxrsksbgikTHzYLB3AveVN1tHmmq8/oV+k 3o7UXE+Gd7Ddu1NGueYg+rE6na4SLGY9UdvwTwS9JhcNkaDuzGEQE1FfMVii4aBytIkI +fbH5Gw/1evzhUPEs5EPCzJrsTeMOQlWVCJMPsbYuxva1FslPlcXnfvfGvpwXzb+ZtB5 Bxg+hRpo/es7Qv8HbdG/3/BEcF6LzZaFhjqa9i4kekfAATHZjo4OTuiEVrzBT9dWOOZc UEJSwgKMdlSud5s4KXtSAS9Bsdhp/lqQFP3HU+ZTcGR81XrYtwKW8fD6aqYCbCpBhThR N23Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature :dkim-signature; bh=LXoRq/syaXRfKHZ4IrLuTP3yaz9naXR2FbQv5om0wQE=; fh=IVi3PsjOyL5EHOR9F5qbVknK6zt2dOeva3UDi8d9sQU=; b=xpcWzqmlMkYqsS+ARtUXs5kLV+PX5ojIqKYOkRnHpSgZ7ORUMLhXfU6KIdiRUu/078 FMvftcyRyUcZtti+sGjKZikhi+o1dP1Wzn4fZcaBxQrgYskM0QzVk2TCcIt3pmoKR4bP DkGeAnCsuzpgQY6HWH6qf8dXLxVCjlNawGUQzOmxCibKU+gtQSQ7zGoNrCONPfvDUaSO sCkAmIsLFrM97PBkkBa4v7kUV3z1CEgsOa+pDz8462V7Gfk5hMja7otpe8Py3Oaa9t48 aAjY0iLYgbqGegb8t63ron/Rj/bw+5DHeRon2pSQeiLH0cNaZisJcMZtK1j63xNXbErs ySrQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=Um2QKcQS; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519 header.b=4JcYkDcB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i5-20020a50fc05000000b005220ec7fdecsi1288493edr.567.2023.08.01.15.27.01; Tue, 01 Aug 2023 15:27:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=Um2QKcQS; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519 header.b=4JcYkDcB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232740AbjHAVqt (ORCPT + 99 others); Tue, 1 Aug 2023 17:46:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54690 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232231AbjHAVqr (ORCPT ); Tue, 1 Aug 2023 17:46:47 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 739BD1FE8; Tue, 1 Aug 2023 14:46:43 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 7BE4621BB3; Tue, 1 Aug 2023 21:46:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1690926401; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LXoRq/syaXRfKHZ4IrLuTP3yaz9naXR2FbQv5om0wQE=; b=Um2QKcQS+PnZaE4xorS6yIh7Yqan88xX+C4jCf0BrNCpa1Da3BPDhmzAVSKYuHO2sPIb6G TGEG43AfKVacmAiEvo8iNzk/j42LkULd6QtZ6Xsp1HhUQFcP2PIyqzm6jMCCC5EXjwk0oc 92tvzp8bpzlivUYW3HFiAycl9uad+ss= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1690926401; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LXoRq/syaXRfKHZ4IrLuTP3yaz9naXR2FbQv5om0wQE=; b=4JcYkDcBfLRyUEZLH7EemgohDZOI7ush+pXQJGbbMF5cZDJ27hTik0q2G6SCDHCKTaL55H /OG6ktAWbGNZObCw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 692F5139BD; Tue, 1 Aug 2023 21:46:41 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id KtPEGUF9yWSOLQAAMHmgww (envelope-from ); Tue, 01 Aug 2023 21:46:41 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id A71E0A076B; Tue, 1 Aug 2023 23:46:40 +0200 (CEST) Date: Tue, 1 Aug 2023 23:46:40 +0200 From: Jan Kara To: YueHaibing Cc: jack@suse.cz, amir73il@gmail.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] fanotify: Remove unused extern declaration fsnotify_get_conn_fsid() Message-ID: <20230801214640.3hgms34jme6357cg@quack3> References: <20230725135528.25996-1-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230725135528.25996-1-yuehaibing@huawei.com> X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_SOFTFAIL,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 25-07-23 21:55:28, YueHaibing wrote: > This is never used, so can remove it. > > Signed-off-by: YueHaibing Thanks! I've added the patch to my tree. Honza > --- > include/linux/fsnotify_backend.h | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/include/linux/fsnotify_backend.h b/include/linux/fsnotify_backend.h > index d7d96c806bff..c0892d75ce33 100644 > --- a/include/linux/fsnotify_backend.h > +++ b/include/linux/fsnotify_backend.h > @@ -760,9 +760,6 @@ extern void fsnotify_init_mark(struct fsnotify_mark *mark, > /* Find mark belonging to given group in the list of marks */ > extern struct fsnotify_mark *fsnotify_find_mark(fsnotify_connp_t *connp, > struct fsnotify_group *group); > -/* Get cached fsid of filesystem containing object */ > -extern int fsnotify_get_conn_fsid(const struct fsnotify_mark_connector *conn, > - __kernel_fsid_t *fsid); > /* attach the mark to the object */ > extern int fsnotify_add_mark(struct fsnotify_mark *mark, > fsnotify_connp_t *connp, unsigned int obj_type, > -- > 2.34.1 > -- Jan Kara SUSE Labs, CR