Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Min-Hua Chen <minhuadotchen@gmail.com>
To:     minhuadotchen@gmail.com
Cc:     daniel@ffwll.ch, deller@gmx.de, dri-devel@lists.freedesktop.org,
        linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fbdev: fbmem: mark registered_fb static
Date:   Wed,  2 Aug 2023 07:30:31 +0800
Message-Id: <20230801233031.72174-1-minhuadotchen@gmail.com>
In-Reply-To: <20230731162812.25518-1-minhuadotchen@gmail.com>
References: <20230731162812.25518-1-minhuadotchen@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk


>Hi Helge,
>
>>num_registered_fb is still used in:
>>drivers/staging/olpc_dcon/olpc_dcon.c:  if (num_registered_fb < 1) {
>>
>>Helge
>
>Thanks, you're right, num_registered_fb is still being used.
>I'll check this patch and submit v2.

Update:

num_registered_fb and registered_fb are used by olpc_dcon.c, However,
olpc_dcon.c has been marked as broken [1].

I do not have the knowledge to remove the dependency of fbdev from olpc_dcon.c,
I'll leave num_registered_fb and registered_fb as-is.

[1] https://lore.kernel.org/all/20220609223424.907174-1-javierm@redhat.com/

>thanks,
>Min-Hua
>