Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Wei Fang <wei.fang@nxp.com>
To:     Jakub Kicinski <kuba@kernel.org>
CC:     "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        Shenwei Wang <shenwei.wang@nxp.com>,
        Clark Wang <xiaoning.wang@nxp.com>,
        "ast@kernel.org" <ast@kernel.org>,
        "daniel@iogearbox.net" <daniel@iogearbox.net>,
        "hawk@kernel.org" <hawk@kernel.org>,
        "john.fastabend@gmail.com" <john.fastabend@gmail.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        dl-linux-imx <linux-imx@nxp.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "bpf@vger.kernel.org" <bpf@vger.kernel.org>
Subject: RE: [PATCH V3 net-next] net: fec: add XDP_TX feature support
Thread-Topic: [PATCH V3 net-next] net: fec: add XDP_TX feature support
Thread-Index: AQHZw3VFF5NSBizeREOxLxVc18wksa/V/2KAgABLGEA=
Date:   Wed, 2 Aug 2023 02:43:16 +0000
Message-ID: <AM5PR04MB313902042437FD2D89A7677A880BA@AM5PR04MB3139.eurprd04.prod.outlook.com>
References: <20230731060025.3117343-1-wei.fang@nxp.com>
 <20230801145723.7ddc2dba@kernel.org>
In-Reply-To: <20230801145723.7ddc2dba@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?OhV6Emw3PiPbLe4hFrUhkmiqXxlix3GLJ3xl52uhbAC+IafXAtmeKceyByBk?=
 =?us-ascii?Q?GKnqXyEb6DB4VwJ/1/qXQlkcXQsFLxws4wSWhp8dPAfUQxR2vQhduVtxZ+Nz?=
 =?us-ascii?Q?KuGmN+va6K3PCmSAdgVNTYRUouTwj0VPieFNKnK9c/8OmXeXon5Kedf8lyQ5?=
 =?us-ascii?Q?YeSZSH4iOMU9leGqyIWykWYQrgDqD5z8bmtKbzsSNFJLEPZ/U7xmCfayKWf0?=
 =?us-ascii?Q?bcPNyjUN0TL6z+F9JOYZB5jwQ9GWB9o18fSNClrm6wy4bO29WcJZdKTlgE/H?=
 =?us-ascii?Q?ne7HOLZEFbspkBU68jW5V3cJOFmBtnvMX8HhWUvCKIi82Q5yt7WpuwXPPyvk?=
 =?us-ascii?Q?Jsu7mVyMjx+JIxHcOg1gEi6csLRLzh30nnKZBclcvjCP42gorsUGMzDuDHtK?=
 =?us-ascii?Q?q7InCMLcNOKENi8iHQdjfO2j233BkvW2ZTgIfUP5Ls5XqM7RgjHI15sOXOIv?=
 =?us-ascii?Q?G1wGzlZXGbnlWegkgbKuej5C2sHMME/yVl+j+q/swpYp1kdYJuhCvA2wpEaq?=
 =?us-ascii?Q?9UwBjdCTsGimQPStYVKXyVs3+O9mtFpKNaI4k4snXGwR5fgTrMIDrpCiCrNL?=
 =?us-ascii?Q?JLEGu+x/QqBHpcMVN7s1bGrmCVX1vfZH4laP77hKYCPZO0xBBmGqoIGfsuOW?=
 =?us-ascii?Q?LgsYgJaObqg9SsPvCFfAZu+ReGf4tdamza9qxXtpy+N6r02FZq12ggdw6/7Y?=
 =?us-ascii?Q?oiTZ3fuJQnrQwsxeifrmHVvXktxRn5aNtbDbeTdbDWrOyJCjPEbgv4VivTf/?=
 =?us-ascii?Q?KSAKHHqjJaNDi8jYmnvq5o8rSlQ0O+rLdxPJUGqX8jPoox6Ai71q8QMcviA6?=
 =?us-ascii?Q?ZY9w5XB4e+2l0Ya5hFwj5jCrwQQEdGksBuGtQUvUd+mkykW2oFmVIAXE5tnF?=
 =?us-ascii?Q?OzE0PIjkPZe7lNscZT9F0n4nK4nvmCzv5zW/ERPMEVYL2wtOJpXrC7TKEtIU?=
 =?us-ascii?Q?iMpiVEKWqIpdGIDtjhE9T2J/VE88F6s9yd804EBhZtP2sbwm2yuoNIWQzKmV?=
 =?us-ascii?Q?hvJJ0ZYOgpvxkBhdjJ5afYa0bcWhLOwgtzWBjEqQ9tJrDBRwSDKYGA4h/Kl2?=
 =?us-ascii?Q?XTbTDQh9BC0R4eAzjX2Z0MvrVQRn4fwMhCZHGkZ338QED+EuCX3VH31dYTq0?=
 =?us-ascii?Q?SDc1fVe9f/L4SW9nZNP53MMmU6QpMard1feYOHyN/cmKh6kwml3fzBj3riBB?=
 =?us-ascii?Q?MmMonRV/M7TQUPTm5Y2F5fD6WjtW57jjOxSLecxzxme/ZbIWR4VARREs32zI?=
 =?us-ascii?Q?x1nGdvIdcQ1mUc635+bEikqg6Tv0MrYKZeC6Pb7SsO69R+pf+y5tStCOxnZC?=
 =?us-ascii?Q?K3Y3lGLXH5gYX7jdefkQZnsxpBh+KTmJbCe1X/TgQK1Rm+WI3LreONsLYW4s?=
 =?us-ascii?Q?UF+3vvmHz8SWhdrpD7M3eWx6ZFKK1mkDgq4WFltg27GJzveZSoT6KPsiF1bQ?=
 =?us-ascii?Q?Rv6H1PDMbFLqlef8w6FkBrZp5PbFzb6pvp9nf9M9zLiTmn6Yytlkm+8f4Pef?=
 =?us-ascii?Q?b+WbEPNKleaxkiJ/Kf+KgNJvCfyV4Qk10vQud12yaqC0UHE9tvU3KBgUi5ro?=
 =?us-ascii?Q?SJaTvI4PdHy7m5y0ZaI=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM5PR04MB3139.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 742df579-b87d-4436-cd29-08db93023937
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Aug 2023 02:43:16.2204
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 5aTxNIMmm9ZFN8zvjujoh9PhKXvbtelQiTx1y2LbpD5Jninbs98Ns1zCFh6c8BQHTRa2nnkpqlf4HAbW8AJq1w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB9094
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> Subject: Re: [PATCH V3 net-next] net: fec: add XDP_TX feature support
>=20
> On Mon, 31 Jul 2023 14:00:25 +0800 Wei Fang wrote:
> >  	case XDP_TX:
> > +		err =3D fec_enet_xdp_tx_xmit(fep->netdev, xdp);
> > +		if (err) {
> > +			ret =3D FEC_ENET_XDP_CONSUMED;
> > +			page =3D virt_to_head_page(xdp->data);
> > +			page_pool_put_page(rxq->page_pool, page, sync, true);
>=20
> The error path should call trace_xdp_exception().

Thanks for your reminder, it made me realize that the error processing of
other XDP actions also needs to add exception tracing. I'll add the excepti=
on
tracing for XDP_TX in V4 patch, and add the tracing for other XDP actions i=
n
a separate patch.