Received: by 2002:a05:6358:700f:b0:131:369:b2a3 with SMTP id 15csp435170rwo; Tue, 1 Aug 2023 20:51:18 -0700 (PDT) X-Google-Smtp-Source: APBJJlGYnFF56YwT3ZZvssl6CoYBypXTae2+qAIsJS8vk0iId6eLhrHQeQkr7+Yeuo+GxBscCgMl X-Received: by 2002:a17:90b:4a91:b0:263:f521:da3e with SMTP id lp17-20020a17090b4a9100b00263f521da3emr17742021pjb.2.1690948278256; Tue, 01 Aug 2023 20:51:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690948278; cv=none; d=google.com; s=arc-20160816; b=yuDQx5tB8GQVVml+D66C0BUlXuQ0xEPmVcBkcmnKjwtJenR4KTRGm3dZW5fyU/CwYU ahM07+FA7aaTpmC+S9JP5leikDA4M9OJCvxdx5XtTTpDIrnVxFB73QWZpxxq2BdiIsph oeqG60tmZ45YPblwIG5xZuQ2NH7fLoBo6I5KnXRNgSKSrYREwjvLFEolcY6lhWwlyXL0 vY2G0KG3EndXi81k4S8hbMN9/kLWG5LV6pWp2faf3WgUuh6RD5dAQTB7SCrKxfcUO930 p4ow0yhwwOScUJ+lChlJVKqB4M8jEeOVuh5w5LLnAsz3In7Xg6ACYDp06GpprzJsDwr3 Buig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=4KdaJDAyopQ+DSysMiecIkjHtCh3kPQvvb6Smpe1xo4=; fh=4ZLxk9WgAV0qAml8rnjq/bF/33nczUcN7lbsDuTErnk=; b=qNLyaPYRUof4v3vcaFPYM6Y7/ACgppXJlK9lSGNkjzqtsyzicSVChQDLUG47pSqbHe XBCnPFdm079E9ig/yULY3VFWfwxACkOlXH0x653ClKWdZXm/KzrC6iKrGm8EoXoGN7UF UiWdGyfJC9LEgus/dSwubCYpUYcIULm1SLbs0OO7g7zdKIiSO5HpBIx0cWO3P3mu9aM5 zPI7wQ8yp8Njf5g+Y03TCShTpazXEOSYgHj1laDPzN4b+1JdAmIUcCYfjnnI3wxq2q8C 0+DAbyL0Txo0hqAQsqbB8o3DBpwtOZw+Ko6Q5f79AyA/287kNqi+EFh6XwH33erf0utw SJVw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m8-20020a17090a414800b002681b60504asi487444pjg.115.2023.08.01.20.51.05; Tue, 01 Aug 2023 20:51:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231997AbjHBDZS (ORCPT + 99 others); Tue, 1 Aug 2023 23:25:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57864 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229800AbjHBDZQ (ORCPT ); Tue, 1 Aug 2023 23:25:16 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD1F51705; Tue, 1 Aug 2023 20:25:15 -0700 (PDT) X-IronPort-AV: E=McAfee;i="6600,9927,10789"; a="349773971" X-IronPort-AV: E=Sophos;i="6.01,248,1684825200"; d="scan'208";a="349773971" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Aug 2023 20:25:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10789"; a="794425911" X-IronPort-AV: E=Sophos;i="6.01,248,1684825200"; d="scan'208";a="794425911" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga008.fm.intel.com with ESMTP; 01 Aug 2023 20:25:13 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qR2U4-00FBak-03; Wed, 02 Aug 2023 06:25:12 +0300 Date: Wed, 2 Aug 2023 06:25:11 +0300 From: Andy Shevchenko To: Andrei Coardos Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, brgl@bgdev.pl, linus.walleij@linaro.org, Alexandru Ardelean Subject: Re: [PATCH] gpio: vx855: remove unneeded call to platform_set_drvdata() Message-ID: References: <20230801204445.9677-1-aboutphysycs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230801204445.9677-1-aboutphysycs@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_SOFTFAIL,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 01, 2023 at 11:44:45PM +0300, Andrei Coardos wrote: > This function call was found to be unnecessary as there is no equivalent > platform_get_drvdata() call to access the private data of the driver. Also, > the private data is defined in this driver, so there is no risk of it being > accessed outside of this driver file. Reviewed-by: Andy Shevchenko -- With Best Regards, Andy Shevchenko