Received: by 2002:a05:6358:700f:b0:131:369:b2a3 with SMTP id 15csp436049rwo; Tue, 1 Aug 2023 20:53:01 -0700 (PDT) X-Google-Smtp-Source: APBJJlEr148/4EzNNs4ZV4RGR5sc5nOrDf7WuhzjMKeNJyQhFFU/LDLjIQ2vH0XduMSs3Lb9t6P8 X-Received: by 2002:a05:6a00:2351:b0:687:5c3f:d834 with SMTP id j17-20020a056a00235100b006875c3fd834mr3027156pfj.11.1690948381000; Tue, 01 Aug 2023 20:53:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690948380; cv=none; d=google.com; s=arc-20160816; b=n8Lzmp+WmRh0RNtmWEUNWMJSI5d8TKs9G0EFnVzBZMf0oqgrZJapbGK+ZHwXoVMdn3 vgYyWMSfxC1IkpXXVK8gc30EnrHeN1jgxGrKg4utX2Dl2L8M3NNL1r5vqGIZFIDFchTv wv4ZLRiCNcEwSdv3J0Grx85z3QwImtQmZYqdnNOXeTTdZxMTzBK57wsj/OcSn85qrMBN SvQ1kHeq3bxeHtklaKNgVYYtNyUl9a75W/gWYIJ1Nj6sENjsAOsBKzSk7cvEXYBpqV3b p1xqejUIVzT+jZa4M3WSA94zeuSUaLnXpAixAcRqZFkNLALONPHjUxM1StYRlap0TvWS r+CQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=US6d5DVyd6NcPpDsF+dd654I9JPadWiUR9nrOgooIhA=; fh=4ZLxk9WgAV0qAml8rnjq/bF/33nczUcN7lbsDuTErnk=; b=be1VKjjjcPUzX+fNiyCky8gEAYu4EIoDCiisc+YUx3OLuQxdhAwWB1dodPtPoXE+6k fOCXedN7AP4ky/4It5C1nVzJFx8SGtBF17YzWTh5mL4qdx+KTxJ+GrHUvE+m+K7vjQ9h xgPy8WnrBku3LUsp53OHuzYmjO7Pn0PLXXGMVJB+/0/tAH+JXLxqSXVFZjgkBRPVOnQ1 qUL6WMcHhKKApIb/nI4ql27uKj38haGjo23tYgK1PJ36/327yvyHHuSrTLjSIZ2kzuNa buc/6f4gMPtomKe0rUcKAMr9n2N1//0dEZHmCi1dwPLGyT9QNntMFBN4h6CaV5JTKweg 3hIw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u14-20020a056a00158e00b00682759c6440si3708263pfk.40.2023.08.01.20.52.49; Tue, 01 Aug 2023 20:53:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231962AbjHBD0E (ORCPT + 99 others); Tue, 1 Aug 2023 23:26:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58188 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229800AbjHBD0C (ORCPT ); Tue, 1 Aug 2023 23:26:02 -0400 Received: from mgamail.intel.com (unknown [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D96501705; Tue, 1 Aug 2023 20:26:01 -0700 (PDT) X-IronPort-AV: E=McAfee;i="6600,9927,10789"; a="400415645" X-IronPort-AV: E=Sophos;i="6.01,248,1684825200"; d="scan'208";a="400415645" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Aug 2023 20:26:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10789"; a="1059656562" X-IronPort-AV: E=Sophos;i="6.01,248,1684825200"; d="scan'208";a="1059656562" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga005.fm.intel.com with ESMTP; 01 Aug 2023 20:25:59 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qR2Un-00FDF1-1m; Wed, 02 Aug 2023 06:25:57 +0300 Date: Wed, 2 Aug 2023 06:25:57 +0300 From: Andy Shevchenko To: Andrei Coardos Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, brgl@bgdev.pl, linus.walleij@linaro.org, Alexandru Ardelean Subject: Re: [PATCH] gpio: zevio: remove unneeded call to platform_set_drvdata() Message-ID: References: <20230801204606.9738-1-aboutphysycs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230801204606.9738-1-aboutphysycs@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_SOFTFAIL, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 01, 2023 at 11:46:06PM +0300, Andrei Coardos wrote: > This function call was found to be unnecessary as there is no equivalent > platform_get_drvdata() call to access the private data of the driver. Also, > the private data is defined in this driver, so there is no risk of it being > accessed outside of this driver file. Reviewed-by: Andy Shevchenko -- With Best Regards, Andy Shevchenko