Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 2 Aug 2023 09:35:38 +0530
From:   Manivannan Sadhasivam <mani@kernel.org>
To:     Nitin Rawat <quic_nitirawa@quicinc.com>
Cc:     powen.kao@mediatek.com, bvanassche@acm.org,
        alim.akhtar@samsung.com, adrian.hunter@intel.com,
        jejb@linux.ibm.com, stanley.chu@mediatek.com,
        asutoshd@codeaurora.org, quic_cang@quicinc.com,
        martin.petersen@oracle.com, beanhuo@micron.com,
        ebiggers@google.com, agross@kernel.org, Arthur.Simchaev@wdc.com,
        konrad.dybcio@linaro.org, quic_ziqichen@quicinc.com,
        quic_nguyenb@quicinc.com, quic_narepall@quicinc.com,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH V2 1/2] scsi: ufs: core: Export ufshcd_is_hba_active
Message-ID: <20230802040538.GB2370@thinkpad>
References: <20230726134140.7180-1-quic_nitirawa@quicinc.com>
 <20230726134140.7180-2-quic_nitirawa@quicinc.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20230726134140.7180-2-quic_nitirawa@quicinc.com>
Precedence: bulk

On Wed, Jul 26, 2023 at 07:11:39PM +0530, Nitin Rawat wrote:
> Export ufshcd_is_hba_active() to allow vendor driver modules
> to check the state of host controller.
> 
> Signed-off-by: Nitin Rawat <quic_nitirawa@quicinc.com>

Acked-by: Manivannan Sadhasivam <mani@kernel.org>

- Mani

> ---
>  drivers/ufs/core/ufshcd.c | 3 ++-
>  include/ufs/ufshcd.h      | 1 +
>  2 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
> index 983fae84d9e8..962aa5c1fe69 100644
> --- a/drivers/ufs/core/ufshcd.c
> +++ b/drivers/ufs/core/ufshcd.c
> @@ -995,10 +995,11 @@ static inline void ufshcd_hba_start(struct ufs_hba *hba)
>   *
>   * Returns true if and only if the controller is active.
>   */
> -static inline bool ufshcd_is_hba_active(struct ufs_hba *hba)
> +bool ufshcd_is_hba_active(struct ufs_hba *hba)
>  {
>  	return ufshcd_readl(hba, REG_CONTROLLER_ENABLE) & CONTROLLER_ENABLE;
>  }
> +EXPORT_SYMBOL_GPL(ufshcd_is_hba_active);
> 
>  u32 ufshcd_get_local_unipro_ver(struct ufs_hba *hba)
>  {
> diff --git a/include/ufs/ufshcd.h b/include/ufs/ufshcd.h
> index 6dc11fa0ebb1..ef04c3363be8 100644
> --- a/include/ufs/ufshcd.h
> +++ b/include/ufs/ufshcd.h
> @@ -1398,6 +1398,7 @@ int ufshcd_wb_toggle_buf_flush(struct ufs_hba *hba, bool enable);
>  int ufshcd_suspend_prepare(struct device *dev);
>  int __ufshcd_suspend_prepare(struct device *dev, bool rpm_ok_for_spm);
>  void ufshcd_resume_complete(struct device *dev);
> +bool ufshcd_is_hba_active(struct ufs_hba *hba);
> 
>  /* Wrapper functions for safely calling variant operations */
>  static inline int ufshcd_vops_init(struct ufs_hba *hba)
> --
> 2.17.1
> 

-- 
மணிவண்ணன் சதாசிவம்