Received: by 2002:a05:6358:700f:b0:131:369:b2a3 with SMTP id 15csp476868rwo; Tue, 1 Aug 2023 21:57:20 -0700 (PDT) X-Google-Smtp-Source: APBJJlHvwxzZ0u+rxw1Z1xdmmomTuQRQRI4/H0B8EI/3Yp8YL3d2RjwoCDa51uaOavnKlK6z+RcB X-Received: by 2002:ac2:4f0b:0:b0:4fe:45ca:f8e7 with SMTP id k11-20020ac24f0b000000b004fe45caf8e7mr3205675lfr.57.1690952240116; Tue, 01 Aug 2023 21:57:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690952240; cv=none; d=google.com; s=arc-20160816; b=fjBNwj1zNEawsNm9uCwczcKZkWANWA+WvciUlPpFz34Vg0mAxNIuBKzfQmUORbt3YQ 2CCVVuKcat7otrES7949Erlu4+a/IOMVajc509astgx26Ty0G/qXpKZ2q8DOSy3NDy3C cHsCnN09lBwAjOIPIimIfyp1SRI1FgRgtA6m/L8HLMFXzOEQw0JRDMwdRfg44YF+pWjQ Sngo9QEjQfJr3sB12O9kd5k5kf0uQGN4ZqGcmjwGHYrPhuXjgULiv2w8GpkJSm4X2AP5 +tINiqN2PXPbgzv+psR3AgZ9VtTcQzkYvZ+fRHz1Doa13gTywX5i5eBk921yWWit6b+A RaYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=EKBXDiqwW5UynR2G4zBKgpm8NxdtROHFeYlaSSnwbxQ=; fh=rAIdoWIa39fDoFxF1xn8rK7LbGapnD6E9rrEqx/qem4=; b=qTaFitDi/HYk57aOicReNL7bOPz1OQVTQy4rW86KmqcqBtEjztECt6uyBJZ0NCewgM KjAorjfNliWJQ6zrdo8I9R0jY8TJf4DV93VN57XnY5Nf38ijEdZV/vtfGTezXCunHRcm PnZX2UbYNSdWiaGS1SQsxzgmUfPn6bce8isEpp8EweZ/TzDF6jnotx4AKPSk+SCiQvRw NmfYv1Vh4ZgQEm1Gm77f6Q2Elyuyy+2NET79Y9W43N1jZuO2GsLY8XLk9g5TeCAi/xpX HQQBAnWApWDktDHOxsj/1HQOLY6xyphQPrGDSksUbIA9ikFOGePv8Pi9wqYur4ozrGjZ Rg1A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WKCixldl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u4-20020aa7db84000000b005221d280d58si9047264edt.101.2023.08.01.21.56.56; Tue, 01 Aug 2023 21:57:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WKCixldl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231133AbjHBEKZ (ORCPT + 99 others); Wed, 2 Aug 2023 00:10:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44550 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229958AbjHBEKX (ORCPT ); Wed, 2 Aug 2023 00:10:23 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6425FED for ; Tue, 1 Aug 2023 21:10:22 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D3CF061796 for ; Wed, 2 Aug 2023 04:10:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 28FC5C433C7; Wed, 2 Aug 2023 04:10:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690949421; bh=gY+pFREnHGNaE3/T5rj7xb/LfgIc84catNrHdsvr+7Y=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=WKCixldlRqyOGg5lbuv0ot0pX0c5JM0TwyqK07pSy/7ia00TxxUbkXDq+i8vA2qFo 0bJDW/HaQSLSfZIzGfAhCWh104t0WcTUE1/zSMu28Zp5ggSQ430BgAmRDMggPPtgqd IDLxHopbANLx9KR4Lwv2pR8hfykEuDNd4VOoMyiIO9G/iEmrah+hx3WR984sNnd6Vm 7Ul6JTFQZjyxYVUMRnZZF7VW9fb1nEFWgpBn3J/SvKb+TVLPxaFNqefN47m0oI1dNz dISMlqoR5sUb00G2beQsSbl27Atq3qZ3uURwTUobyalBAPQAx5+nhuk5ihF/EIPueJ L6A2yXcQ16x+w== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 0D1BDC691F0; Wed, 2 Aug 2023 04:10:21 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH net v2] net: dcb: choose correct policy to parse DCB_ATTR_BCN From: patchwork-bot+netdevbpf@kernel.org Message-Id: <169094942104.31458.13970223585358485274.git-patchwork-notify@kernel.org> Date: Wed, 02 Aug 2023 04:10:21 +0000 References: <20230801013248.87240-1-linma@zju.edu.cn> In-Reply-To: <20230801013248.87240-1-linma@zju.edu.cn> To: Lin Ma Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, daniel.machon@microchip.com, petrm@nvidia.com, peter.p.waskiewicz.jr@intel.com, jeffrey.t.kirsher@intel.com, alexander.h.duyck@intel.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Markus.Elfring@web.de, horms@kernel.org X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski : On Tue, 1 Aug 2023 09:32:48 +0800 you wrote: > The dcbnl_bcn_setcfg uses erroneous policy to parse tb[DCB_ATTR_BCN], > which is introduced in commit 859ee3c43812 ("DCB: Add support for DCB > BCN"). Please see the comment in below code > > static int dcbnl_bcn_setcfg(...) > { > ... > ret = nla_parse_nested_deprecated(..., dcbnl_pfc_up_nest, .. ) > // !!! dcbnl_pfc_up_nest for attributes > // DCB_PFC_UP_ATTR_0 to DCB_PFC_UP_ATTR_ALL in enum dcbnl_pfc_up_attrs > ... > for (i = DCB_BCN_ATTR_RP_0; i <= DCB_BCN_ATTR_RP_7; i++) { > // !!! DCB_BCN_ATTR_RP_0 to DCB_BCN_ATTR_RP_7 in enum dcbnl_bcn_attrs > ... > value_byte = nla_get_u8(data[i]); > ... > } > ... > for (i = DCB_BCN_ATTR_BCNA_0; i <= DCB_BCN_ATTR_RI; i++) { > // !!! DCB_BCN_ATTR_BCNA_0 to DCB_BCN_ATTR_RI in enum dcbnl_bcn_attrs > ... > value_int = nla_get_u32(data[i]); > ... > } > ... > } > > [...] Here is the summary with links: - [net,v2] net: dcb: choose correct policy to parse DCB_ATTR_BCN https://git.kernel.org/netdev/net/c/31d49ba03309 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html