Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9c988372-41d2-7dce-0e9d-be9301791a8b@amd.com>
Date:   Wed, 2 Aug 2023 09:40:55 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Reply-To: nikunj@amd.com
Subject: Re: [PATCH v3 04/14] virt: sev-guest: Add SNP guest request structure
Content-Language: en-US
To:     Tom Lendacky <thomas.lendacky@amd.com>,
        linux-kernel@vger.kernel.org, x86@kernel.org
Cc:     bp@alien8.de, dionnaglaze@google.com, pgonda@google.com,
        seanjc@google.com, pbonzini@redhat.com
References: <20230722111909.15166-1-nikunj@amd.com>
 <20230722111909.15166-5-nikunj@amd.com>
 <b01a4948-0632-f899-2357-3bba6bc358ae@amd.com>
From:   "Nikunj A. Dadhania" <nikunj@amd.com>
In-Reply-To: <b01a4948-0632-f899-2357-3bba6bc358ae@amd.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RzA0M3MzZnpXdFVzM0dudk9jdjlWS0R5aXhwRWZUbXRXUkZyRGZrc2RLQnFZ?=
 =?utf-8?B?QXhxVGpqZWhCNDREZ2VtWWtERHRTdEpJRkdQTUFJazc2cHVObFluSHpWWVUz?=
 =?utf-8?B?Sjh2RHp6b3NPU3BJTk15c004NVpEcWU2K29VQUNQSlpjSDVxN3JVOWJTRGJo?=
 =?utf-8?B?a0oxbk13K0NzK1lBTjNBKzQ3R2syTGtRdDdUbXFOMXFaRlhqWXVCai9Ic0th?=
 =?utf-8?B?UENTL24wbThadHVsK2t4NHVuZ0dBVmdWbW9OazVCanhudGlYSEJDSVFaRlNE?=
 =?utf-8?B?bm1TT1dPNHROQldSZHh1NGFVcWlVQ1JGRHRSY1ZDRlNjb3BobUt2cGJzMU1y?=
 =?utf-8?B?ZDZjVy9KcXMrUC9Bam10aU0yWlNyaEpCKy9sbGcySkNnajZGM2s4VHV3RXhE?=
 =?utf-8?B?Y3k0NXBJTm1uN1FvMTFHREg1eDNiZ2pYS2F6TVpudUlzUCszZ1lDUUxVWFlX?=
 =?utf-8?B?ckthdnFweXRRVHNJZTBXTmMyRk1PbUE1elhiQWZGVGZqN1BhdThReHEvaTE3?=
 =?utf-8?B?S0F3T2NtbjBscVVFR1N5cTFYNXB1d0l3a1hyWWJoRFFkdHlmOWRpUCtQOEZu?=
 =?utf-8?B?RjdUNzlKQjlwTitNU2RJSlJSNXhVdGRnVzZuSlNzOTIwUTZ6YklQRHh0cFRN?=
 =?utf-8?B?RUdhaXAwaHNXQVNWRC9WdjZDc0svSmMyckxOdVVzY3V4WjNFTzFUNVhlSnBm?=
 =?utf-8?B?RlRSUDE5VVZ0YlhvY0tkNEhEa2oxZ2pRazVIeTZ2ZDdLYVhjMWE4bDdlUzhU?=
 =?utf-8?B?WDVINmpXVDA0UkdHNkI5M1FIQ2RFSmpneTFkREZDNCtQanlUc2RZb1NrQlBo?=
 =?utf-8?B?MU5ZSGNkcy84emkreXJ4UWtUQkd1NStGalBCY2lvT0kvbTBKdHI0T1hGVEJC?=
 =?utf-8?B?NmpJbEtzdXNOQ0duY3pWWC9VQ1NLYm1Ta1VTekVEOFl2djNySURVYUtaQlVq?=
 =?utf-8?B?NW83U3AvOFl3Y0hjcFFKWkgwVHppRU9heTk0SHlLSW5wQVl3ejdIWHBqbUNL?=
 =?utf-8?B?SGhDZ29ialVsdVZCaEczRXRVMWk0YkNHV0hKQVB1YXk3ZndlWHErUWNMV1NH?=
 =?utf-8?B?NGU0eHBHTGphUHRNMWpkVUNCM0pYL0J3YS9FN0paS0pPQjFrUTZUU2xDTmJ5?=
 =?utf-8?B?S0RvTFpvNkpLenByNGwyMGpLcm5peTVyYklId1l3Y1R3aUYyeDZyeFdXNUtX?=
 =?utf-8?B?RHpHWU1kL2ljRGJRRjkxdW5PUnNiRHJmR3lVK1VPYUZuQ1o0QzBYRGtYeE5D?=
 =?utf-8?B?Z1QzV2lyWGNVbjRCWWdFazNYM2lFdEZHR3hqNC81d1l6Y2VseGNDNEh5T2F3?=
 =?utf-8?B?MjQwUStnaTJWSE8zSlFxbmtWcklDUFlIVnFqRmwxWmpBZXhLaXM5MHhiQUJX?=
 =?utf-8?B?LzNMMDdkSnpIWFdyUzZMVFRKNWNVUWt6MTVoMGZoKy9Nb0xzNkJiYmQxWUJo?=
 =?utf-8?B?Slg5RUo5cjJ2dSttdnhGa1E4VVlQbmVWaStXMTI0SVQrdVJMNVFGRGRyWE1I?=
 =?utf-8?B?NkZMbnR0OWNkcVc4TW9NcElzdnFxZ21naXZ5RlNSTnY4dUg0NkNVb2s2RzBP?=
 =?utf-8?B?TGVNTlFxdG9vZVlCVzlJbmdvcW5PKy9reU1oY1c3LzJUYnpvQmc3Z0dHdnFW?=
 =?utf-8?B?MVlEZjhha0JTVzNWR2VSUjhRSnlRMFZTcVhUNVlEMHRqRDZ1TUJHRXkxTitx?=
 =?utf-8?B?eUdxMHlLTVRXS2QvSWY2M25hd3RjNjNWaUNHSEUvcWlVK3BydmRiOHk3aVpk?=
 =?utf-8?B?S0x4SGxudDQxQ3V2bzg5WmVTaFlkaE1VZHd3WHEvcjVPSTY5bWQzdlR6U0U0?=
 =?utf-8?B?d1F5Z2ladGRTN0xDRHBiN3h1c2NKK3cxL29RMk1ybnZPM21adm50SFVxTm1S?=
 =?utf-8?B?MklUdXN5V1BBL0pWb0NlYWo5OXo0d3ZNblVQZ2pqL1ZZSzlRQjVVTjk4SHlq?=
 =?utf-8?B?VzNyOTF2cHNjZm1DQ21xdTdrMG5CcE1OYVVmZmdVc3I5aDVQeUgzakdzaVZE?=
 =?utf-8?B?OWtIbE9iSU9QL09WUXFJVFZQQTNkS0xMWit4VEFtSG1ld0FDNkNHUTVOWUw2?=
 =?utf-8?B?OWxZUTl4ZGNodUpXQi93b2pKZC84T1RSTzJ0bmtrbG9FaUsyMzcvUUlzV0RZ?=
 =?utf-8?Q?LfmrAZkuBu+VJTDuhieaz4WwU?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b9f2c1c7-60f1-4e01-6150-08db930e7fb1
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB6309.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Aug 2023 04:11:08.8254
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zCJ87Z+/M5pf58RlDXk09IVYvGp4fnbZYQ2cRisJwrM1H0J20jt37IEhmjqpgt7/gzH8osPor7FEeqKGuvDfPQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6059
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 8/1/2023 9:19 PM, Tom Lendacky wrote:
> On 7/22/23 06:18, Nikunj A Dadhania wrote:
>> Add a snp_guest_req structure to simplify the function arguments. The
>> structure will be used to call the SNP Guest message request API
>> instead of passing a long list of parameters.
>>
>> Add two helper functions for filling up the parameters:
>> handle_guest_request() and handle_guest_request_ext(). GET_EXT_REPORT
>> queries for certs_data from the AMD Security processor.
>> handle_guest_request_ext() provides those extra parameters for
>> receiving certs_data from the AMD security processor.
>>
>> Signed-off-by: Nikunj A Dadhania <nikunj@amd.com>
>> ---
>>   .../x86/include/asm}/sev-guest.h              |  11 ++
>>   arch/x86/include/asm/sev.h                    |   7 --
>>   arch/x86/kernel/sev.c                         |  15 ++-
>>   drivers/virt/coco/sev-guest/sev-guest.c       | 107 ++++++++++++------
>>   4 files changed, 93 insertions(+), 47 deletions(-)
>>   rename {drivers/virt/coco/sev-guest => arch/x86/include/asm}/sev-guest.h (80%)
>>
> 
>> @@ -398,6 +393,46 @@ static int handle_guest_request(struct snp_guest_dev *snp_dev, u64 exit_code,
>>       return 0;
>>   }
>>   +static int handle_guest_request(struct snp_guest_dev *snp_dev, u64 exit_code,
>> +                struct snp_guest_request_ioctl *rio, u8 type,
>> +                void *req_buf, size_t req_sz, void *resp_buf,
>> +                u32 resp_sz)
>> +{
>> +    struct snp_guest_req guest_req = {
>> +        .msg_version = rio->msg_version,
>> +        .msg_type = type,
>> +        .vmpck_id = vmpck_id,
>> +        .req_buf = req_buf,
>> +        .req_sz = req_sz,
>> +        .resp_buf = resp_buf,
>> +        .resp_sz = resp_sz,
>> +        .exit_code = exit_code,
>> +    };
>> +
>> +    return snp_send_guest_request(snp_dev, &guest_req, rio);
>> +}
>> +
>> +static int handle_guest_request_ext(struct snp_guest_dev *snp_dev, u64 exit_code,
>> +                    struct snp_guest_request_ioctl *rio, u8 type,
>> +                    void *req_buf, size_t req_sz, void *resp_buf,
>> +                    u32 resp_sz, void *certs_data, size_t *npages)
>> +{
>> +    struct snp_guest_req guest_req = {
>> +        .msg_version = rio->msg_version,
>> +        .msg_type = type,
>> +        .vmpck_id = vmpck_id,
>> +        .req_buf = req_buf,
>> +        .req_sz = req_sz,
>> +        .resp_buf = resp_buf,
>> +        .resp_sz = resp_sz,
>> +        .exit_code = exit_code,
>> +        .data = certs_data,
>> +        .data_npages = npages,
>> +    };
>> +
>> +    return snp_send_guest_request(snp_dev, &guest_req, rio);
>> +}
> 
> I'm not sure these intermediate funcitons are really necessary. Can't you create/build the struct in get_report() and get_ext_report() and then just call snp_send_guest_request() directly from those functions?

No particular preference, for tsc_info in sev.c I have build the structure directly and called snp_send_guest_request() directly. I will remove the above helper functions.

Regards,
Nikunj