Received: by 2002:a05:6358:700f:b0:131:369:b2a3 with SMTP id 15csp579412rwo; Wed, 2 Aug 2023 00:13:45 -0700 (PDT) X-Google-Smtp-Source: APBJJlEukikuSZ022sI9VtW8nJ5ThMAmLQEZSMsrn8RlGPaJQQ0+oVwHbi72uF6jB6e3NuQQz6c2 X-Received: by 2002:a05:6512:3ae:b0:4f8:4177:e087 with SMTP id v14-20020a05651203ae00b004f84177e087mr3100715lfp.47.1690960425234; Wed, 02 Aug 2023 00:13:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690960425; cv=none; d=google.com; s=arc-20160816; b=Fr2E1UniRYoYSVDiZBs6WRR0TZJg4Ntq8ROIJpiSTgQc602hlQOpHlcGOlbzCM4lNn Fk6dvLYXolm3FWX0ExjC4zHsCGE6cb2IO/VJGI1aevC9l84Nk0cUb1JByIkJ209xJmpd gHRARkc62rqW2Ya2kLHxCrutKdQL+9H7wl8+VyGQi1EOe6T/I4AesQNL2/nlXh0PAZr2 C/+wBQ7UoItYGOTO/3yqEltzHx38A0kT0y8ItTqaCeXZ/RupPEUYCx8cUdtzq+T9dOwO hjlzDkiCBxLWY8B+5oE5UkylNZKlzNeLfOWefCUOgoFOhlJn1gWAsLfrQiH8YSeqoaRE HGpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=cBmft9zObNED1hEN557daaH3vgQyPvKjk5of9RddlO4=; fh=M7zDVNG5wYj+Ni7TE5shUh1U8LRNWB+keJIKRth6hag=; b=JjAmFRdvF7cXLTC9TxTew3UrcHsbwABADkEX1x8MNqhsh+xhcMdQWAFfDVlyBdncTT ld7pZc0j9LNwCyt2o5JkON3DcjN8bKutdvNQKvA9+rn6hVPFhHmMYCCWcewVsXMYEBA9 CPEeyFneYW0T0mTRLZl7saQuDWWkpZ262D4RzBUrljg55CbrBYEQ0azKv4Mc6Yewu3ku ar+XKLJA+9kvP0EPLvsNS9fx9llRnAvbZS5SY29Gpm/4itbZyTcAxPSxaC6ntzwQzihh hS9fWS+3L1YQfznifWmU7xqkT6GZ6VOyngFyDlBRT9Ry1JGzt92in5ZuJs6hPCYGeFhz L/wg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q2-20020aa7d442000000b0052228b411e4si4931582edr.203.2023.08.02.00.13.17; Wed, 02 Aug 2023 00:13:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230115AbjHBGxE (ORCPT + 99 others); Wed, 2 Aug 2023 02:53:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41820 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232784AbjHBGwg (ORCPT ); Wed, 2 Aug 2023 02:52:36 -0400 Received: from out28-101.mail.aliyun.com (out28-101.mail.aliyun.com [115.124.28.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E74D23598 for ; Tue, 1 Aug 2023 23:52:12 -0700 (PDT) X-Alimail-AntiSpam: AC=CONTINUE;BC=0.2889314|-1;CH=green;DM=|CONTINUE|false|;DS=CONTINUE|ham_regular_dialog|0.00195208-5.61741e-05-0.997992;FP=0|0|0|0|0|-1|-1|-1;HT=ay29a033018047190;MF=sunran001@208suo.com;NM=1;PH=DS;RN=5;RT=5;SR=0;TI=SMTPD_---.U6Zjv98_1690959088; Received: from localhost.localdomain(mailfrom:sunran001@208suo.com fp:SMTPD_---.U6Zjv98_1690959088) by smtp.aliyun-inc.com; Wed, 02 Aug 2023 14:51:30 +0800 From: Ran Sun To: alexander.deucher@amd.com Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Ran Sun Subject: [PATCH] drm/amdgpu/atomfirmware: Clean up errors in amdgpu_atomfirmware.c Date: Wed, 2 Aug 2023 06:51:27 +0000 Message-Id: <20230802065127.12183-1-sunran001@208suo.com> X-Mailer: git-send-email 2.17.1 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix the following errors reported by checkpatch: ERROR: spaces required around that '>=' (ctx:WxV) ERROR: spaces required around that '!=' (ctx:WxV) ERROR: code indent should use tabs where possible Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c index 0b7f4c4d58e5..835980e94b9e 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c @@ -58,7 +58,7 @@ uint32_t amdgpu_atomfirmware_query_firmware_capability(struct amdgpu_device *ade if (amdgpu_atom_parse_data_header(adev->mode_info.atom_context, index, &size, &frev, &crev, &data_offset)) { /* support firmware_info 3.1 + */ - if ((frev == 3 && crev >=1) || (frev > 3)) { + if ((frev == 3 && crev >= 1) || (frev > 3)) { firmware_info = (union firmware_info *) (mode_info->atom_context->bios + data_offset); fw_cap = le32_to_cpu(firmware_info->v31.firmware_capability); @@ -597,7 +597,7 @@ bool amdgpu_atomfirmware_ras_rom_addr(struct amdgpu_device *adev, index, &size, &frev, &crev, &data_offset)) { /* support firmware_info 3.4 + */ - if ((frev == 3 && crev >=4) || (frev > 3)) { + if ((frev == 3 && crev >= 4) || (frev > 3)) { firmware_info = (union firmware_info *) (mode_info->atom_context->bios + data_offset); /* The ras_rom_i2c_slave_addr should ideally @@ -850,7 +850,7 @@ int amdgpu_atomfirmware_get_fw_reserved_fb_size(struct amdgpu_device *adev) firmware_info = (union firmware_info *)(ctx->bios + data_offset); - if (frev !=3) + if (frev != 3) return -EINVAL; switch (crev) { @@ -909,7 +909,7 @@ int amdgpu_atomfirmware_asic_init(struct amdgpu_device *adev, bool fb_reset) } index = get_index_into_master_table(atom_master_list_of_command_functions_v2_1, - asic_init); + asic_init); if (amdgpu_atom_parse_cmd_header(mode_info->atom_context, index, &frev, &crev)) { if (frev == 2 && crev >= 1) { memset(&asic_init_ps_v2_1, 0, sizeof(asic_init_ps_v2_1)); -- 2.17.1