Received: by 2002:a05:6358:700f:b0:131:369:b2a3 with SMTP id 15csp597364rwo; Wed, 2 Aug 2023 00:37:46 -0700 (PDT) X-Google-Smtp-Source: APBJJlFXBTyE7FAcQO1yn1Tz2bl3si+Yuaf+GKo1pLcGxgGUIbXrEoNbNrmULeFvLq/U/eUIzcDD X-Received: by 2002:a17:90a:8905:b0:268:6e77:2024 with SMTP id u5-20020a17090a890500b002686e772024mr11968628pjn.22.1690961866036; Wed, 02 Aug 2023 00:37:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690961866; cv=none; d=google.com; s=arc-20160816; b=MV0ItawLqBINuRpHO/bQcOXF72QzUGLmxj+lhCAPVUpWVajrBn6aseQjCx66BFK3P9 unFSbMCV+cpI6MBG4PZmG9HB+LACsJ+n347I1AdLpge7EHzhM6wgqkN3cfAvEvz3eLiI Cg4ooyE/KR0x1E1USClqZo1iDpoQpufCeXXE3//VX00h/KCZDICE+gXfORxqoVBbpTiz FplyJJKu6I/fL4FgMP1AiUXNchXqe9mchd2KO11Og37KBrTVM0WGjV18hAaFM3TM6YUV u4mupyZcfkoG7WCxBHzBwrCAB1Yj5DMLnQcvuuKpTzlr3r5YPh172ZZiGIfaKD1+qUDa +VmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Zxs2GBjdLNEHxlQzYUVapY0qQ+Jxe+V11KSOfcZZT1M=; fh=g925wv9uJ86MFlNgHhkTJteZgVtj2rxt0gg5bO8sZq4=; b=ET4dFSqUTBaWzhgC64RnglBmLMhCM4Eo78wNoJLCZxcK7F2suzkrsfZOp+9vTCCvRx KYbsRtuRJN7xopPOi/iK3nv2/qH0TnUFeJ8R3Zr1jfKnLnwwbdPxETyOTgqhP5Z1j2Gd OToVWMeTjwW9wDoHvStk5dEvkLhHFjM36s1LKUpGgWwg4XQEjJIulUzDzReInjMkdNLY inz3Jf4u/rsnXcKpzAWmI7B9X6BUA7H756ititDFCiB9e4jF90TBGXqVx5XcS+AdPP8T 7xBGvxMf5k/QT7A3vy/JNZ12YS+7lu5eIQqxYQtbdiIWT6+QZ4ZJJJI0jaOxWAsyYC5e nx5w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=YH+JzhNh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b3-20020a17090a550300b00256d7cc5b67si751539pji.133.2023.08.02.00.37.31; Wed, 02 Aug 2023 00:37:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=YH+JzhNh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232803AbjHBHXF (ORCPT + 99 others); Wed, 2 Aug 2023 03:23:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33542 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232918AbjHBHWs (ORCPT ); Wed, 2 Aug 2023 03:22:48 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ABC211BCC; Wed, 2 Aug 2023 00:22:45 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3F56261826; Wed, 2 Aug 2023 07:22:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 98AF3C433C8; Wed, 2 Aug 2023 07:22:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690960964; bh=+HtAI5H/Tw7Tii5t667xHJhC8OSgK9bBrERPcfSYVVI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YH+JzhNhs9sfDeNTzcs+lz2izUPNPiAeAJR5/+EFKF31dJ4SDoXaqqzIM1ZCGQcxX bGrIOIxvTfYuQs0MBde8gp/6aKjRXW2Lpau48F//zjr6XlUB6I6DX8H1jch5Cp0nsA Q0o8jf5cO/nSCqS0qu84ZcdKuXcPqXqml3tQerqXgxt3Fq/OI3ckCnWsrxTBPx7slR lL0c6qXXgZcM3QI/emUMWq7jy0UEM20w4p+fRZnVajrAAGDSCWbo+ep0ixrinsaQ3u VhhhH/1dD1+ml5jGkGJVzxie0WgtrGq3GoTH7c0uPa2QKLZGPviFqbaupJdefzrerG tvn/CzjDKyF/w== Date: Wed, 2 Aug 2023 09:22:39 +0200 From: Christian Brauner To: Christoph Hellwig Cc: Jens Axboe , "Darrick J. Wong" , Andrew Morton , Matthew Wilcox , Christian Brauner , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Luis Chamberlain , Hannes Reinecke , Johannes Thumshirn Subject: Re: [PATCH 2/6] fs: rename and move block_page_mkwrite_return Message-ID: <20230802-sirenen-arkaden-e76a392f1842@brauner> References: <20230801172201.1923299-1-hch@lst.de> <20230801172201.1923299-3-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230801172201.1923299-3-hch@lst.de> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 01, 2023 at 07:21:57PM +0200, Christoph Hellwig wrote: > block_page_mkwrite_return is neither block nor mkwrite specific, and > should not be under CONFIG_BLOCK. Move it to mm.h and rename it to > vmf_fs_error. > > Signed-off-by: Christoph Hellwig > Reviewed-by: Luis Chamberlain > Reviewed-by: Hannes Reinecke > Reviewed-by: Johannes Thumshirn > --- Reviewed-by: Christian Brauner