Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 2 Aug 2023 09:30:23 +0200
From:   Carsten =?UTF-8?B?U3BpZcOf?= <mail@carsten-spiess.de>
To:     Conor Dooley <conor@kernel.org>
Cc:     Jean Delvare <jdelvare@suse.com>,
        Guenter Roeck <linux@roeck-us.net>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        Magnus Damm <magnus.damm@gmail.com>,
        linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v3 2/2] dt-bindings: hwmon: add renesas,isl28022
Message-ID: <20230802093023.1a926c9f.mail@carsten-spiess.de>
In-Reply-To: <20230801-implicate-mullets-bd160bbda4b2@spud>
References: <20230801163546.3170-1-mail@carsten-spiess.de>
        <20230801163546.3170-3-mail@carsten-spiess.de>
        <20230801-implicate-mullets-bd160bbda4b2@spud>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/BXJ0gOwyb3HW7efOE0ScJsd";
 protocol="application/pgp-signature"; micalg=pgp-sha512
Precedence: bulk

--Sig_/BXJ0gOwyb3HW7efOE0ScJsd
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable


On 8/1/23 22:52, Conor Dooley wrote:
> On Tue, Aug 01, 2023 at 06:35:46PM +0200, Carsten Spie=C3=9F wrote:
> > Add dt-bindings for Renesas ISL28022 power monitor.
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - renesas,isl28022 =20
>=20
> You've only got one compatible, why the enum? Will there be more similar
> devices that have an incompatible programming model?
Yes, there are isl28023 and isl28025 with different register addresses,
might be supported in future releases.

> > +  renesas,shunt-range-microvolt:
> > +    description: | =20
>=20
> You don't need these |s if you have no formatting to preserve in the
> text.
Will fix in v4.

> Otherwise, this does look good to me.
Thanks, regards
Carsten

--Sig_/BXJ0gOwyb3HW7efOE0ScJsd
Content-Type: application/pgp-signature
Content-Description: Digitale Signatur von OpenPGP

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEWM+MlUpz/bWsZllTM1JQzV9LKSwFAmTKBg8ACgkQM1JQzV9L
KSy4vQ//dinrXdpL3D10oTIGl0kARpvszyxqIVr3F8i4Rgd/u6cbw+vYvZICDRQs
IMFVkkXAtG8elJ+903hfMcczi31ORuESpVU/5Ymww65QZICRBbSpxVdN5I+SVMHP
jz0y9Xnr3yLI/BIGmlnYjBGCMbqa3XPxtxHhIEwpEnxpvDzl+/ecxNn8lKPCSmjc
lfTRmDme9eWca0v4Ck61SH+wppNHID1tgnv2l/GL5fnEzjuhPDZxReESEsZELOn8
vSq4XYn1WGdS9fTzj6R2jqu04nOFtS0bxbcUs3cZfg9GjXcgZeAUn2Ig2wPmu7ie
MvzgkFzjhGRqiXXE92MrILC3ozgZCgnWSGmlN/sk/nGsr2Vb3L8frBRCGeQIshJV
EcIs7YsHFpGsuN61zDxETWE/hG/HdRBK82tK/sesBl1+uTW+wXJqyA+2SAkgfp1Z
sBWw/7LGxKDTiZpR3vFEOi+Umo6K6NLny/oy/diiTghZEozhL9dALRMbNy17mn6J
uGRS0G/Alphe2KOiaWMvI26rO1q3wiTIogCrbHrbnFFRgNwVtBKPuEzLJTLAWHWU
XxAyDaFykGXeXCt9Ltc4mrAq+KqXdIlP7igucLxo5B/mbakLMkuLl9PCObt5TQGL
+wIYqzXw5Xom2iZnoQJ4Kpv6rMpIDoYpZ0i/pJJ+E7E6uL/Kcis=
=2qU5
-----END PGP SIGNATURE-----

--Sig_/BXJ0gOwyb3HW7efOE0ScJsd--