Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230801082433.548206-1-daniel.baluta@oss.nxp.com>
 <20230801082433.548206-2-daniel.baluta@oss.nxp.com> <87cz06uypz.wl-kuninori.morimoto.gx@renesas.com>
In-Reply-To: <87cz06uypz.wl-kuninori.morimoto.gx@renesas.com>
From:   Daniel Baluta <daniel.baluta@gmail.com>
Date:   Wed, 2 Aug 2023 10:54:35 +0300
Message-ID: <CAEnQRZAn2W3kD-FsUdjKR7TuYvZwkSXOKBUgwLrqDBeGXV3bFw@mail.gmail.com>
Subject: Re: [PATCH 1/2] ASoC: simple-card: Introduce playback-only/capture
 only DAI link flags
To:     Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc:     Daniel Baluta <daniel.baluta@oss.nxp.com>, broonie@kernel.org,
        alsa-devel@alsa-project.org, robh+dt@kernel.org, spujar@nvidia.com,
        tiwai@suse.com, perex@perex.cz, linux-kernel@vger.kernel.org,
        linux-imx@nxp.com, devicetree@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Aug 2, 2023 at 2:31=E2=80=AFAM Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
>
>
> Hi Daniel
>
> Thank you for your patch.
> This is not a big deal, but...
>
> > We need this to signal that DAI link supports only 1 direction that
> > can only be either playback or capture.
> (snip)
> > +     if (of_property_read_bool(node, "playback-only"))
> > +             is_playback_only =3D true;
> > +
> > +     if (of_property_read_bool(node, "capture-only"))
> > +             is_capture_only =3D true;
>
> More simply
>
>         is_playback_only =3D of_property_read_bool(node, "playback-only")=
;
>         is_capture_only  =3D of_property_read_bool(node, "capture-only");


Good point. Will fix in v2.

>
> > +     ret =3D asoc_simple_parse_link_direction(dev, node, prefix,
> > +                                            &is_playback_only,
> > +                                            &is_capture_only);
> > +     if (ret < 0)
> > +             return 0;
> > +
> > +     dai_link->playback_only =3D is_playback_only;
> > +     dai_link->capture_only =3D is_capture_only;
>
> It doesn't overwrite when error case, so
> More simply
>
>         ret =3D asoc_simple_parse_link_direction(dev, node, prefix,
>                                                 &dai_link->playback_only,
>                                                 &dai_link->capture_only);

Can do this because dai_link->playback_only is a bitfield.