Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757303AbXJ3RjR (ORCPT ); Tue, 30 Oct 2007 13:39:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753800AbXJ3RjA (ORCPT ); Tue, 30 Oct 2007 13:39:00 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:36837 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753529AbXJ3Ri7 (ORCPT ); Tue, 30 Oct 2007 13:38:59 -0400 Date: Tue, 30 Oct 2007 17:38:58 +0000 From: Christoph Hellwig To: bo yang Cc: linux-scsi@vger.kernel.org, James.Bottomley@SteelEye.com, akpm@osdl.org, linux-kernel@vger.kernel.org, Sumant.patro@lsi.com Subject: Re: [PATCH 3/8] scsi: megaraid_sas - add module param max_sectors, cmd_per_lun Message-ID: <20071030173858.GB16455@infradead.org> References: <1191253908.5850.12.camel@dhcp-75-534.se.lsil.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1191253908.5850.12.camel@dhcp-75-534.se.lsil.com> User-Agent: Mutt/1.4.2.3i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1200 Lines: 29 On Mon, Oct 01, 2007 at 11:51:48AM -0400, bo yang wrote: > +/* > + * Number of sectors per IO command will be set in megasas_init_mfi > + * if user does not provide > + */ > +static unsigned int max_sectors; > +module_param_named(max_sectors, max_sectors, int, 0); > +MODULE_PARM_DESC(max_sectors, > + "Maximum number of sectors per IO command"); > + > +/* > + * Number of cmds per logical unit > + */ > +static unsigned int cmd_per_lun = MEGASAS_DEFAULT_CMD_PER_LUN; > +module_param_named(cmd_per_lun, cmd_per_lun, int, 0); > +MODULE_PARM_DESC(cmd_per_lun, > + "Maximum number of commands per logical unit (default=128)"); I don't think this should be in drivers. cmd_per_lun is a scsi_host attribute already and you should change the mid-layer to add an optional host template method that allows the sysfs file to be writeable. max_sectors should be handled similar although we don't seem to have an attribute for it yet (maybe the block layer does?) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/