Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <16f07bd5-f62b-5288-74a4-4547ef077d46@quicinc.com>
Date:   Wed, 2 Aug 2023 14:23:59 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.1
Subject: Re: [PATCH v5 3/6] nvmem: core: Add stub for nvmem_cell_read_u8
Content-Language: en-US
To:     Mukesh Ojha <quic_mojha@quicinc.com>, <agross@kernel.org>,
        <andersson@kernel.org>, <konrad.dybcio@linaro.org>,
        <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
        <conor+dt@kernel.org>, <srinivas.kandagatla@linaro.org>
CC:     <linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <20230724084155.8682-1-quic_kbajaj@quicinc.com>
 <20230724084155.8682-4-quic_kbajaj@quicinc.com>
 <3e193791-613f-b500-75a1-5f36cefe0ddc@quicinc.com>
From:   Komal Bajaj <quic_kbajaj@quicinc.com>
In-Reply-To: <3e193791-613f-b500-75a1-5f36cefe0ddc@quicinc.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 7/24/2023 6:06 PM, Mukesh Ojha wrote:
>
>
> On 7/24/2023 2:11 PM, Komal Bajaj wrote:
>> This change add the stub function for nvmem_cell_read_u8.
>
> "Add the stub nvmem_cell_read_u8() function for drivers running with
> CONFIG_NVMEM disabled"

Okay, will update the commit description.

Thanks
Komal

>
> -Mukesh
>
>> This will be helpful when a driver uses this function and
>
>
>
> -Mukesh
>
>> CONFIG_NVMEM is not enabled.
>>
>> Signed-off-by: Komal Bajaj <quic_kbajaj@quicinc.com>
>> ---
>>   include/linux/nvmem-consumer.h | 6 ++++++
>>   1 file changed, 6 insertions(+)
>>
>> diff --git a/include/linux/nvmem-consumer.h 
>> b/include/linux/nvmem-consumer.h
>> index fa030d93b768..5c88635d4c2b 100644
>> --- a/include/linux/nvmem-consumer.h
>> +++ b/include/linux/nvmem-consumer.h
>> @@ -125,6 +125,12 @@ static inline int nvmem_cell_write(struct 
>> nvmem_cell *cell,
>>       return -EOPNOTSUPP;
>>   }
>>   +static inline int nvmem_cell_read_u8(struct device *dev,
>> +                     const char *cell_id, u8 *val)
>> +{
>> +    return -EOPNOTSUPP;
>> +}
>> +
>>   static inline int nvmem_cell_read_u16(struct device *dev,
>>                         const char *cell_id, u16 *val)
>>   {