Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     "Liu, Yi L" <yi.l.liu@intel.com>,
        "joro@8bytes.org" <joro@8bytes.org>,
        "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
        "jgg@nvidia.com" <jgg@nvidia.com>,
        "robin.murphy@arm.com" <robin.murphy@arm.com>,
        "baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>
CC:     "cohuck@redhat.com" <cohuck@redhat.com>,
        "eric.auger@redhat.com" <eric.auger@redhat.com>,
        "nicolinc@nvidia.com" <nicolinc@nvidia.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "mjrosato@linux.ibm.com" <mjrosato@linux.ibm.com>,
        "chao.p.peng@linux.intel.com" <chao.p.peng@linux.intel.com>,
        "yi.y.sun@linux.intel.com" <yi.y.sun@linux.intel.com>,
        "peterx@redhat.com" <peterx@redhat.com>,
        "jasowang@redhat.com" <jasowang@redhat.com>,
        "shameerali.kolothum.thodi@huawei.com" 
        <shameerali.kolothum.thodi@huawei.com>,
        "lulu@redhat.com" <lulu@redhat.com>,
        "suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>,
        "Duan, Zhenzhong" <zhenzhong.duan@intel.com>
Subject: RE: [PATCH v4 09/12] iommu/vt-d: Add iotlb flush for nested domain
Thread-Topic: [PATCH v4 09/12] iommu/vt-d: Add iotlb flush for nested domain
Thread-Index: AQHZvh/uFyWMLiVXhUCSOYKFk2h4da/WraUQ
Date:   Wed, 2 Aug 2023 07:46:39 +0000
Message-ID: <BN9PR11MB527690EBAA872A16AE8926F88C0BA@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20230724111335.107427-1-yi.l.liu@intel.com>
 <20230724111335.107427-10-yi.l.liu@intel.com>
In-Reply-To: <20230724111335.107427-10-yi.l.liu@intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?gUygnrNI93GgXKlidP7N+aqBYxtGbusOQkpPGJAajzp0aUo5B9nYjDxSd2HY?=
 =?us-ascii?Q?yu2peixaEt6KhwknPoXXbvTdQ+APkfBcbn8jUxYbEip8Gac2Rd+9xNznzD9o?=
 =?us-ascii?Q?3lKNerkikeeeZt0LTjSyvqtObqqcRWyve1mRljHhdxS6g9T3juoBHQCmOqsi?=
 =?us-ascii?Q?pUXvJF0toEmTPc5CgrrAjlCsdW1QwBdWkNz7zqmfgvgDlusgpPGNk7rpG55N?=
 =?us-ascii?Q?QMaQ8MRxulbkVqH08ync9kY9UoboZQZIUf/6wA1psvRdB8zfYlniLe6FQkTs?=
 =?us-ascii?Q?zfeuthJcRwqmKT1CSjlTdtVsS1I5Wrdgh4hfzxAsIKBwHGmD2oInUOpvgSKF?=
 =?us-ascii?Q?i/+raVmL/jsUGyDCZPkaclCKZ94GXmUzQ87+XNcZ0hZvL9y33SXoGj8uYzUL?=
 =?us-ascii?Q?O0u+y3zYpqeHOVJq8X/j/+qRRiLC+tFcoW9SJgIf3r9CURoOnz6Yl1sLIqF3?=
 =?us-ascii?Q?u3u8wZOKmKj3iKOrsTvLh3sKuMOEycXRDrrU/SaFPGBmC0BjxUj3t7/eEC13?=
 =?us-ascii?Q?R0j0CNG5OEYBuB0+NWHVLQgNsatD1y47eEs7QVzHd7S7EjrQG70LR4zQ4/Gm?=
 =?us-ascii?Q?fHP/TRfJNWykxE1XKEPBCvzaLo72RjCPY3S2oB9cYDvO4yyUvJfWuvFf9Cp7?=
 =?us-ascii?Q?GNAyVd7ZjU8PNKaqHrbG+c4ssDhBTzTpMA7exxZJW3lNi7GsxmtNDls+xtcZ?=
 =?us-ascii?Q?8pfjauK/UzByEsnQDQafQAxyyKpHMj13ytqzIHrvoiIxJZQhJXTU9J/awVvU?=
 =?us-ascii?Q?4fNdRM14tt3px6YNFfWA+r/HIGQ7HcbwTlltjBu8uvn+KnBVdazaX1xMz1Pm?=
 =?us-ascii?Q?lingOwZya1kzkN1AisZjh2jbGjBPlBpKWbFPPeIMHLPwII2aTuxk1N/JW/WI?=
 =?us-ascii?Q?vOCo0Wt60YqXbo8Uju5JA3vI/KucjOafKa+srfzRgPf5wosw6q21NquL69bG?=
 =?us-ascii?Q?lvgAgQr9gOA4e8xhYENhuOQr+u2fMVCmnVJxh8eJPr3CHbpPcgMSw7JJvzcq?=
 =?us-ascii?Q?iEd8zIthgjPvbrb0krr1Pe4yapXv6P+ZWMuSd/VoCQ/mWWg4N/pRNBkNRkt4?=
 =?us-ascii?Q?iNftFpBXJhASJAYN8lRQizczhPZVr0dX/aZUaBoYOd3cU3JjamGk6CK6xxFi?=
 =?us-ascii?Q?xwDFg9M/hW2YoX7PsZVxQRlVnu9WuVYa2sbgpNQaXsO0rY2CUW7bHk13y04T?=
 =?us-ascii?Q?jmVZ7gZbZ/xejDmrS6g94co3GJ7/IcvZt+U9vgT0BKJwmJLMeoojrdtN5iym?=
 =?us-ascii?Q?pi5vREpIZknMhYq7PxLhaUpqRu3K1M2FNgJ4tR5tYBgPfvDkNunfj+SaEm1V?=
 =?us-ascii?Q?f6zMfNDy+P+x0jsNdIzQgXlmm9hz98HZBZXYIIzbuKnDOKRNVKXPX4lRM3Fg?=
 =?us-ascii?Q?0qjABQAQknUU5kG6C2mCLfHmFICPCJgqLEFOOqrlEvRTiQTAI5RfsDIRTkZm?=
 =?us-ascii?Q?LvEbuuF2dSm+RRU8DlnAtQO5KBcN6xBB9PlIkT10USoBRMeQQm2fA5wiy2TY?=
 =?us-ascii?Q?FzJWAhBX97p88MhOn54io9KdtEoMNSN3lZ1YX0hR02s5/LwqDUoDQUKvRzg8?=
 =?us-ascii?Q?Z9FXIb9TkovJReqPam9flhzgptoWvAetFnN83D4z?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a48cc4e4-41f5-4955-31fb-08db932c9b6f
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Aug 2023 07:46:39.8127
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: WvLaedf9tJlEuwcqDpBZLE7OtkEbL7r4BPW58ximGPdb4ZjPbedTxAqW/dsW7UsCY+bMNKN3J6S1qAV4Bk1v7A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4957
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Liu, Yi L <yi.l.liu@intel.com>
> Sent: Monday, July 24, 2023 7:14 PM
>=20
> +static int intel_nested_cache_invalidate_user(struct iommu_domain
> *domain,
> +					      void *user_data)
> +{
> +	struct iommu_hwpt_vtd_s1_invalidate_desc *req =3D user_data;
> +	struct iommu_hwpt_vtd_s1_invalidate *inv_info =3D user_data;
> +	struct dmar_domain *dmar_domain =3D to_dmar_domain(domain);
> +	unsigned int entry_size =3D inv_info->entry_size;
> +	u64 uptr =3D inv_info->inv_data_uptr;
> +	u64 nr_uptr =3D inv_info->entry_nr_uptr;
> +	struct device_domain_info *info;
> +	u32 entry_nr, index;
> +	unsigned long flags;
> +	int ret =3D 0;
> +
> +	if (get_user(entry_nr, (uint32_t __user *)u64_to_user_ptr(nr_uptr)))
> +		return -EFAULT;
> +
> +	for (index =3D 0; index < entry_nr; index++) {
> +		ret =3D copy_struct_from_user(req, sizeof(*req),
> +					    u64_to_user_ptr(uptr + index *
> entry_size),
> +					    entry_size);

If continuing this direction then the driver should also check minsz etc.
for struct iommu_hwpt_vtd_s1_invalidate and iommu_hwpt_vtd_s1_invalidate_de=
sc
since they are uAPI and subject to change.

> +		if (ret) {
> +			pr_err_ratelimited("Failed to fetch invalidation
> request\n");
> +			break;
> +		}
> +
> +		if (req->__reserved || (req->flags &
> ~IOMMU_VTD_QI_FLAGS_LEAF) ||
> +		    !IS_ALIGNED(req->addr, VTD_PAGE_SIZE)) {
> +			ret =3D -EINVAL;
> +			break;
> +		}
> +
> +		spin_lock_irqsave(&dmar_domain->lock, flags);
> +		list_for_each_entry(info, &dmar_domain->devices, link)
> +			intel_nested_invalidate(info->dev, dmar_domain,
> +						req->addr, req->npages);
> +		spin_unlock_irqrestore(&dmar_domain->lock, flags);

Disabling interrupt while invalidating iotlb is certainly unacceptable.

Actually there is no need to walk devices. Under dmar_domain there
is already a list of attached iommu's.=20