Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8556fd68-edb1-5b97-6472-ae854f86190b@quicinc.com>
Date:   Wed, 2 Aug 2023 18:34:04 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.14.0
Subject: Re: [PATCH 3/3] clk: qcom: add clock controller driver for
 qca8386/qca8084
Content-Language: en-US
To:     Randy Dunlap <rdunlap@infradead.org>, <agross@kernel.org>,
        <andersson@kernel.org>, <konrad.dybcio@linaro.org>,
        <mturquette@baylibre.com>, <sboyd@kernel.org>,
        <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
        <conor+dt@kernel.org>, <p.zabel@pengutronix.de>
CC:     <linux-arm-msm@vger.kernel.org>, <linux-clk@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <quic_srichara@quicinc.com>
References: <20230801085352.22873-1-quic_luoj@quicinc.com>
 <20230801085352.22873-4-quic_luoj@quicinc.com>
 <188bcc4c-7388-ca39-5c3c-629edd78cc9f@infradead.org>
From:   Jie Luo <quic_luoj@quicinc.com>
In-Reply-To: <188bcc4c-7388-ca39-5c3c-629edd78cc9f@infradead.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 8/2/2023 3:16 AM, Randy Dunlap wrote:
> 
> 
> On 8/1/23 01:53, Luo Jie wrote:
>> diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig
>> index 263e55d75e3f..a17e8fa5a7e1 100644
>> --- a/drivers/clk/qcom/Kconfig
>> +++ b/drivers/clk/qcom/Kconfig
>> @@ -195,6 +195,14 @@ config IPQ_GCC_9574
>>   	  i2c, USB, SD/eMMC, etc. Select this for the root clock
>>   	  of ipq9574.
>>   
>> +config IPQ_NSSCC_QCA8K
>> +        tristate "QCA8K(QCA8386 or QCA8084) NSS Clock Controller"
>> +        help
> 
> The 2 lines above should be indented with one tab (only; no spaces).
> 
>> +          Support for NSS(Network SubSystem) clock controller on
> 
> The line above should be indented with one tab + 2 spaces (like the following
> 3 lines).
> 
>> +	  qca8386/qca8084 chip.
>> +	  Say Y if you want to use network function of switch or PHY
>> +	  function. Select this for the root clock of qca8xxx.
> 
thanks Randy for the review, i will update the patch for this.