Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ed25e9f5-c98c-4c72-b3f3-6db7bf395459@alu.unizg.hr>
Date:   Wed, 2 Aug 2023 13:06:57 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH v1 01/11] selftests: forwarding: custom_multipath_hash.sh:
 add cleanup for SIGTERM sent by timeout
Content-Language: en-US, hr
To:     Petr Machata <petrm@nvidia.com>
Cc:     Ido Schimmel <idosch@idosch.org>, razor@blackwall.org,
        Ido Schimmel <idosch@nvidia.com>, netdev@vger.kernel.org,
        linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, Shuah Khan <shuah@kernel.org>
References: <20230722003609.380549-1-mirsad.todorovac@alu.unizg.hr>
 <ZLzj5oYrbHGvCMkq@shredder>
 <0550924e-dce9-f90d-df8a-db810fd2499f@alu.unizg.hr>
 <adc5e40d-d040-a65e-eb26-edf47dac5b02@alu.unizg.hr>
 <ZL6OljQubhVtQjcD@shredder>
 <cab8ea8a-98f4-ef9b-4215-e2a93cccaab1@alu.unizg.hr>
 <ZMEQGIOQXv6so30x@shredder>
 <a9b6d9f5-14ae-a931-ab7b-d31b5e40f5df@alu.unizg.hr>
 <ZMYXABUN9OzfN5D3@shredder> <875y5zf27p.fsf@nvidia.com>
 <304ba960-0214-82d4-05be-e5956baa64c7@alu.unizg.hr>
 <87o7jpenpd.fsf@nvidia.com>
From:   Mirsad Todorovac <mirsad.todorovac@alu.unizg.hr>
In-Reply-To: <87o7jpenpd.fsf@nvidia.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 2.8.2023. 12:33, Petr Machata wrote:
> 
> Mirsad Todorovac <mirsad.todorovac@alu.unizg.hr> writes:
> 
>> On 8/1/23 13:08, Petr Machata wrote:
>>> diff --git a/tools/testing/selftests/net/forwarding/mirror_gre_changes.sh
>>> b/tools/testing/selftests/net/forwarding/mirror_gre_changes.sh
>>> index aff88f78e339..5ea9d63915f7 100755
>>> --- a/tools/testing/selftests/net/forwarding/mirror_gre_changes.sh
>>> +++ b/tools/testing/selftests/net/forwarding/mirror_gre_changes.sh
>>> @@ -72,7 +72,8 @@ test_span_gre_ttl()
>>>      	RET=0
>>>    -	mirror_install $swp1 ingress $tundev "matchall $tcflags"
>>> +	mirror_install $swp1 ingress $tundev \
>>> +		"prot ip flower $tcflags ip_prot icmp"
>>>    	tc filter add dev $h3 ingress pref 77 prot $prot \
>>>    		flower skip_hw ip_ttl 50 action pass
>>>    
>>
>> The problem seems to be fixed in the test run:
>>
>> root@defiant:tools/testing/selftests/net/forwarding# ./mirror_gre_changes.sh
>> TEST: mirror to gretap: TTL change (skip_hw)                        [ OK ]
>> TEST: mirror to ip6gretap: TTL change (skip_hw)                     [ OK ]
>> TEST: mirror to gretap: tunnel down/up (skip_hw)                    [ OK ]
>> TEST: mirror to ip6gretap: tunnel down/up (skip_hw)                 [ OK ]
>> TEST: mirror to gretap: egress down/up (skip_hw)                    [ OK ]
>> TEST: mirror to ip6gretap: egress down/up (skip_hw)                 [ OK ]
>> TEST: mirror to gretap: remote address change (skip_hw)             [ OK ]
>> TEST: mirror to ip6gretap: remote address change (skip_hw)          [ OK ]
>> TEST: mirror to gretap: tunnel deleted (skip_hw)                    [ OK ]
>> TEST: mirror to ip6gretap: tunnel deleted (skip_hw)                 [ OK ]
>> TEST: mirror to gretap: underlay route removal (skip_hw)            [ OK ]
>> TEST: mirror to ip6gretap: underlay route removal (skip_hw)         [ OK ]
>> WARN: Could not test offloaded functionality
>> root@defiant:tools/testing/selftests/net/forwarding#
> 
> OK, I'll add your Tested-by, let it pass through our regression and send
> upstream.

Great stuff.

Though, all these were incompatibilities in the testing scripts, not really a bug
in the kernel proper ...

Have a nice day!

Mirsad

-- 
Mirsad Todorovac
System engineer
Faculty of Graphic Arts | Academy of Fine Arts
University of Zagreb
Republic of Croatia, the European Union

Sistem inženjer
Grafički fakultet | Akademija likovnih umjetnosti
Sveučilište u Zagrebu