Received: by 2002:a05:6358:700f:b0:131:369:b2a3 with SMTP id 15csp931820rwo; Wed, 2 Aug 2023 06:28:02 -0700 (PDT) X-Google-Smtp-Source: APBJJlGOMr+/ubOuJntF86RqMIGjtsJEHtt+bNg4sdvxMYjYOCIY9En+haG/mbGc0M7jaWoaRdqP X-Received: by 2002:a05:6a20:1444:b0:133:bbe0:312f with SMTP id a4-20020a056a20144400b00133bbe0312fmr19610038pzi.50.1690982881888; Wed, 02 Aug 2023 06:28:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690982881; cv=none; d=google.com; s=arc-20160816; b=cktqMcahrRLIsyIeaZnpLGJ832hwZiHL3zcfKizncdDT1lcjdYfKlFkyHLae13sBTt XFUao4VtwSqprj/Vqty6xeHuMhaeEC8jip3o73Aj1W0QfAwi/ynsguKhZzNBR1FccuiV l9R6QB+5JuBtXF/4A0ZkMAVh8TTAWgrYXTZIMlxvQdu/056pXInXJdbFFOKoCrEH8Kyy TNdNPPgw/asrNWsHds5Bj8lBKuY7OvW+oi/cVEJwMd/It1z8ueZLfLk/bskAjnGQNNBl jTd3gG4Evg/hYXgysCa+xmjjeMF5Ybxe/rHqt9tBmG+iqxWIi+4RY8NKl8LLEqW5mNZa rVeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=4ab3GBgwKIO10gaSlc0RTzmhdSzbBvrq8O6cOw4GtT0=; fh=qi7wCCwZxhgDF5fmSP0lvzQvCIoh4z/2RwOeLycP6nI=; b=ybu18VFAu56vEqsG+tQSNENc9iwDJqVGfRxnt7gN3ApcHgaj8PIOfqWILFfdQTPlBD 7/GHhsbNBMt+mxhbQuAgm5xyC20mm463e6rMFIxpYwgEPaaBrPYKALRWkVuhbZ1zaLpK /jTmM01i6h1ib+9ULZCNbLtBjyPoqtlMTDUo8u55jck6chIE2xjspPDOyPD4L8N37pRD oDNTzDj+J0rAKqVyt8SCnRkNrCKM2uyK7xS+Q0avq6iz4ULrDyXoqRztO4dRcXYzSWow 1pD23bihwjFd7+yiHL+rK99DnHNJ50rzFYQoQZDF+QZ5WsWbGzMyL+ykyyQp6/t9qQ8y AwPA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=iiLAOATK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x5-20020a654145000000b00563fe2c1163si7488088pgp.168.2023.08.02.06.27.49; Wed, 02 Aug 2023 06:28:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=iiLAOATK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234507AbjHBMhl (ORCPT + 99 others); Wed, 2 Aug 2023 08:37:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57848 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234498AbjHBMhl (ORCPT ); Wed, 2 Aug 2023 08:37:41 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B683D2718 for ; Wed, 2 Aug 2023 05:37:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=4ab3GBgwKIO10gaSlc0RTzmhdSzbBvrq8O6cOw4GtT0=; b=iiLAOATKrbDDzwGM0wgHxZ6GSE U5WQgdgmbZXe3Iy1e4WjW7hOQuE1RBjldaZ7XhL32Kd9TkMVDgADECgdZfXu4evOfN2uCDP7eNLl/ GjzQYBxhpedsmyAenLPuLfDdG+HxRpJIeAUiz2gg6I6Pu3GROIN9hrnPXqS2Udrxl4hwNy0S+Sux4 AQSUYC0FAWh7BCDjBAh6vnGRdDir99V8GalYCs26a2jFYsrfDjJQyR8BuCQbGJ1Kuy9t+jCe3W1+c QprGGZajo7oiqPmfPrIcieYtUj8zVZLIB4b2Ip8Bc/reli6NSODXmhbJIHYGtLjeMaJgL1aK5odeB YwCXGZPA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qRB6Y-00EyMw-3l; Wed, 02 Aug 2023 12:37:30 +0000 Date: Wed, 2 Aug 2023 13:37:30 +0100 From: Matthew Wilcox To: Kefeng Wang Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Huang Ying , David Hildenbrand Subject: Re: [PATCH 4/4] mm: migrate: use __folio_test_movable() Message-ID: References: <20230802095346.87449-1-wangkefeng.wang@huawei.com> <20230802095346.87449-5-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230802095346.87449-5-wangkefeng.wang@huawei.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 02, 2023 at 05:53:46PM +0800, Kefeng Wang wrote: > Use __folio_test_movable(), no need to convert from folio to page. > > Signed-off-by: Kefeng Wang In my defence, I did many of these function conversions before __folio_test_movable() existed ;-) Reviewed-by: Matthew Wilcox (Oracle)