Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <097de164-6d62-6a1d-f7b5-cbd7d4408ab7@wolfvision.net>
Date:   Wed, 2 Aug 2023 14:34:28 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
From:   Michael Riesch <michael.riesch@wolfvision.net>
Subject: Re: [PATCH 3/4] drm/panel: sitronix-st7789v: add support for partial
 mode
To:     Maxime Ripard <mripard@kernel.org>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Neil Armstrong <neil.armstrong@linaro.org>,
        Sam Ravnborg <sam@ravnborg.org>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Miquel Raynal <miquel.raynal@bootlin.com>,
        Sebastian Reichel <sre@kernel.org>,
        Gerald Loacker <gerald.loacker@wolfvision.net>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        dri-devel@lists.freedesktop.org
References: <20230718-feature-lcd-panel-v1-0-e9a85d5374fd@wolfvision.net>
 <20230718-feature-lcd-panel-v1-3-e9a85d5374fd@wolfvision.net>
 <tbdwgfr4rqgytttoxhidsil42mda77qj3qmhw2do3k5rmwsaeh@qronuzdubv6q>
Content-Language: en-US
In-Reply-To: <tbdwgfr4rqgytttoxhidsil42mda77qj3qmhw2do3k5rmwsaeh@qronuzdubv6q>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NTRMNzArN1kxdUMwTnBMWElPVHFnM0FiVy81V3RqUUlBZXRLZVNSeWJlY2xO?=
 =?utf-8?B?M2p1djZwR1hFeFI0WnhYL2FQamFkcUZVWXM5THd3NUlFWmpSMGcvZG1hMjdj?=
 =?utf-8?B?WjVBRWRDSy95VVVJVmNBL1IyNFowZ2tQRVpzMmNSY0pCb0FTSHhHN0tXNXZr?=
 =?utf-8?B?YWFGeFJYNHA5TGJyOUNEV09IK3VQMlIzbXd1RlhtQ1RXLzRWYWlieGVBeGJ4?=
 =?utf-8?B?WnJUR3MrZkJrdDV0d2tOaUg0VitpSlMxU1UrcDRzVlp2anJsNFdCWnpGVGxq?=
 =?utf-8?B?Mmg5aWpScDdUUkZLVytFQjgwUVJBTkEzeUgzMFFJM2R2TmlLZld0WC94bnkw?=
 =?utf-8?B?THFyMlA2aEszS1E2QnJwL2RjMzUwYjA4NGZKYzVrL0s4bTYvY2NTN3g3Wmdq?=
 =?utf-8?B?SFFHMytiWEk1L2ZpUUtiNk9oNUJFUkVHbzFBSlIvRXEyam0wUlhBSlF4Nk5m?=
 =?utf-8?B?MXJsZkcwWlVuL0E5QTN2WStIbGhkc0hzVFRhRzdjTWJaQVFZajNqc1VWbkJD?=
 =?utf-8?B?bmlwM2h2TXNtblo4OFJwWUQxUFZzc3VXZ21QQkE3Q01nNnBFNkw5czBWUkdU?=
 =?utf-8?B?emlSUDYxWXVzMUIyNWFrbkgxQlRYVWI0VXp3VjRrakd0QkZ4ankySmd6NW43?=
 =?utf-8?B?aVFCZDJITnluWkFBaUJzb0tNSm9kSnJ4R3gyUGRFY0FRVkZ0bE1QZXlFNkpp?=
 =?utf-8?B?OE4wd21MbExwdXJQSjMxTHUwa3NQOTFpUzRNT3JOMlFyaHZTWUdFTDZlSloy?=
 =?utf-8?B?Mi9yTnpaSUhsOUNnS1hLdkRoWkkyNkEzWXRLb3JpN2hvakkrMUorRXVIZVIx?=
 =?utf-8?B?R0NJNDdML09yelJLZVN5a0Z0OGRzZ081OHZNQWtCYjRDQTlIVDRqOEV4dkxR?=
 =?utf-8?B?UVVzbk1VNkZIaGppTjJhc0VpZE5hVWN5STZvVFE4RE5UWFZ1bGh5em03eExx?=
 =?utf-8?B?cWk0azBkdURzQkkyYUdQa3ovY3kwVzJMMlEyenZYR0owdEZydlc5bk5haHJq?=
 =?utf-8?B?bkJvY0hkSmxsRk1UZHVsZFBjOEFDa2RhemhXdFlSbWxqNS8xd2wvRlRkWjB5?=
 =?utf-8?B?blEycFg4Ly9GbXRPWDdhVlRUUTVSMFBGOG5UOVlOYzJpc2l1REJEcmVZUyt0?=
 =?utf-8?B?SlpmTVFIUVBoS0sxdlRNaGMvWS8vbGNEZWcrQmF5d3Z1RXpxRXZuWExqcHVX?=
 =?utf-8?B?bHJxaUtTOHYyQkNiTXJYeW1tZUIxV3RSY0J3OFd5TythdGtUeGdXT2dpOHVB?=
 =?utf-8?B?RkhOdzBXKzIraGM3ZzhqNWw4VG9kRU5KYi9GMVBzRTFrQ1B3cUx6TjJxcVJz?=
 =?utf-8?B?blVSQy9oeVhxWlNqUklPd3F1T0wrNnlqZzBoZ3A4VlBPdzlvYjQ2YmZqbW05?=
 =?utf-8?B?REl4SW5xSzBMbXc5aWdkT2ZPM2FSQW8vVUF0c0tzTE1RZnBIbVhvZFY0Wnhz?=
 =?utf-8?B?TkNUeklzN2lrRHlueWRuVzA4YXJld2NkMVhoNzhhbnlwcFU3dXFHRDVVejQv?=
 =?utf-8?B?Qlp3dDUvTkovTmtYWXpNdkFCK285VGNWYlNUVWVpNkZJNS9Xb3k5dHJPQ0w2?=
 =?utf-8?B?ekZvWFBpMkFzb0hWem9IeXlWQnBoUXJMYjFuM0xuMGdDTzNhQm5Za3NDcmFz?=
 =?utf-8?B?TkxHS0xNczB6bDEvU3Nob01pZkd2OXZOejg1c3BJVlpKTXhtTmhpa1ZwOWFm?=
 =?utf-8?B?ZFF0SUNrMWJMUlg5Tmk4OWtPVm91Z0xpcXlJS1pWZUxCU3F5TDRiK0RVbXlR?=
 =?utf-8?B?Z3NPcmFwMzhmZXpGQ3JzWk9uVzU5Q2d5V1dzSmZ6MmVoYkNBbWpjOEZkSHVY?=
 =?utf-8?B?U0pqcm9Sbm5zdTNLOURFY1RaaVBlWW53VlNxS1hFNmpOS2trc1J1UkJnbkRG?=
 =?utf-8?B?dUdCUStUMHZVa2lXUzVReHEyRE1LZEEzN1dDdkRVM21TTFNxa0xPcjF4MTZF?=
 =?utf-8?B?WFozVEg4dTU1RWhQZVErOHZaOVc2NkpnMlNJS0xONnZQa3FQZUFsYk94dkRh?=
 =?utf-8?B?RnoxbmZJSExTQlROVHd3ZVVRZWVtTVRveFlySUJFdmQ3VzNKRUt2bnVyWkFh?=
 =?utf-8?B?M3pEVy92UzVKYTZPb09GN2RjUXhiTmN6YlRhU0tlRzVMT2FyaTdDTlhTazdk?=
 =?utf-8?B?MVRpT3ZRMDRiNDQyMXdiSFRRK2RqUWtJb2hBU3dtbkl1cmFvRVFsU2RQMnBm?=
 =?utf-8?B?U0FZbkk2Q0I1ajhHSDNnWlFOd3BmU0trb2JEZ1RwRnpDbHphSmxpRyt3TU5W?=
 =?utf-8?B?b2lYOXpyMlBmTFI0d1FLbXQveDlnPT0=?=
X-OriginatorOrg: wolfvision.net
X-MS-Exchange-CrossTenant-Network-Message-Id: beb24c9a-1a04-4912-1205-08db9354d378
X-MS-Exchange-CrossTenant-AuthSource: GV2PR08MB9158.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Aug 2023 12:34:33.8959
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: e94ec9da-9183-471e-83b3-51baa8eb804f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gfuDyOr0+gMs9Wba3iyCZsMJeYuRn7zfMA8tXu0pvSg/5keybr8pvOZwu2jR+Tg+6B6ZWyV7NUn9nB3HXbmxyV2oTVQUB7K983r4n4MXMbU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6147
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Maxime,

On 7/19/23 08:39, Maxime Ripard wrote:
> Hi,
> 
> On Tue, Jul 18, 2023 at 05:31:52PM +0200, Michael Riesch wrote:
>> The ST7789V controller features support for the partial mode. Here,
>> the area to be displayed can be restricted in one direction (by default,
>> in vertical direction). This is useful for panels that are partially
>> occluded by design. Add support for the partial mode.
>>
>> Signed-off-by: Michael Riesch <michael.riesch@wolfvision.net>
> 
> We already had that discussion, but I think we shouldn't treat this any
> differently than overscan for other output.

Indeed we had that discussion. For reference, it can be found here:
https://lore.kernel.org/dri-devel/20230329091636.mu6ml3gvw5mvkhm4@penduick/#t
The thing is that I am still clueless how the overscan approach could work.

I found some DRM properties related to overscan/margins and I guess
userspace needs to set those. On my system weston is running. Is weston
in charge of configuring the corresponding output so that the correct
margins are applied? If so, how can this be achieved?

Will DRM handle the properties generically or does the driver need to do
some work as well?

In any case it could make sense to write the partial mode registers and
enter the effective dimensions. At least I have seen this in other panel
drivers.

Thanks and best regards,
Michael

> 
> Maxime