Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <eb50a427-3738-c1bb-b8cd-8636902deffb@intel.com>
Date:   Wed, 2 Aug 2023 20:50:36 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.13.0
Subject: Re: [PATCH 1/3] mm: add functions folio_in_range() and
 folio_within_vma()
Content-Language: en-US
To:     Ryan Roberts <ryan.roberts@arm.com>, <linux-mm@kvack.org>,
        <linux-kernel@vger.kernel.org>, <akpm@linux-foundation.org>,
        <yuzhao@google.com>, <willy@infradead.org>, <david@redhat.com>,
        <shy828301@gmail.com>, <hughd@google.com>
References: <20230728070929.2487065-1-fengwei.yin@intel.com>
 <20230728070929.2487065-2-fengwei.yin@intel.com>
 <55c9e3f7-099d-6f57-32da-1f318a9688a0@arm.com>
From:   "Yin, Fengwei" <fengwei.yin@intel.com>
In-Reply-To: <55c9e3f7-099d-6f57-32da-1f318a9688a0@arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ak5XWTZyaXFPekVKV21WWVMwa3VoZXhZd0pnNmdHSjZOS0prazJtL3lZMTBG?=
 =?utf-8?B?KzlialZUbzc2Z21pM1ZJb0NSblVBTEp5aTRvMTkwbVVkRzJqdXovSXdETlFI?=
 =?utf-8?B?ZHdyalc4a1ZZWjgveG9tOTJHajJJSk1WOUJyVW5hZ3ZmUVRaZVlqaWRWOXZO?=
 =?utf-8?B?d1dCamRSZDVQV2FQSHlpVHlPZFhSYTY0eXd3eVpuWVhvU3BhMlhHZHVvNmww?=
 =?utf-8?B?L0pvNTJERVhnY0J0RGdRWmdqY3ZnQmFTZlpYVG0xcUgzcDRJSDhRWEVDUFNv?=
 =?utf-8?B?bTVqdmh0ejBzWU9nY1JLc0JzaTM3WnlIY0JVc2dTeGFLYkhFaFhXblRPQUZN?=
 =?utf-8?B?dEdIYXN1SVRMSUh5bDdXRDdjdHJGLzFrR05jQzBBVGEvOWNNMHNjSEZVb1dB?=
 =?utf-8?B?Tm1KWGdZdE1rUURmOGFKcTBrczFSUC9XOFJPUHhCWWl5NlRKYmxFSzFLNlZM?=
 =?utf-8?B?b0xwSWZCc2F3ZThUUWk3akNTa1dVWmFKWXpGV1UyTUlTWlZ0TjNJZkM1d05u?=
 =?utf-8?B?QjBIZlFTTU1Eb0k5Snpib3pUOWlHTzJMN1F2ZVpoT0FPd21vVjdWdjRURWpO?=
 =?utf-8?B?RDFJTXVKSkUzV0hWUXhUVDd5dWFLTkxYenhnTUI0R0hzR0tkSENRSHBBSUZ1?=
 =?utf-8?B?c3VDOC9mWWlTOE96aUV6dGNlRnNZQ1NvQW14YmNocGVWU05zZjJoNzZHRnM1?=
 =?utf-8?B?dkllWEVETk45TG1Kd2YzQkpNUDl1TElFVXVnVExTeHdqVVNOL290dXpaa1FE?=
 =?utf-8?B?cWdSZGwybzRqcFdnekhyRXpCa1dsbXZac2JDYkVqQXRhUzFJbnNnNTczY2ll?=
 =?utf-8?B?b1VBcUF4eVYzRStNVnJhY09CVVZsTCtPK3FWMHZRYmlMaTZ1aFVjSEpxSWc1?=
 =?utf-8?B?Mkh4NHNITEVvdUhldmMrZkhEbmorY2JmWmpSYzBBSGdSSTZ3NzZuc1FpRUlO?=
 =?utf-8?B?a3J3RUpzOUNhNWFlZExpeDNQWlhjcCtOVE5HVm1rdDljRU1yak9qTnBaUmZl?=
 =?utf-8?B?aXRkaWd4ckJKWDNGYktRdWtSNysxbmJJL2ROWXJiNGpYanBWQUQ5SVlBdkty?=
 =?utf-8?B?MkF6OUJobWhRby94NzZlVDhmYXNDU2U2QjFDSjV3aHJRVHRHYStkWkNoL1Ru?=
 =?utf-8?B?bmRLVDlraWlPbTdRT0xFVHlHSGNEWk9maG1TaFhuZ3pCQ2Z1RTF3aTJnWHcx?=
 =?utf-8?B?Z0NCUVFMOWk3TDlxT0hXUC9XaVlGZktuK3JOd2JNTkZ1LzZPSHZaSy8rOXVk?=
 =?utf-8?B?RzJ6TE5DVHdObC96ajVaa3F3V2UyeEpFNTlLaW5iR1YxRTd5bEFHcVM4U25R?=
 =?utf-8?B?M0NidlB0eWtqNkRCUGZxVXR4eVR5QzR3bjFHL2RLdGFwa3hQOERKT0hlSkVG?=
 =?utf-8?B?MFpyTXpBQkJRY2xnZDZJdjVPU2VsYkFZK05vQXRtQ2VZVWRDdGFhUWNVY3ZY?=
 =?utf-8?B?eVZmN3VEelc3VDRMdU1odW9uOWpHMmROTW16dFN0UCtFVUtIVnVKWm1FeVNw?=
 =?utf-8?B?akpGTnZNSnFCdWxxZm5JQlBxVHJXd1FINS9uOEhTdUlUd1FaQ1JSQVN3Zko1?=
 =?utf-8?B?QzlseFlEYXd1K1R4SHBvYkdhRWNzb2tzb0ZWajdkQnNjTlVmQlo5R3NNUzlH?=
 =?utf-8?B?QzJZdkVJZDdIZk9CV25oYnZHVXVDaDUwQkFVQTN3eHB0M0REd09NVUVuREtE?=
 =?utf-8?B?TWNaL1hhSE9hMWVydFpIeDB4bTJCZUR0VlhsZXgzUGxPWnhnSUZkeGcvUlZC?=
 =?utf-8?B?bWNFMkNlL2VBbEkrVXE3K3djSVRXVkt4TGV3ZUlYODBNTFVlRy96QkhyR29v?=
 =?utf-8?B?b3FjOXVFb2VRSk9LaXZDejlFYkZkQndjMG9sRWI3akRkNnZXWTVxYWFtSnhk?=
 =?utf-8?B?ODlLYy8xNVl6Y3hlNWdDRWdUMnhDYUpnVjg1ZkJQOUdocnVNd1JldkpSWlBS?=
 =?utf-8?B?emN3eklDOGN3dHlPNGpKS2s2a3RiWVJqakViYVhvZ0tZUW5Lcldadjg3clBj?=
 =?utf-8?B?WGFVZEhVVVUwaGJ0dmIrTW9EaVlIVS90anZmeDdPSUVrUTF1Vy96aEhjUkpH?=
 =?utf-8?B?S2x2S3F3ZE15ek52WTJPNVNUdkcwL2ZxaE1uMk9DN2ZoYm5RTDB0SmJ3a3lm?=
 =?utf-8?Q?uu8n23o9WeWyJA/0+GSWyjzhO?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 504d8433-35f2-4c48-5e5c-08db935716f9
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Aug 2023 12:50:46.2400
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Oc1nPNapNMrM+LGkGNS8a4ag0tgjWdvOa+1plyCSYM35uZbOXFfWR7hH+D30O4SB6HRmlSKuGIemLK9N148y1w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB8065
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 8/2/2023 7:14 PM, Ryan Roberts wrote:
> On 28/07/2023 08:09, Yin Fengwei wrote:
>> It will be used to check whether the folio is mapped to specific
>> VMA and whether the mapping address of folio is in the range.
>>
>> Also a helper function folio_within_vma() to check whether folio
>> is in the range of vma based on folio_in_range().
>>
>> Signed-off-by: Yin Fengwei <fengwei.yin@intel.com>
>> ---
>>  mm/internal.h | 69 +++++++++++++++++++++++++++++++++++++++++++++++++++
>>  1 file changed, 69 insertions(+)
>>
>> diff --git a/mm/internal.h b/mm/internal.h
>> index 5a03bc4782a2..63de32154a48 100644
>> --- a/mm/internal.h
>> +++ b/mm/internal.h
>> @@ -585,6 +585,75 @@ extern long faultin_vma_page_range(struct vm_area_struct *vma,
>>  				   bool write, int *locked);
>>  extern bool mlock_future_ok(struct mm_struct *mm, unsigned long flags,
>>  			       unsigned long bytes);
>> +
>> +/*
>> + * Check whether the folio is in specific range
>> + *
>> + * First, check whether the folio is in the range of vma.
>> + * Then, check whether the folio is mapped to the range of [start, end].
>> + * In the end, check whether the folio is fully mapped to the range.
>> + *
>> + * @pte page table pointer will be checked whether the large folio
>> + *      is fully mapped to. Currently, if mremap in the middle of
>> + *      large folio, the large folio could be mapped to to different
>> + *      VMA and address check can't identify this situation.
>> + */
>> +static inline bool
>> +folio_in_range(struct folio *folio, struct vm_area_struct *vma,
>> +		unsigned long start, unsigned long end, pte_t *pte)
> 
> This api seems a bit redundant to me. Wouldn't it be better to remove the vma
> parameter and instead fix up the start/end addresses in folio_within_vma()?
My understanding is it's necessary. As for madvise, we need to check whether
the folio is both in the range of VMA and also in the range of [start, end).

> 
>> +{
>> +	pte_t ptent;
>> +	unsigned long i, nr = folio_nr_pages(folio);
>> +	pgoff_t pgoff, addr;
>> +	unsigned long vma_pglen = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT;
>> +
>> +	VM_WARN_ON_FOLIO(folio_test_ksm(folio), folio);
>> +
>> +	if (start < vma->vm_start)
>> +		start = vma->vm_start;
>> +	if (end > vma->vm_end)
>> +		end = vma->vm_end;
>> +
>> +	pgoff = folio_pgoff(folio);
>> +	/* if folio start address is not in vma range */
>> +	if (pgoff < vma->vm_pgoff || pgoff > vma->vm_pgoff + vma_pglen)
>> +		return false;
>> +
>> +	addr = vma->vm_start + ((pgoff - vma->vm_pgoff) << PAGE_SHIFT);
>> +	if (addr < start || end - addr < folio_size(folio))
>> +		return false;
>> +
>> +	/* not necessary to check pte for none large folio */
>> +	if (!folio_test_large(folio))
>> +		return true;
>> +
>> +	if (!pte)
>> +		return false;
>> +
>> +	/* check whether parameter pte is associated with folio */
>> +	ptent = ptep_get(pte);
>> +	if (pte_none(ptent) || !pte_present(ptent) ||
>> +			pte_pfn(ptent) - folio_pfn(folio) >= nr)
>> +		return false;
>> +
>> +	pte -= pte_pfn(ptent) - folio_pfn(folio);
>> +	for (i = 0; i < nr; i++, pte++) {
>> +		ptent = ptep_get(pte);
>> +
>> +		if (pte_none(ptent) || !pte_present(ptent) ||
>> +				pte_pfn(ptent) - folio_pfn(folio) >= nr)
>> +			return false;
>> +	}
> 
> I don't think I see anything to ensure you don't wander off the end (or start)
> of the pgtable? If the folio is mremapped so that it straddles multiple tables
> (or is bigger than a single table?) then I think pte can become invalid? Perhaps
> you intended start/end to always be within the same pgtable, but that is not
> guarranteed in the case that folio_within_vma() is making the call.
If pte is invalid for any reason (pass wrong parameter, not fully mapped etc), this
function just return false in page table entry check phase.

> 
> Also I want to check that this function is definitely always called under the
> PTL for the table that pte belongs to?
Yes. I should spell it out. Thanks.


Regards
Yin, Fengwei

> 
>> +
>> +	return true;
>> +}
>> +
>> +static inline bool
>> +folio_within_vma(struct folio *folio, struct vm_area_struct *vma, pte_t *pte)
>> +{
>> +	return folio_in_range(folio, vma, vma->vm_start, vma->vm_end, pte);
>> +}
>> +
>>  /*
>>   * mlock_vma_folio() and munlock_vma_folio():
>>   * should be called with vma's mmap_lock held for read or write,
>